From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AFC9481679 for ; Wed, 29 Jul 2026 13:35:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785332156; cv=none; b=CACmp1PzugJeswCR11/BbKGSKqc3HoVGJc68p+YqRpQVqFYPjW+Omafu7fxk2hKZnR3CPBpllOqJ6fnMtbL2Jq2u8bKO46xbfouxcYvZXvRXFAIcyiJXNg9MZgdVI4RGvtflkx3sKL6tEEFr9+C3/9dWpa/32p7HtC9ae69HNyM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785332156; c=relaxed/simple; bh=K4ve5MfBbzgfCTnxntzKAnrEEY2G6SACbQzvWrRRI/0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FGPl1H/0gOI/ns6jDRtrBzpNFTL+l7TAdMJqZMKH5j2985OqES+q2y6MTwMxet+VBE9TJtB9pgGmbro58agI8HzeBjX3RDbMuseYwGXX52uZoNw9DUzbf5Fr9ze5yweINCpUJFWZ6B4QJxN447ZTJajMEUqFeCZOO0YSVFmQoC0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fBeDVZli; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fBeDVZli" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-38e041ea211so1048396a91.0 for ; Wed, 29 Jul 2026 06:35:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785332150; x=1785936950; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FdnYKHj4vwBiQ41/lPUNxhmPYmA1whHhMDsyY4GnBq8=; b=fBeDVZliYdxhR0cgS41bi1R900OplsXh44sGSYPvvcwcxLMmg/FIA8M0xZhSLdKBPL 5bVniUzAUhyNFNBrcr38oo3Z5ZdxclxoFRwMKH1jTTXdqgJTIblUYYHA/9/+C0LMlZig jiGCqqMU4HD2WJtq+zvJg3P5qxoUrQVefVZzxMDOUdUmvwH1PeIRP3iQDmlSJc3w5ZwC IpZLMsLzeE3+E8o3dgEkw/DWT/B62KGg31CAenqnTYsKsaLZUb7shTKZ7P9+CuTCIcdI d4EbFyU5VKw/IT3hjQ2aWaia/Hs4d3Xt6Rl3jPnxgLGuwKqNCOD3A79qU1EHR/rWF13G BuFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785332150; x=1785936950; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=FdnYKHj4vwBiQ41/lPUNxhmPYmA1whHhMDsyY4GnBq8=; b=ZFaZKT8juIo+7fi3mwEJh449f6ofrwUfrQJKSGEf4QXys6vuo3J6/FzYMhxyCJWZ9B RrU2/vyIca3INAvM/SU8oUcuZqFHwX/VjTSKoMYYGbn7wBMb4eXX3d8iBps1YRGuE+Pe BN3/1Yf2BZ2HuN75io2557n/1x8d5EnBA98p0ibXQurGptNRaaQo7JbitqSzmKNLDYEM jnz6ZFWZybpUGCqS3JamYmRt4b2nEPHAUeqCr6/xxKG3GAnQYJokiwI4JbgeMYwWRr9+ ZBUIWJ0qDO5YIOiF45FSM+D8DKvDIgePbtbBiyhvn4yCBGOmK/c2MSeievBZVKCqqioz 8xtA== X-Forwarded-Encrypted: i=1; AHgh+RqpRLPfawnBLfEJanFTzj9XsaHpdpwodd5eoy4OJLWH3k4HRfzwvY4aF7AjHpEJhHGJkoMbsI+hh3fBfCY=@vger.kernel.org X-Gm-Message-State: AOJu0YwPVJeRw3Bq5b+ve+N5vc5Z0jnkuAOuRWs35x3ctx1kij2oNdlt xw4rc0g5Td6l9Xyt4MiYzP5HIJIW1M6yBh7M5f4OSMHvEkWIS5K1TpyfW0FCrVlI/ao= X-Gm-Gg: AR+sD10n6H+E3jWUSb5EmBKCMrKSM//G4m8U7bL++DAXZAAGA8XGU1LKlFT8QFF5+EE 1fZppPUB6LL4LGOiIKBFPOq9BNFdy63W7j4HYXrD1Epanc1p8+L384s3ANTkOj83tYY5ZZeLfEj e8tkq4YNEFl/DdFo+IFX06xYceMmIxgw4esNkAOWJQ2Oay40/3HHeeyrMCY7KZNjuQuErVW/ZFk XTY7DKsQMs71kYk75HA29qW3iIH3qvqmvlHKcMu9j2yZsr3yIvLAqV1K0DHtK9Ziz9cjPtFwfsW Kfnx3SCpVOcLb2uy1LFcGTOr880AiS5eMz1FIz+Aez3/zXIKMmlHfvddmN90PKFzYRQ3q6cR6uq +DoIiD1CM4qV4U4lFIQOgg2wyPsVRJIfHfVkl4jabOm2pcFGEwmiwUio3tG9YMm6Csw61cEdYQc vOCziK20PvySzm6S990SE7bylI4Ec+HW/CQ+d8q1wNyjd4Mi14JBOvuCOqRvjNyNV3x5EuvELDe te1e8PKqQSKtlMgwpwgllmnaOrGpD4= X-Received: by 2002:a17:90b:1645:b0:387:e0bb:57f8 with SMTP id 98e67ed59e1d1-38f6a4d6731mr6737970a91.41.1785332149629; Wed, 29 Jul 2026 06:35:49 -0700 (PDT) Received: from fedora.mrout-thinkpadp16vgen1.punetw6.csb ([223.181.51.44]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31504baa01dsm11051142eec.12.2026.07.29.06.35.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 06:35:48 -0700 (PDT) From: Malaya Kumar Rout To: zhanjie9@hisilicon.com, linux-pm@vger.kernel.org, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, cw00.choi@samsung.com, kant@allwinnertech.com Cc: skhan@linuxfoundation.org, me@brighamcampbell.com, Malaya Kumar Rout , linux-kernel@vger.kernel.org Subject: [PATCH v2] PM / devfreq: userspace: Fix memory leak in userspace_init() Date: Wed, 29 Jul 2026 19:05:22 +0530 Message-ID: <20260729133523.357383-1-malayarout91@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <511c7f13-3344-44bf-a960-044fc2401789@hisilicon.com> References: <511c7f13-3344-44bf-a960-044fc2401789@hisilicon.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fix a memory leak in the userspace_init() function where allocated memory is not freed when sysfs_create_group() fails. When sysfs_create_group() fails, the function returns without freeing the memory allocated for 'data', leading to a memory leak. This patch adds proper error handling to free the allocated memory and reset governor_data to NULL on failure. v2: - Removed redundant 'out:' goto label and returned -ENOMEM directly on allocation failure. Fixes: 5fdded844892 ("PM/devfreq: governor: Add a private governor_data for governor") Signed-off-by: Malaya Kumar Rout --- drivers/devfreq/governor_userspace.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/devfreq/governor_userspace.c b/drivers/devfreq/governor_userspace.c index 3906ebedbae8..8211aadb81f0 100644 --- a/drivers/devfreq/governor_userspace.c +++ b/drivers/devfreq/governor_userspace.c @@ -89,15 +89,18 @@ static int userspace_init(struct devfreq *devfreq) int err = 0; struct userspace_data *data = kzalloc_obj(struct userspace_data); - if (!data) { - err = -ENOMEM; - goto out; - } + if (!data) + return -ENOMEM; + data->valid = false; devfreq->governor_data = data; err = sysfs_create_group(&devfreq->dev.kobj, &dev_attr_group); -out: + if (err) { + kfree(data); + devfreq->governor_data = NULL; + } + return err; } -- 2.54.0