From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF5EE453A5C for ; Wed, 29 Jul 2026 15:57:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785340630; cv=none; b=jg28y3JD2zVxsJaEWsQIu3j652KFdn5PMdWKhXNenMY+e57EWGdVdeQF2C16pr3iFk0BFpK7lnw/l/V/42OL/b/zk1fhOU0V21AquebmCO5KopZ6H+3ztTOPRKPeEHOvFMsbfU+FIQlp6OGZV3yCrbtLcMrzxSVYK60XngLwld8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785340630; c=relaxed/simple; bh=/44549ZR9rmU9stCTzJ1LxhK6+SRqSOKEj1GR/fTo6c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WFF6EpTaV+OYiyioUOABDrQN041LIl6of4kOPaQRy5HPrtDMnmymFqbnuhvTlvoUDyaN3E6lOMkqVe/Mb+TNzoYSCWyIaA1Awje0zl1UF+AVnD5fqTheWR3guBxBtn0DKN7WT6am41tEm04mup8KJH1PeM0L+qu5eE4EJ31bYGk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YUurCzJf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DqmwPtLI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YUurCzJf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DqmwPtLI" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66TF3MOH2108399 for ; Wed, 29 Jul 2026 15:57:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=+vxaHAH1d7u WRj+vRMqPMMyCu77C7ZHnpa7ie4VJLtE=; b=YUurCzJfQJ8tzbHZopcXBmX6lbf dZPtHQzqOSAEwf7UKQC6EpeOh088W/UDcX55S92F2CulQ7n9RZ/tF51az0Cand1c qeZB0VW88mcPI7Me4W3/qMtLwalr6KuM1y16kEdlju7uxD8/tnofAAzF1J3PDnI6 C8MGGfSsPpI48F/32JbTWpcUOqMsNAuhkG+213Nnvg2Bo/PbphkqjtHzgACVSRQ6 Om+DNvSpyGTdHUPKH82AgOBLtIctGa6Yt8bMOMAnVCFT14+kVl+MtiKipo+o50l0 GITBd5HiQVoZesvHDY7heYV01AmcDuYX8nSezk2DihzkiU3jGXhgJ9N8sRA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fqkds8fyb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Jul 2026 15:57:07 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2cce14a21faso202885ad.0 for ; Wed, 29 Jul 2026 08:57:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785340627; x=1785945427; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+vxaHAH1d7uWRj+vRMqPMMyCu77C7ZHnpa7ie4VJLtE=; b=DqmwPtLIs//BWZm0sOMOhIBgpg35CZ2SCOc917ldqNPgeBVU3YTG05Wh2JreW6FrX+ xYTMcyXuEf8O7bCk0c3wSzbdnK/QVz06VAMb5ErIHRKxGB7ImoFzBQ18g8zywQwqar+b ZMmQT3WjebsDBPy4xrxV70hmJRAqJYuKis3maxrtxUPlWE0ZD3K0tzpKXT6qoLzE9Kez ly7tzzVLTZLfz2er1k3NRtFEXByYXbn0Ljyag92bpoZ3fNUuRiZL2B6fDj01VH3Mry+F GFguyE/MY41T0z6G6U8oRWy0E2n0o3NmzsiWxX7k7V2nvta21q7H/cma3teFziwI7lhC tMPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785340627; x=1785945427; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+vxaHAH1d7uWRj+vRMqPMMyCu77C7ZHnpa7ie4VJLtE=; b=EOM7zN/eh60UPiP4iN5wSv5IfOBFYynN8NI3WPn7g5CCp/pN3g5P0zCwjvZgMQrL+v SwLNrurDkRNOl8nqqC8KULw4y7Ccv15eHOj7nXis6d9SDX8Bob7+3aIHHDM3F8Enl8oV YretcHm5Smyp5rxH3lnQgoj7Zf/Y0kcOVmqu3eIqOVmxO6/55SxUzUmnYVMAS8oXDOsC DiRwTWpaOz7Ba1/jTl2pfHtpcvrVq+nAP4x1Xz8u7Dnn/NBnI1wx6v8eLAE6E1q1fTbQ bjW4inczwgCU+bESF2CfrU8K+dCc1MYPTc75c5MdTH1bVBTlDaj9dn7+gFEDJhcwJTh7 uMgA== X-Forwarded-Encrypted: i=1; AHgh+RqIZkU+xcNMufs1E0QVer96FjUoFye2nUsrPfm92kZLqWDn/Pqp2zIBR31BIavNqAvvgbUJchV5ZqnWeM4=@vger.kernel.org X-Gm-Message-State: AOJu0YyPFY7dmPypWG1lmciTXzc4iqes5LWnDuefDEgGDY8n3Z38+5iY ezknf65tYAkaw+Awo8f2mk7jN4wZ4o6WEK9W+b9Vbfd4GAAJtXzCXv9BOVgm5Km98mDE5gKQqyD xSE7BYG2vV76kYXIW1NTtH8Nmbs48Xor990qGmVodxQUdl9TBWEhLuW804iSltzCd1x0= X-Gm-Gg: AR+sD11EEkfViS6FJQ9pSkCeoDRNs0xC1kmwlvy3d7NeDirAvFhubp6V9RE1354dxMU QHJASp/EfQ1bhYQqU4REdyVkcnRWO0d7yP/0xQdGTnA+ZbJ7KS5O9V+RWEox14ANk58M8acWGR8 jd8/nmRXfs089YTTzzksJAx6svAJu6XLtl7cQZ9eGoK+yD5Zc2FCCw7wDhkwx2AqGnTk0zDdyYC 9ySOx+rHzQUmThIoayXxgl7c/kRv1SQlQAkrk5Ffbwlf0O2ahgiNchU/+aoaxs3b7DOrQGH2Nsv 68Q7jHD5/ZY0fAyadvK/ko6qM4VgUIzHDrzVoKJBnPv5c1Vn5D8Ars7jzQQ8ME0fxP4IHoKfIkk icDlzBCSKl9UOf3vmqQb18vPmjIZrz/SuDpgmOnnked39IlA= X-Received: by 2002:a17:903:26c8:b0:2cf:461a:3863 with SMTP id d9443c01a7336-2d02676518dmr31347245ad.22.1785340627071; Wed, 29 Jul 2026 08:57:07 -0700 (PDT) X-Received: by 2002:a17:903:26c8:b0:2cf:461a:3863 with SMTP id d9443c01a7336-2d02676518dmr31346935ad.22.1785340626645; Wed, 29 Jul 2026 08:57:06 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d022c2dfb1sm13546035ad.72.2026.07.29.08.57.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 08:57:06 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v7 10/17] drm/msm/gem: Remove useless locking in GEM import Date: Wed, 29 Jul 2026 08:55:47 -0700 Message-ID: <20260729155609.20190-11-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260729155609.20190-1-robin.clark@oss.qualcomm.com> References: <20260729155609.20190-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI5MDEyNyBTYWx0ZWRfX5HdP+2N2RT84 fqIlzcFRrWnKFhVwJdBR6lLZ0IC9f9yGRGeOIMnp77T4FzO3xWka+19IEuzZI/tvAOpTOPaOX9B r4mHZHU8Svfej+2an/t7O2PIdwxLEMg= X-Proofpoint-ORIG-GUID: 1U44yH_8PnMi13tIQzVN-dSVNFYUtnzk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI5MDEyNyBTYWx0ZWRfXwdYAr1vLyD8R /Nl+J4TDCnI/tdzMWQ7Hdqv3+MUS4f1Sixjz6zzNztAfcVZLI+GEn55ipKu7u38IDwM/Fw4Jbv6 IxtoRY5Ku6aZ9hhfZAYgLqniFVYh3bWbRVkWo0AAqkNMX+4QYlje9GCWiduXYQvUSOJaEE2Rn9n YZE9mD9ksgsQeVXYz6911uMpJQu3OQCnQ+LDiMakwqug4w2ZDhITmZa99nWWGTLdfz4J5TsKBAJ OtW0RS/wSEFYkXdZB15Ofcc1DqcVIc1fL7tYRWej5LwaCdHhAgkSEdDWV15y8aLnuyWAZlK6ur7 OxDHgEb0MSYIvmqqWUbtt3msnI4obbvwUQmITvCYVYCWhzDkePlp4ZPbJSm5KZ5VJqQS0LdGrGA oLKQ5hLf2lQ09z4tlKUa0JwAaLCs3fV/bAiITeSSDBYzbFQTQ8tw7hi8ch1d5/nvGaNqxDJL69d 34lT2GnM7CQDU3E4qNg== X-Authority-Analysis: v=2.4 cv=VJTtWdPX c=1 sm=1 tr=0 ts=6a6a22d3 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=eWlSUfSnBrBg5eVjM6UA:9 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: 1U44yH_8PnMi13tIQzVN-dSVNFYUtnzk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-29_06,2026-07-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 malwarescore=0 spamscore=0 phishscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607290127 The locking has changed a few times over the years, and this extra locking was the mistake of evolution. Harmless but useless. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index 74c3728f45bd..cc45392691e5 100644 --- a/drivers/gpu/drm/msm/msm_gem.c +++ b/drivers/gpu/drm/msm/msm_gem.c @@ -1310,22 +1310,17 @@ struct drm_gem_object *msm_gem_import(struct drm_device *dev, npages = size / PAGE_SIZE; msm_obj = to_msm_bo(obj); - msm_gem_lock(obj); msm_obj->pages = kvmalloc_objs(struct page *, npages); if (!msm_obj->pages) { - msm_gem_unlock(obj); ret = -ENOMEM; goto fail; } ret = drm_prime_sg_to_page_array(sgt, msm_obj->pages, npages); if (ret) { - msm_gem_unlock(obj); goto fail; } - msm_gem_unlock(obj); - drm_gem_lru_move_tail(&priv->lru.pinned, obj); mutex_lock(&priv->obj_lock); -- 2.55.0