From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f100.google.com (mail-wr1-f100.google.com [209.85.221.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FB4242C519 for ; Wed, 29 Jul 2026 17:10:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785345050; cv=none; b=CDfS/K8y9AQ1zPBnFTpW38taqZUQsld47CY4b/OTak6/IIHaR7BBbUsUXza2e5ULUo5+Ty3aL24lG2tkJfkLsb8qbrXb0ya++OlnKO97IcoyIBHQZIsmCl2GoPp3wH+i4HjGCZBarT8Vdnt/sQfo6vcCgJ8j6ixf6oiiafuyhd4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785345050; c=relaxed/simple; bh=MXEkjL34ea1s6Q1W61eODupyZj32zu2EgZa08MhdXqk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rAwIN+ytHMJqoVps1zp11WAk+nqU4wh/RgRwzibywpnltUeI2r1pbejattpSe7pB6NNAvwGaJuF8dKT09Lnqgr2ZoLOjYn6+sjGNfc7szLOEJ0/8QRjuCPRcIoG9V+i4MoDWfYqBBjGEyKi0IZg31g3WBHzz/+eq6mnzj1MuNu0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com; spf=pass smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=TPBTsJY/; arc=none smtp.client-ip=209.85.221.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="TPBTsJY/" Received: by mail-wr1-f100.google.com with SMTP id ffacd0b85a97d-47f706438c3so60400f8f.3 for ; Wed, 29 Jul 2026 10:10:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1785345046; x=1785949846; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iLVHhkHBmoWr4hLnZhpWfFYwOT17Jy9Iwi9YgD5R57s=; b=TPBTsJY/KEBKFaoV9u2CuldYr+IhSxu14sLaI2TuAsOpAYtCCHH9UZKZBn6Fmdwol/ Q3C3TCiIPILA/P16GolFTnt2c7e4IFo9WPKHujrnoSIQ+uy+lfX/RWbFc+Si283sgsVe TdRaRNjCG18bMCGMm3UgvKz7VMPxjnmY9jkePf8KuS6izGtKl6BPx73me0g/2TZpun1H iZ+K+IIVj6w129TibhrdTPe2U375BfZBPuI6GD8pDRuErh7j6vNy9XWdsEeDrLH36uzD Apj5fO7DE7hx5qYy2OQojr3XmjAfLvf7WJOPNwLcYYc+JdmjTnAvcOjUtXTdzPlhsIeo Y6Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785345046; x=1785949846; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=iLVHhkHBmoWr4hLnZhpWfFYwOT17Jy9Iwi9YgD5R57s=; b=qzrxIQZJt9cDXbvypxxYb38MuKwxVSd8M1A7cnP/nOcmVYxhw8jgGZiH6Vjm8416Ld FnKG8QLqKrzm4Q6wQq7j5YXIgKKKdB3jVXgGPfYB6xroPdELxTK5YPrvRFL0nHaSifH5 Zh4xBFFcRB+oKJbeD0jarPwxJSlbDBxLN+FkmFPrfMb9cD6CiCSAGxEkO0RoBOWKlBBL a/6Adin/StR9YkHg3h/Y6tBMxTHs7JZHT8bcayVTbvdjtSoZuuv767hIqbRs+lit8S+K rOlX65T8c5wtVRHaZk/fdV23jMuAbMnQA0z3qzk6lb1hKlMpoT0ySoMPUj7Squ247zSO R3AQ== X-Forwarded-Encrypted: i=1; AHgh+RpuDPvupOWWO8W7n8c9x0DTqIgSmTMmoOlu4mrf0G6Z2P9hvA7r3FHKE5N1ZCq8NHVHcPD+e1Q3pT7YuQY=@vger.kernel.org X-Gm-Message-State: AOJu0YyOTXXRaasZcLWATev42Qe7C0G7jPt2ABiJkS4jv9erVtRM2Wsb eJ4G2bnU3Gcw32xY4lcUKr+oOQv56dWb8O36hMxcUVbdpjXTVp7aQh1IDccdO7vcV9gEyVT2EIK nmOa3aRriM8KLxaF67s7aTfw3u9lZqz/zaq6I X-Gm-Gg: AR+sD12MDJexkLaUQbGDFiBicrSstcOEi5uP9xQrQBvkhOH0Zdvdql4Hs45pyzwn82D gRyrffLo2oPwJecY9NjoafGTz2lxWaM3CuRd1lKI0PZhu+Is2r5kmjns7KdxJxueRUCAZksl3Sd w7I6MkHUeYZfOexLu7sgC5/sJSO+aMPpZKQIo+9JvItjuqg1WcSl+ZadFKE81/WQl7sQYkd0qzp 4EMBNGzb8lhmEAor4bPKIoPQJNFiVznpv+VtUhy+sBJY56wADwsE6oBxHlwU6aattAGNo1uDLpW UO5IYzCV388h1pVokzPr37dY6AVZs8r8/8f11YprpxgH9kMJ3qf2HFcXmV5aCiqAjYz2toXSvZg ItXYI+fiZtKauSx3U36MpP65hoSUNJ6+d X-Received: by 2002:a05:600c:1d19:b0:495:4505:dad0 with SMTP id 5b1f17b1804b1-496c641546bmr76812285e9.2.1785345046288; Wed, 29 Jul 2026 10:10:46 -0700 (PDT) Received: from c7-smtp-2026.dev.purestorage.com ([208.88.159.128]) by smtp-relay.gmail.com with ESMTPS id 5b1f17b1804b1-4976bd8bd7fsm2233975e9.14.2026.07.29.10.10.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 10:10:46 -0700 (PDT) X-Relaying-Domain: purestorage.com Received: from dev-csander.dev.purestorage.com (bond0.slc5-n17m28-k8s.dev.purestorage.com [IPv6:2620:125:9025:20::a31:41f]) by c7-smtp-2026.dev.purestorage.com (Postfix) with ESMTP id 1DF7E40202; Wed, 29 Jul 2026 11:10:44 -0600 (MDT) Received: by dev-csander.dev.purestorage.com (Postfix, from userid 1557716354) id 1BC7BE4017C; Wed, 29 Jul 2026 11:10:44 -0600 (MDT) From: Caleb Sander Mateos To: Ming Lei , Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Caleb Sander Mateos Subject: [PATCH v2 3/3] ublk: remove WARN_ON_ONCE() in ublk_unmap_io() Date: Wed, 29 Jul 2026 11:10:41 -0600 Message-ID: <20260729171041.45061-4-csander@purestorage.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260729171041.45061-1-csander@purestorage.com> References: <20260729171041.45061-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit io->res is set from struct ublksrv_io_cmd's result field, which is controlled by the ublk server process, without any validation. It's thus possible for userspace to trigger the io->res > rq_bytes warning. ublk_copy_user_pages() already limits the copy length to the request data length, so drop the warning. Signed-off-by: Caleb Sander Mateos --- drivers/block/ublk_drv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c index 2cbc359dc196..8101c2a73efd 100644 --- a/drivers/block/ublk_drv.c +++ b/drivers/block/ublk_drv.c @@ -1495,12 +1495,10 @@ static unsigned int ublk_unmap_io(bool need_map, if (ublk_need_unmap_req(req)) { struct iov_iter iter; const int dir = ITER_SOURCE; - WARN_ON_ONCE(io->res > rq_bytes); - if (import_ubuf(dir, u64_to_user_ptr(io->buf.addr), io->res, &iter) < 0) return 0; return ublk_copy_user_pages(req, 0, &iter, dir); -- 2.54.0