From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31DD432E141 for ; Wed, 29 Jul 2026 15:22:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785338526; cv=none; b=gK/5X8istdPrf6jAemggOldkG3FWmhDgSXlYFCyNht/yCCnWEWl8cbHfdoiBs2+IT+azMAw+bQ/VIX85wj1wAOkC8c1E1bfPar+KRiGa9ZWc4D5UXSugKNznyIo4J5o8Jcd+v60pEcqMSbWAsLu9ddnaKmQugOTBlht9uIqrxuE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785338526; c=relaxed/simple; bh=vQ5oZz3xnwHEXnfCIvi5v4b/24JIfnDosCVUrAqLmTA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=L7/RSLRAmjUJVpcLjDkAff7KpCfYMhSLukbhHID798Ku/LYRsNPGKrD2PJ4QGg4jUAVHm1WKySV1a+2b6RK9KkXK+ouNNpeiLD9whYxHRHoJy7fyc3t/5ZeeBfTl53DH8aVAEysCZj8ftZkJA7/ZBzQSazSLLN9dDZgWxwKgLnA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=yg11ygwC; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="yg11ygwC" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 4A8D14E40FD7; Wed, 29 Jul 2026 15:22:01 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 078DB6039A; Wed, 29 Jul 2026 15:22:01 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 1212C11C14FF4; Wed, 29 Jul 2026 17:21:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1785338520; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=pm2Nrp7Imh72FuDU5pPppeehnA/Ha/4A3yBMluiIZH4=; b=yg11ygwCPHXsInhwI2RvhudDxTtt6qLEl1eKqq9BFv4JKYR0cyKCFjigq48ct3Cm251irR AIinH5hNkagJFmmCnnj5ykP11y4MQFLygGr8WXWO49BZlPwhBfmxP0MNRxnT4h54t76tFd 8Xn7hU2aNZzpEqFI3QDkrCeZzaXP4w6qIfw+2cNcm2T6Id04b0473lpx+EzBApfUV9arl8 EmIQtWlbDs61ttvU6o19hvFVah0bxq71brHeWtFqJK7neRDSQsatDsQ2II+tD1giep4F6Y rODJ5gsyDSsLadzjDEWpeTRSr1cB+MGY/SbKEkeYFb1JaupdTnvIR5exOhx0EA== Date: Wed, 29 Jul 2026 17:21:56 +0200 From: Herve Codina To: "Christophe Leroy (CS GROUP)" Cc: linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , Paul Louvel Subject: Re: [PATCH] soc: fsl: qe: properly scan GPIO nodes at startup Message-ID: <20260729172156.4371a8bc@bootlin.com> In-Reply-To: <04dc047f8958a78a920f0a88ca3bd8bf70c56187.1785333986.git.chleroy@kernel.org> References: <04dc047f8958a78a920f0a88ca3bd8bf70c56187.1785333986.git.chleroy@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Hi Christophe, On Wed, 29 Jul 2026 16:10:36 +0200 "Christophe Leroy (CS GROUP)" wrote: > Before commit 156460811def ("soc: fsl: qe: Change GPIO driver to a > proper platform driver") qe_add_gpiochips() was walking the device > tree to find all nodes with compatible "fsl,mpc8323-qe-pario-bank". > > After that commit the discovery is handled by the platform core, > therefore it is necessary to call of_platform_default_populate() on > the par_io node. > > Fixes: 156460811def ("soc: fsl: qe: Change GPIO driver to a proper platform driver") > Signed-off-by: Christophe Leroy (CS GROUP) > --- > drivers/soc/fsl/qe/qe_io.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/soc/fsl/qe/qe_io.c b/drivers/soc/fsl/qe/qe_io.c > index a5e2d0e5ab51..02ca556c8db0 100644 > --- a/drivers/soc/fsl/qe/qe_io.c > +++ b/drivers/soc/fsl/qe/qe_io.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -184,3 +185,17 @@ int par_io_of_config(struct device_node *np) > return 0; > } > EXPORT_SYMBOL(par_io_of_config); > + > +static int __init par_io_populate(void) > +{ > + struct device_node *np = of_find_node_by_name(NULL, "par_io"); > + > + if (!np) > + return 0; > + > + of_platform_default_populate(np, NULL, NULL); > + of_node_put(np); > + > + return 0; > +} > +arch_initcall(par_io_populate); The par_io node is a sub-node of the soc@xxx node. The soc@xxx node is simple-bus compatible. This child node should be populated. Why do we need this additional of_platform_default_populate? Also par_io node has a compatible. Maybe the related driver should call of_platform_populate() to populate children of par_io if needed. If this driver is missing, maybe it should be created. Do I miss something? Best regards, Hervé