From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AABA6445ADA for ; Thu, 30 Jul 2026 15:21:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785424868; cv=none; b=m8CJzONhlF1PFx2apegBFCtAUKUyEcwz5FMD49ma5+d+NwK70U0Sz9TwKFMuT2tA+wKlbadgDi5reGRYBKD2XPzNaLxmWAVFxnNeWDtnx7OC1IckPY/63+sPxtHAydfKdWT9BPYue+4VF5DvJybMZ3pPXI+n6xP1XBKF0eMFDcQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785424868; c=relaxed/simple; bh=mn+e/RylLLe8OTePgCv2X/kFcuAkbIe3sFltrQBvOOg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uGsBFltwlRO5LEe2bizTNjereRlnqMP7vTHqnnx3igRrNH4L7FGHxw54KyPTy+vicFvAqIz6iy8CkG/84MEsj4aosTm3J/2zk6K3r2QdFdfcc4vEcPIpq7SKdnC6gQNNYfhuYqFwF69roXaBnNWe76/RX0QSfWhcPhD6CVaH6PA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mg3TDYvu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=C/a419UT; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mg3TDYvu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="C/a419UT" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66UEdWDM1110834 for ; Thu, 30 Jul 2026 15:21:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BSlDrwbGIU+LailKGlDSa67oRh8dtUgn/OIYCvnUjAg=; b=mg3TDYvuSS5Lj+ix i+eUlJAALhiARHAtulLyc3e8fUp6kTfiz3E3bl0HW0FUB1PdP90lBR3nos60kDkC aXH7jdprgtILM0ObHd7EPys+Dr5lvgTTfS4lBbSngX/HeRAwAW2Bg1M4ufNR/m/u Ewx4F/ksos06tmjuF7DRrPw0i5jiOGKST8elyTRLrmM8f7bXELli3Fad47WbEu7O e6v/vfac6XqwE3oYf+Onryy7LR2JEUr4dYw0EaZQtF0vgpsHPzx/rHVJVLok7EqG r3ppp7cGnsLOnQO9xtc38s0suVkfCouPgP1riyDiS2gbvYjJ4HqcRbtG7vky2YxR tpqtww== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fr8jmr7r2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Jul 2026 15:21:05 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51a8db414c7so33509831cf.0 for ; Thu, 30 Jul 2026 08:21:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785424865; x=1786029665; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BSlDrwbGIU+LailKGlDSa67oRh8dtUgn/OIYCvnUjAg=; b=C/a419UT0LkyKClDIyZp80RKg4ANpKIzvi9xN2SLV37BnGBysJT+aHpMYdb938va/q 9Xo27vwtlyWbsaiCXuM/yxKCTJA2YJcwHtKMR5IbXVpDHxQl5ZGnsQ3Omu1oWYn49bEK 86vTVbVTmUD0GeAtnNF0mfQJ6OP1tf0ilSsC5zE9iI/yIk2bz+r1uKjsgROAeRPopGEl iUwasNmbLHxC56ZuORMlp2W/H18PMGyzTJ7dPTT09NzUoL5ye6V7hdiqG2/j7JgJvPOP 0U+38WpL6YnT8FSJuslme/yTZRP/sipU95crnJ1kpTQrXOxBdDb08iojuKVAHII8ywZ+ Dt3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785424865; x=1786029665; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BSlDrwbGIU+LailKGlDSa67oRh8dtUgn/OIYCvnUjAg=; b=N3fw7wytg4q9xOVFwvC3BG/W3ryuX4VWOCqW61LGx4pil+OTocDl8ON3g+qBiMVaP4 qjeTqtIbt09/NAN8olkMYybHuBXrFfpRPm0srwF8nKr48ar+6IBPOdnJ2BpgE5sGSxxt byW67Ov9fytQcIVo8dUDJhfrqJS3hL3+Vp7OMAXBRpcgZ8940xSJkz1fsglF/0eKcMzm V2YVXDPUHDnnFHKHAzus7ATZ03GlgjGw9+/VNHMejs4f09Q+9EdmQO5Q2FtCgn/e2CIN IBnS+0/mtQSMVR+ZRXDenxys0Znn9QdzaGxBDpy34LWnxNAhI0equPvc8zLeaJXCnwo3 HcMg== X-Forwarded-Encrypted: i=1; AHgh+RrzMB7sTXGN5714WjwwGkHN2akDTfd3gqlwSRcl51q+OlYAGBAZgp6l5ED/VItZNCFtdCJyesnA1UzczO8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxc5kCEUHIsX5RfIHV+Xwb+Qgj1FnuemeZLYVRZfVMe92/sids1 KcMI5RkcJaKhFAr2EHumHwnN3TqMZVErcSeN/FivoM1RtFHq/Eo1WsplsfGvFJMKKzszdYhUke0 bGl0r3wUtGNGA7SxtMDgEO62seR7FEQ1ln/h9fK05U+y4NS99gewtdJCDXzxoiehllPg= X-Gm-Gg: AR+sD12IXWQaxAGDT2HjG7pgOt4PvqPCr1ISkQo3Tz9KuOjVjJJsa/x6vDGrI4bC5BL zBTYoEm7X6z5jXnzxDi2B3Ff96SzB4QMHLYgFLjA4VM28LZj8VDWMZsYq6Z8Chcx1jC6FJnzhV0 DSGF6fYICHIBfoB8VfXV/DFl9eYaM3pCXVDJcT1IncBov6ZXO3HDLTjPH8Zsx6y/+437bTdTGFa fkgQXKhyF7qSuOMx+Dyd6n3fnEsMb6VWMBKxihMHq9IDs5XX/2xcRxoEOlxe6/hnMF8hoPBDERx GQYwbd6NiW8LrYemqszEcS7ERgyLC7iVDrGnwJflvvzmrG0lGZUPYacrqq9iBj/6/HtKB2uu+yb 2Vb1FNBHu4lX/T5WUYxFqF44bvdSJcEqtm8yzQ7gapaNp928iDgu7b/0IfyNjlz4D0AXTykltfI N/xJ1516wyemenVA== X-Received: by 2002:a05:622a:1346:b0:517:a9ef:ce30 with SMTP id d75a77b69052e-52b3838774dmr33091701cf.17.1785424864756; Thu, 30 Jul 2026 08:21:04 -0700 (PDT) X-Received: by 2002:a05:622a:1346:b0:517:a9ef:ce30 with SMTP id d75a77b69052e-52b3838774dmr33091261cf.17.1785424864270; Thu, 30 Jul 2026 08:21:04 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b2db95aae1sm420927e87.37.2026.07.30.08.21.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 08:21:02 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 30 Jul 2026 18:20:49 +0300 Subject: [PATCH v8 06/18] media: iris: Introduce interrupt_init as a vpu_op Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260730-iris-ar50lt-v8-6-6597c08cea6f@oss.qualcomm.com> References: <20260730-iris-ar50lt-v8-0-6597c08cea6f@oss.qualcomm.com> In-Reply-To: <20260730-iris-ar50lt-v8-0-6597c08cea6f@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vishnu Reddy Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Dikshita Agarwal X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4931; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=jlbWJ6BnLAb8hDHnLKbkTUpBs5ZGORWEUsmmVGvPwio=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqa2vR2XgUwV/wEpunmg5XwtLqM9gVHH6ocCtT7 0piGmrcuEeJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCamtr0QAKCRCLPIo+Aiko 1eS+B/sFKiuNGg2+o9L6DgVJTGGit2azpaQeg8pKWuhlg/nCBAdoooMsNgHrJdBS1TmPKdgTCvk JG3Hd5V9VRZH0LCfe9BOsq6H3EwxCAgzs1lzyQv8FqLDZhUR84hNOgGhuYcdPeuRbN6DRtXeXvM 2VxsS4C0eMvCwRIiJS4HmeKXyQ9ZhEGDzVYvoc5z3WajaJMjb5mDe7MfjU4UBJ6vNiNs88FLa2P FQF6O4JqALRKCKbsENoNFIRJj1mynVxwcYtJJjqeZAolfn5hTqvFoNU/nVMVaPwKH/SeU7HEMYt rw3LO/U4y/TAxgFx8j/R0VPrjIZl3jdaMPB9FbY6rvkeM7a9 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=V4tNF+ni c=1 sm=1 tr=0 ts=6a6b6be1 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=2EYiHOum3YQmkHKk0wkA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: aW0MivkrujuPuGU-qSpvcjkT9JsKU2JH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMwMDExNiBTYWx0ZWRfX/YLoHBY7DyUo an6NyEqAkhX9Gx4gk5Z0gmKk296yh4NbmFUyZP4kUS/28tvZOQvGhBBZiM5rQY8ysgR1H4oKGXM 1SpNi/EhHnEnOr651YcHFaL4Ha5qspV+ehKHZ0q6fHJdX1kMMmV62q1sboVtO+L46ujIvnFvB/R IafoNLcUmNy+vWniRuevsnwPq/5exeKnl7Hy9wtOhBpByTYMP8yPVal2wUh4U2cm/76mrFktJIl y9BS4k4KwY8AS7qbskrjT9CvNSBdbuRybXqpc6MQZufGGrL4Mh9wjwB/qPI8+xcIz7VtdYeSIyc YSulryrRB/Hq++FOADNGtTRbo120JoWVnY7oRkfobXvZ0X25vkxZdsuEG1aP/Niwq6AVZzwGifF 7nrdgSyirfE9P7UZpFus/R6/FiUsV8qXURi8S5xxhvw6xHIzJFIfuLTbXOdgrL95js6V6pQGhX2 paE96dtVB+JuOxlIDyw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMwMDExNiBTYWx0ZWRfXx9//VXVINYCt HIvKxl5BOAAVJQYK9vrSynDjyUBHCjenMehtfE9NRzuug2YGZQZTjQcnyjElK1ufSqHky1SMMUn GhHOLeZJJ9p7m8tnKI1nY5O9WBcZzoI= X-Proofpoint-ORIG-GUID: aW0MivkrujuPuGU-qSpvcjkT9JsKU2JH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-30_04,2026-07-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 impostorscore=0 suspectscore=0 phishscore=0 adultscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607300116 From: Dikshita Agarwal The interrupt_init sequence is currently shared across all supported devices. Starting with Qualcomm QCM2290 (AR50LT), the register programming would differ. Move interrupt_init into a vpu_op to allow per-device customization. This change prepares the driver for upcoming hardware variants. No functional change so far for existing devices. Reviewed-by: Dmitry Baryshkov Signed-off-by: Dikshita Agarwal Reviewed-by: Vikash Garodia Reviewed-by: Vishnu Reddy Signed-off-by: Dmitry Baryshkov --- drivers/media/platform/qcom/iris/iris_vpu2.c | 1 + drivers/media/platform/qcom/iris/iris_vpu3x.c | 3 +++ drivers/media/platform/qcom/iris/iris_vpu4x.c | 1 + drivers/media/platform/qcom/iris/iris_vpu_common.c | 4 ++-- drivers/media/platform/qcom/iris/iris_vpu_common.h | 2 ++ 5 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_vpu2.c b/drivers/media/platform/qcom/iris/iris_vpu2.c index 2dc121a3f5e8..dd2eeae0d9eb 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu2.c +++ b/drivers/media/platform/qcom/iris/iris_vpu2.c @@ -46,4 +46,5 @@ const struct vpu_ops iris_vpu2_ops = { .calc_freq = iris_vpu2_calc_freq, .set_hwmode = iris_vpu_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; diff --git a/drivers/media/platform/qcom/iris/iris_vpu3x.c b/drivers/media/platform/qcom/iris/iris_vpu3x.c index dc02ced1b931..c3b760730c98 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu3x.c +++ b/drivers/media/platform/qcom/iris/iris_vpu3x.c @@ -262,6 +262,7 @@ const struct vpu_ops iris_vpu3_ops = { .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; const struct vpu_ops iris_vpu33_ops = { @@ -272,6 +273,7 @@ const struct vpu_ops iris_vpu33_ops = { .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; const struct vpu_ops iris_vpu35_ops = { @@ -283,4 +285,5 @@ const struct vpu_ops iris_vpu35_ops = { .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; diff --git a/drivers/media/platform/qcom/iris/iris_vpu4x.c b/drivers/media/platform/qcom/iris/iris_vpu4x.c index f608a297d4a3..90ccdc0d2a07 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu4x.c +++ b/drivers/media/platform/qcom/iris/iris_vpu4x.c @@ -369,4 +369,5 @@ const struct vpu_ops iris_vpu4x_ops = { .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu4x_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.c b/drivers/media/platform/qcom/iris/iris_vpu_common.c index a49113b0da23..375bcd923476 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu_common.c +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.c @@ -31,7 +31,7 @@ #define UC_REGION_ADDR (CPU_CS_BASE_OFFS + 0x64) #define UC_REGION_SIZE (CPU_CS_BASE_OFFS + 0x68) -static void iris_vpu_interrupt_init(struct iris_core *core) +void iris_vpu_interrupt_init(struct iris_core *core) { u32 mask_val; @@ -485,7 +485,7 @@ int iris_vpu_power_on(struct iris_core *core) core->iris_platform_data->vpu_ops->set_preset_registers(core); - iris_vpu_interrupt_init(core); + core->iris_platform_data->vpu_ops->interrupt_init(core); core->intr_status = 0; enable_irq(core->irq); diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.h b/drivers/media/platform/qcom/iris/iris_vpu_common.h index 21ed4c9bd5e3..9151545065cd 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu_common.h +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.h @@ -23,6 +23,7 @@ struct vpu_ops { u64 (*calc_freq)(struct iris_inst *inst, size_t data_size); int (*set_hwmode)(struct iris_core *core); void (*set_preset_registers)(struct iris_core *core); + void (*interrupt_init)(struct iris_core *core); }; int iris_vpu_boot_firmware(struct iris_core *core); @@ -44,5 +45,6 @@ void iris_vpu35_vpu4x_program_bootup_registers(struct iris_core *core); u64 iris_vpu3x_vpu4x_calculate_frequency(struct iris_inst *inst, size_t data_size); void iris_vpu_set_preset_registers(struct iris_core *core); +void iris_vpu_interrupt_init(struct iris_core *core); #endif -- 2.47.3