From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBE3C414A1C; Thu, 30 Jul 2026 09:50:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785405030; cv=none; b=fT4FLgbZrR2wZ3fwwXAnauqzck+1gq2oqBirS2fiCX+XaueV1x55ZJ28kQG6+Zj7jkrCCEXMyHDwml+VhCneBdf33m4rDe1QYAQBJ+7XVvMgTW5xj2ETFLJ9qkv/ZxeUt3czDoOYTQINPvRban+d0OGrawl40xYnGtfQPuaczoA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785405030; c=relaxed/simple; bh=bcBWQRKbghwwH208AKzQnLOL387dpD463FVLae+ZLGY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cUpHruFMmDMmj2GWycJx0fdx54CRd2u7C8HnH9VN3mRZxvmKQDEf/9jbSEofNTytwW6bWayW8rcEpOeaUFomQwf+qCzcDV8ygyWX5NOYxyTgBQfeIKUTijtklTcpbdt9L7yrzYnETQlbgYep/IWBniKBf4q9ziB1rCDE8524qUM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=e9Oqijnz; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="e9Oqijnz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1785405027; bh=bcBWQRKbghwwH208AKzQnLOL387dpD463FVLae+ZLGY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=e9Oqijnzham3PkNtziI7sIslA52VaIUOxmOR4UzwDx0TerRfAPzzPiGX+BjSwNamE ff7T7l/4GrOSS6VU/kv9XxJYhLCU88bA82zJ1MuZd6skTpcyGVcAL2qCyd3Unj96S+ 5EywPbqE62y77mHBeM5WXc3PKMKlybx0oXx/dCqxe/aopjHApsv07pdB6g/zHcaq+Y XFG1HuspswDd6qnGEqGYLZ/UcNoq/TIkA9gOk7Xx2x+rHXfHqHcxRipEMVY7747l3i vxa6kPqZEmwnBuYMjRC87rdmY/dp0co6YQp75NhR2tSkCnGURzyZKi6fc05k4x7OqS B5J5YXcE7/sJA== Received: from yukiji.home (unknown [100.64.0.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: laeyraud) by bali.collaboradmins.com (Postfix) with ESMTPSA id 001A717E0974; Thu, 30 Jul 2026 11:50:25 +0200 (CEST) From: Louis-Alexis Eyraud Date: Thu, 30 Jul 2026 11:49:17 +0200 Subject: [PATCH v10 21/26] scsi: ufs: mediatek: Remove ret local from link_startup_notify Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260730-mt8196-ufs-v10-21-bc5ecef202dc@collabora.com> References: <20260730-mt8196-ufs-v10-0-bc5ecef202dc@collabora.com> In-Reply-To: <20260730-mt8196-ufs-v10-0-bc5ecef202dc@collabora.com> To: Chunfeng Yun , Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Peter Wang , Chaotian Jing , Alim Akhtar , Avri Altman , Bart Van Assche , Stanley Jhu , "James E.J. Bottomley" , "Martin K. Petersen" , Philipp Zabel , Liam Girdwood , Mark Brown Cc: kernel@collabora.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Nicolas Frattaroli , Louis-Alexis Eyraud X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785404993; l=1411; i=louisalexis.eyraud@collabora.com; s=20250113; h=from:subject:message-id; bh=+g3Eyl7I/ogd5c736u7Vuq68zxVjwbPwCEBz46Z2nCo=; b=FJfOZtVKcyr77r6IjgVbG7ZA/TX7yfRQJnTynqs3b8w8EwbWF+qHZglXpNay2jKKGpMxDaXlR FJ8HnqT0GzKAmeOI68B53ZOFPNY2l38EhM7mx+1Hwjq4kHj0HTcrGk5 X-Developer-Key: i=louisalexis.eyraud@collabora.com; a=ed25519; pk=CHFBDB2Kqh4EHc6JIqFn69GhxJJAzc0Zr4e8QxtumuM= From: Nicolas Frattaroli Remove the "ret" local variable from ufs_mtk_link_startup_notify, as it's pointless; in all cases it is assigned, it is returned right after without being read first. Rework the code to just return directly, and get rid of the default branch while at it. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Peter Wang Signed-off-by: Nicolas Frattaroli Signed-off-by: Louis-Alexis Eyraud --- drivers/ufs/host/ufs-mediatek.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c index 115056927223..90c8606d85a9 100644 --- a/drivers/ufs/host/ufs-mediatek.c +++ b/drivers/ufs/host/ufs-mediatek.c @@ -1502,21 +1502,15 @@ static void ufs_mtk_post_link(struct ufs_hba *hba) static int ufs_mtk_link_startup_notify(struct ufs_hba *hba, enum ufs_notify_change_status stage) { - int ret = 0; - switch (stage) { case PRE_CHANGE: - ret = ufs_mtk_pre_link(hba); - break; + return ufs_mtk_pre_link(hba); case POST_CHANGE: ufs_mtk_post_link(hba); - break; - default: - ret = -EINVAL; - break; + return 0; } - return ret; + return -EINVAL; } static int ufs_mtk_device_reset(struct ufs_hba *hba) -- 2.55.0