From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D61E384238 for ; Thu, 30 Jul 2026 03:10:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785381037; cv=none; b=oALa05BFCYeAaJnKPCYzeIa45/Xqjh9ej0BXiZZI4eYyO4vWEtJoZL6hw0fJ240xANVO3HmEosFlRI4VCzPYgnRgZWJIlkkCG0fQ7DuyoFi5ioySh5QuQqVXLVL9jrjxlU0mvn7KmkZ0D7bAklVRrmq8nV2b1229r56sEjnXXEA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785381037; c=relaxed/simple; bh=G26oBuLWBXTguVs1cjBDadH3KIV/Cq3VPwqIvFRppTQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Nnfnb6UDuISE58ScilqhnMen9HiPieydtjiUlCxA7nbRQbSnPD8xAJF+31KYNtliNR/JtYTBJ/htp6OPElmo+F510twrBK5fgANj+X0Lcg3XZNUdfH+mroeHvbGE/oKC/MLI2Vtsy6/EEVIdnjXt+zuy4K8vzAm/WWA8VHvG0qc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=inlykNPb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IjgP/6qD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="inlykNPb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IjgP/6qD" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66U2CLrH3644125 for ; Thu, 30 Jul 2026 03:10:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=Hru35mpumEb kOLf7h02q3Nl02jlJ/9pefcv0jtM38wk=; b=inlykNPbeu+ZWHbKW044qJZOKAr Vr0079Tvp4dzhVqybX9B0C18YX7Ek6O8U07W6nW29ia9IbpKNNtGUWCMffUHVbPE 8fmKEwkcMaE18s6hamKc51Z5TBzyqCtqIOPrvF2+7RORnAzqs1ggDBF0l4/i/z1j NFZhs6pInncsnfIDld5CqOtapAdtbkDA+BN5Y20U8YmdTXryD23eX62oNqFE/Rvu kupg5SEA1wAtACLn5bmfoh9M/RoDm37QT9DzGiWZaZJjnLJU6sy+cG1K8FgGgQ2d RCUSoSco/4vbu8qpFYY8ddBMM+auhWNe5xGBiKkzyJj+hcwAHaKdx5WgDHA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fqwmfr6cw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Jul 2026 03:10:35 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cf6acd760cso20025065ad.3 for ; Wed, 29 Jul 2026 20:10:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785381034; x=1785985834; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Hru35mpumEbkOLf7h02q3Nl02jlJ/9pefcv0jtM38wk=; b=IjgP/6qDJJC0+ly/IdE2iSG1J1avc1sC7NtM97/NHdlfwTBd1d6FQFUd8RI9zyPQh9 NkXlDYNVs6gkkEmtR8FvcPCKI+JYJbzFfEDVLLfnhnEIeENgK/Rc5wDeqVDY2pyVmDsr t7dPiZfkVrht/h7+fL5dRYroN+ugTFR2wGSkOtIcKMQb37SvQDL3Qoj4+gfMY+yLsH7M yW8mB0mCMp3AtTpDb3NY8VmKE/1ZCqWwZAj+mAn50fARY9zqRAjYpt9OGwHevUBse+mU WpW0ys7eMANQ5zluzF6ydS7O7ZYji7OMxnDmBRwZV3uD7n/VqQkRmMhIN9jgKOeaEZzm Fsug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785381034; x=1785985834; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Hru35mpumEbkOLf7h02q3Nl02jlJ/9pefcv0jtM38wk=; b=Kp0Wk4Sv77w/DhGYbbipnIDflg/r/X+SkKdFIhZvxJsxgOaPX9qkobaKkau/+bfiqI C5XiCgU6QYfjkPNhut827gH5wqS9O/Elwj7Bz6SFWWFenpGf6YsUxN0oTQw9bHxF5l9L aybznnSyXdVU8QDBjs0UG6i6WDeAdwlBMkktIGawl0s6V0EGPPYG2/Wb9V61FzwnD8mt B5xmFnAUC0JAR79Z3SvP6SrKuGomccqHADcMF/0WbvsVHBa/sahUr2PnIUewtdEpGBFh pZoQ4/XKigsH5Y4AK1myrbN6jGJI4yfHpnTmS95JTFEpOIHAQqNY3Ya5hKi5kdCvYQ/v rafA== X-Forwarded-Encrypted: i=1; AHgh+RoSrra8Im6n9TEIOVR9XaWc1A8xOpaWAGWbF2z7kTQHVOvNV/6zU6zGiofcAFB+dIXv3UpE2W0bj+mHtlU=@vger.kernel.org X-Gm-Message-State: AOJu0YwK8niM8I+DL6iJ8959QAZXdlh+rx+8HmFCJK+pw1DxDO48HhR5 TjIsf75DtHH6ptNYDDEfpvnUluTc9uSEVcsbKsP+z68Rkw1N3YEmKwC6VGqsVuwgdQDKdCqoI5G 0yjpukyRmbXWHptvHB6IjbWiipaNxft/eODClCDcwUKrSYRIqylpaQ5owfDIFTJ2xlQI= X-Gm-Gg: AR+sD12OLL7bgY0FD1gn6lBqJYO0NSnCkklFO+Xnw6wgOkt5B22Blg9T4KeYy+7yeQ9 d/6LsBq1QHaL34ODZtdXbrnTZImMIMBJi7j9jmmHgODmZRHQ6R+10nOfM0ramVbFwXYEfwvTIzf /Ljd1XFGrjMSPTngJRo+GOMokQ4Pq1ppgL0/OZvBfWS7lkuGuiiCjthJxvDaLTZuoP6mGlEwAve h0vJ6wm+YEYanLmc6+mL+OMG1gvp235z4NQzplch25xAZyZMic4mArqcrrZkOudRHw5vRXG4vOU 0H9xNM9WezJIms6Cbyx40uogLtQkTJoXBY5TRPr8bb8MNkF+cFstGBX3zSciR8eJAzBEerCR+Iv ig71mCtKOCk7Rnf2kXAYLwBF+PAtmkc53yBpz3t+uMZTQ/WVe1RSOqu/a9bs= X-Received: by 2002:a17:903:f8d:b0:2ca:c68:c554 with SMTP id d9443c01a7336-2d035e66a85mr9174815ad.38.1785381034451; Wed, 29 Jul 2026 20:10:34 -0700 (PDT) X-Received: by 2002:a17:903:f8d:b0:2ca:c68:c554 with SMTP id d9443c01a7336-2d035e66a85mr9174545ad.38.1785381034046; Wed, 29 Jul 2026 20:10:34 -0700 (PDT) Received: from Z2-SFF-G9-MQ.ap.qualcomm.com (i-global052.qualcomm.com. [199.106.103.52]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d022c2e5b2sm18928035ad.74.2026.07.29.20.10.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 20:10:33 -0700 (PDT) From: Miaoqing Pan To: jjohnson@kernel.org Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Miaoqing Pan Subject: [RESEND PATCH ath-current 3/3] wifi: ath11k: unregister PM notifier on QMI init failure path Date: Thu, 30 Jul 2026 11:09:48 +0800 Message-Id: <20260730030948.147892-4-miaoqing.pan@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260730030948.147892-1-miaoqing.pan@oss.qualcomm.com> References: <20260730030948.147892-1-miaoqing.pan@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: aGo_YPPsCpj1cBwkN63UdUqlbM7jg_0n X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMwMDAxOCBTYWx0ZWRfXwWHachJt7le8 W/+FVLVHnzmM/yuRR+MCBE0cq2xN4KlZvtA7MhaQECsKycisbAvvOZKcULb8VOH7EW7DGjOzLCW 2yJxrrvL11HbqIUc9aJgjIl4y79+tfEkhvjJ0B0XOYvRyY7vmmhJn+UV4a7Ay0FARDaXw9cGn0l bHG5SxRhB1Jlb58pzS+pkN0YUWb7/C/mbMMPU6CxjuNCKtg5gTAPO5WP9QpUZWFyfrm75oNjb+P Z3pju02eO6PUPD5mVwkZvIS9Kc7eGKt1pne1gskfdV44yArCM5YmctHzi+PcmxX9cindm+6J/et r3ZyZiadQEH+QLQFf1apIdwqrHW+8xPkOdGxoqk6k0CmEcLQ6zEaCx4+yaEmYmH/dewySkodBaD 5nDeiVWGtLR2nEVMIxixjpLuEeZa8+ZTsWB0sKcfQ1ridZq3qSK9qNgaJH6y7qj9ijfM40/5p3H Fi1PH+u/iL3Tlmv7saA== X-Proofpoint-GUID: aGo_YPPsCpj1cBwkN63UdUqlbM7jg_0n X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMwMDAxOCBTYWx0ZWRfX70eqa5TwXI4j crhEoBecfLsNWX2Px2Andjaz10s44dtKpMSRk/yM/ncxNZsAhPXiJsysev3HaRRlim7wSQ1Pb/p /2KHCvyldq6xtanIB6oSPKjzPvJR8Ow= X-Authority-Analysis: v=2.4 cv=F5BnsKhN c=1 sm=1 tr=0 ts=6a6ac0ab cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=b9+bayejhc3NMeqCNyeLQQ==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=FJAr2BPrIL5JYYbaf3kA:9 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-29_09,2026-07-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 clxscore=1015 suspectscore=0 spamscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607300018 ath11k_core_init() registers a PM notifier before the QMI server becomes available. If the QMI server never arrives, the device remove() path can take the early-exit path introduced for QMI initialization failures, skipping ath11k_core_deinit(). As a result, the PM notifier remains registered after the ath11k base object has been freed. A subsequent suspend or resume event may invoke the stale notifier and trigger a use-after-free. Fix this by explicitly unregistering the PM notifier in the QMI failure cleanup path before releasing ath11k resources. Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.2.0.c2-00204-QCAMSLSWPLZ-1 Fixes: 32d93b51bc7e ("wifi: ath11k: choose default PM policy for hibernation") Signed-off-by: Miaoqing Pan --- drivers/net/wireless/ath/ath11k/ahb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c index 7f5f5c8d7c56..bdb8c99f10fa 100644 --- a/drivers/net/wireless/ath/ath11k/ahb.c +++ b/drivers/net/wireless/ath/ath11k/ahb.c @@ -1272,6 +1272,7 @@ static void ath11k_ahb_remove(struct platform_device *pdev) ath11k_ahb_power_down(ab, false); ath11k_debugfs_soc_destroy(ab); ath11k_qmi_deinit_service(ab); + ath11k_core_pm_notifier_unregister(ab); goto qmi_fail; } -- 2.34.1