From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m15574.qiye.163.com (mail-m15574.qiye.163.com [101.71.155.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B58783B8412; Thu, 30 Jul 2026 06:57:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=101.71.155.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785394660; cv=none; b=dkgauk6/E3ijBQGGou1hbeqdFFgRI5MWz3xi/pdKbGivnRcXj5O9NnvpKYX1AcIHa8bXwRq9lv30MlzfQ7BBemcWiuG5PpZ4jvbNwE5oSO2j2uBIsw+EewSutGnL3eso3TvIJ5OwYctyoq60xKdfBOHW7mr52IWJcxsbNFJ/fHI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785394660; c=relaxed/simple; bh=iQQraIX2R/eSNcCd+92PzjuBC1PDwefamqHSldfYo3k=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kS5THaV3EHTKd7dmGMnm/F83LcWs33J6YCPVm5w6QbrQDNX6GoqutST04LP9jNjfqUqAkwXg91/Oy1yAbup9jMudtUboPOt4Kt/QTHwzMartRgYaZGbl4cJS52a0ZiYFQhW7TMWEorewyVEBGNnizLOKeWkWVDUQqz3aPeqL9+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=Mca5uDRS; arc=none smtp.client-ip=101.71.155.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="Mca5uDRS" Received: from zyb-HP-ProDesk-680-G2-MT.. (unknown [61.154.14.86]) by smtp.qiye.163.com (Hmail) with ESMTP id 481c5dbda; Thu, 30 Jul 2026 11:28:01 +0800 (GMT+08:00) From: Damon Ding To: Andrzej Hajda , Neil Armstrong , Robert Foss , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Heiko Stuebner , Andy Yan Cc: Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Dmitry Baryshkov , Marek Szyprowski , Sebastian Reichel , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Damon Ding Subject: [PATCH v1 5/7] drm/bridge: analogix_dp: Simplify analogix_dp_config_interrupt() Date: Thu, 30 Jul 2026 11:27:42 +0800 Message-Id: <20260730032744.381566-6-damon.ding@rock-chips.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260730032744.381566-1-damon.ding@rock-chips.com> References: <20260730032744.381566-1-damon.ding@rock-chips.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Tid: 0a9fb110950f03a8kunm040f79123746f8 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVlDSUtJVkMdGh9KGkwaQkofTVYVFA kWGhdVEwETFhoSFyQUDg9ZV1kYEgtZQVlNSlVKTk9VSk9VQ01ZV1kWGg8SFR0UWUFZT0tIVUpLSU 9PT0hVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=Mca5uDRSaes9/7HjpZKjiKF5k4WJu0Wll7jSbl0AvqQMijECQl9mZH1eQg3VvYv/58dxuLyRRJNrbsIZUYdgoSCPpmCRjXQnZVkGEWxTVs5igELr13dvZ+EbGdhZt6BbsviUCDEtaIYjbFrEvUV9U9l0HON0PasDAZwdOxSVI3Q=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=2pOneZc7dpt16hg70UmlDabGGhoDjNds+kJxO+jHrek=; h=date:mime-version:subject:message-id:from; Remove local COMMON_INT_MASK and INT_STA_MASK macros. These constants are only used once inside this function and bring no reuse benefit. Replace open-coded register writes for COMMON_INT_MASK_1~3 with direct writel(0) calls. Leverage analogix_dp_unmute_hpd_interrupt() using the full HPD_IRQ mask to initialize HPD interrupt state, removing duplicated register handling. Signed-off-by: Damon Ding --- .../gpu/drm/bridge/analogix/analogix_dp_reg.c | 25 +++---------------- 1 file changed, 4 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c index 816be79a8da6..42463e18f392 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c @@ -18,12 +18,6 @@ #include "analogix_dp_core.h" #include "analogix_dp_reg.h" -#define COMMON_INT_MASK_1 0 -#define COMMON_INT_MASK_2 0 -#define COMMON_INT_MASK_3 0 -#define COMMON_INT_MASK_4 (HOTPLUG_CHG | HPD_LOST | PLUG) -#define INT_STA_MASK INT_HPD - #define HPD_IRQ (DP_IRQ_TYPE_HP_CABLE_IN | DP_IRQ_TYPE_HP_CABLE_OUT | \ DP_IRQ_TYPE_HP_CHANGE | DP_IRQ_TYPE_IRQ_HPD) #define COMMON_INT_4_HPD_IRQ (DP_IRQ_TYPE_HP_CABLE_IN | DP_IRQ_TYPE_HP_CABLE_OUT | \ @@ -178,23 +172,12 @@ void analogix_dp_swreset(struct analogix_dp_device *dp) void analogix_dp_config_interrupt(struct analogix_dp_device *dp) { - u32 reg; - /* 0: mask, 1: unmask */ - reg = COMMON_INT_MASK_1; - writel(reg, dp->reg_base + ANALOGIX_DP_COMMON_INT_MASK_1); - - reg = COMMON_INT_MASK_2; - writel(reg, dp->reg_base + ANALOGIX_DP_COMMON_INT_MASK_2); - - reg = COMMON_INT_MASK_3; - writel(reg, dp->reg_base + ANALOGIX_DP_COMMON_INT_MASK_3); - - reg = COMMON_INT_MASK_4; - writel(reg, dp->reg_base + ANALOGIX_DP_COMMON_INT_MASK_4); + writel(0, dp->reg_base + ANALOGIX_DP_COMMON_INT_MASK_1); + writel(0, dp->reg_base + ANALOGIX_DP_COMMON_INT_MASK_2); + writel(0, dp->reg_base + ANALOGIX_DP_COMMON_INT_MASK_3); - reg = INT_STA_MASK; - writel(reg, dp->reg_base + ANALOGIX_DP_INT_STA_MASK); + analogix_dp_unmute_hpd_interrupt(dp, HPD_IRQ); } void analogix_dp_mute_hpd_interrupt(struct analogix_dp_device *dp, u32 irq_type) -- 2.34.1