From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f2.google.com (mail-pj2-f2.google.com [74.125.227.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9EF13644C6 for ; Thu, 30 Jul 2026 06:01:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785391319; cv=none; b=bccLnKzxxYONRfeP4GiuEOjgYm+AMS8c+lR2Rlt059sIzWB2eMLog52/sMSm0D6tO4M06kB+C5P2gbE7lQXzZ0vWVMFytaOBosGxiynmVE6YkJ4MxTmgWFZeYpKEfnDZH9zkZA/XV+R0z5q3nICkGClcn9YPPF+jtYFHiDsoSGI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785391319; c=relaxed/simple; bh=OTfgRB8h0h7em4vm2fdnCKl20mxuPIzN8t712TCBYr8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZWzcePwkLVqI35MgcRdZAhclTS3tCpSlW3SNPE/kxR06Rhltpn2TWLMyiTN3k063Ho++bf8aDykMUCO5w59stzA9kI/sE8fj1WDGVfg6/q2drfwSqGdIM7blqv5DeAJQ9q1ygxB6NTn5delKwj2EGoK7yjzXwFYNFl28N0uNzx8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HxIpKWYO; arc=none smtp.client-ip=74.125.227.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HxIpKWYO" Received: by mail-pj2-f2.google.com with SMTP id 98e67ed59e1d1-37fb1883f59so468869a91.1 for ; Wed, 29 Jul 2026 23:01:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785391314; x=1785996114; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mNtOEOP0A98+7wj8AbU95BZxH6nnJ0eJ7KtLByvsqoY=; b=HxIpKWYOXGuHDJ8uvQSkOQVCC2rtIhySTMde0FkTi1/MJq+r61SaUx9NR3QoiuCn+H OxK6ZVdMMTuxlVBgkR0hT0HrM8IYwmjA2HdMkhBjCAXHerlO4KRxbcaQ/ZAhvCjctLfH Y8TZ+IjJWQqnVpxl6YuBhuuDAIFY+cbP8vQfWrldVNkBX2DqY8LGGjn5eo5bg5KFIAYM YtLQ0lLahd/+wYkAR2dR7kjaWX7g7RfMF+KGBiHSUSM6P4fHzh6P9XJ7U8J1Ux5fRNXa SDA9vvew/R07RhHRD3+z5l7QREcwYx2I7k6qVNS04eocy3ChCKX96y/qVu/MmbTWZiwP vEvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785391314; x=1785996114; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=mNtOEOP0A98+7wj8AbU95BZxH6nnJ0eJ7KtLByvsqoY=; b=lrIMXiSHiTayo1Z97aj3e1Xh+k/5Tcrg+0kWub7fEXiB4nMP1PTYGq/8jB+bLoW76d +XakkKORafihKZ3HYpbqj5TI+NudOBC0lvevjxRubgDl3blren0ClWOKBGnZ97IF/BcD yFB0ptQOOWypeAxuh7akCSsRJaLAj5MuVopgaxwGvY4EoXcAT1QtyhoItykTt508NYRv RJHfqnPhEWQLy4vHa8eaxEcGqhqtMxSZxPHuHaLKdkIqK7tS7avOQ6BNUc7kOY+69bH/ r046x7HeMBlBxJHCKXMOsU7hLhX23XXUc19cF/tEz0CAEDo/tuCKuxPAArdL62hWU2oE wSAw== X-Forwarded-Encrypted: i=1; AHgh+Rq+RJ7RLvG6fsjHd17AJAt6bSb+lmzEw0dKrkX/x7IbRutFNLlBpsoqisTZSa0pCJcyt82Zp9PDe1/Mcz8=@vger.kernel.org X-Gm-Message-State: AOJu0YzgvxS0scLXrjSB8FrRBP7USaD9J95Hhk61xh3RjFZd2NzUdaa6 dYWWYpSarjbAZYE/ncEYmh/w9YgMnNRNDky2hY4OwXYg95vXmVHljZTc X-Gm-Gg: AR+sD11g9mqcrVgOxeRoKn+1xEht24P3rBVbMoo22tHdKcuPhJ2+H7Iq5zA5r1PdylO MqCpKspesDE+FT2g9hydgu4xRqOgwNpBjoEhRhmd/jFqi4xnhnKirWuXD8dM6+6uf86fyd5wVRD rVrliD7kilp7nhTFphg34IvCUPhMOaq0O/lmcO82FO7ad9fDOcatDHVhXe8ntLdYdRqEAylU20r ZLbkspSNurRHxAfPz8w9Bvqk3oblmxxli2pOTFTYDsr+OH4zygQItbOQqCbt7E81flALeoAkIQJ sXIlRXgYB+fyv87gmqXJwdqmpYCZNOIvEUGRYUqw3+eE0vGIM/2rBKqTbAgEx79sYFNX9zm1uMs nluuaYR+/x/S5pLXck2Wy6tvfVnWv215u9unVcsrpns9nYXr2P6UeUMJB3u77clrKbWy2pJhW4j uUUs7zMUR+XcO3v/I9bfIVufVVVzTBbtFeqnj78r8CuO9x1uZxdB1wawvthl1T2K41hbpDo4fqJ B6wazeENh0N2bxcO34N8TRc94UWplRh+Q== X-Received: by 2002:a17:90b:1ccb:b0:38e:85fb:71b9 with SMTP id 98e67ed59e1d1-38f9be2b6f9mr1235553a91.4.1785391313584; Wed, 29 Jul 2026 23:01:53 -0700 (PDT) Received: from HAOQINHUANG-MC0.tencent.com ([43.132.141.21]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f9b42d6c8sm430737a91.3.2026.07.29.23.01.50 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 29 Jul 2026 23:01:53 -0700 (PDT) From: Haoqin Huang To: Minchan Kim , Sergey Senozhatsky Cc: Jens Axboe , Nick Terrell , David Sterba , Andrew Morton , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Haoqin Huang Subject: [PATCH v4 0/4] zram: fix zstd per-CPU error path and add parameter validation Date: Thu, 30 Jul 2026 14:01:29 +0800 Message-ID: <20260730060133.80233-1-haoqinhuang7@gmail.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260730025240.17724-1-haoqinhuang7@gmail.com> References: <20260730025240.17724-1-haoqinhuang7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Haoqin Huang Patch 1 removes zstd_release_params() from the per-CPU zstd_create() error path since per-CPU callbacks should not free global resources. Patch 2 rejects zero-size dictionaries and prints an error on dict load failure (currently errors are silently swallowed). Patch 3 moves parameter validation into each backend's .setup_params(): dict/level support checks for backends that don't support them, and level bounds checking for those that do (zstd uses zstd_min_clevel()/ zstd_max_clevel(), lz4hc uses LZ4HC_MIN/MAX_CLEVEL, etc.). Patch 4 resets per-priority params on algorithm change before init. Changes since v3: - Patch 3-4: dropped the generic caps + zcomp_validate_params() approach in favor of per-backend .setup_params() validation, keeping zcomp.c free of any library headers v3: https://lore.kernel.org/all/20260730025240.17724-1-haoqinhuang7@gmail.com/ Haoqin Huang (4): zram: do not release zstd params in per-CPU error path zram: reject zero-size dictionary zram: validate parameters in each backend's setup_params zram: reset per-priority params when changing algorithm before init drivers/block/zram/backend_842.c | 8 ++++++++ drivers/block/zram/backend_deflate.c | 9 +++++++++ drivers/block/zram/backend_lz4.c | 5 +++++ drivers/block/zram/backend_lz4hc.c | 5 +++++ drivers/block/zram/backend_lzo.c | 8 ++++++++ drivers/block/zram/backend_lzorle.c | 8 ++++++++ drivers/block/zram/backend_zstd.c | 6 +++++- drivers/block/zram/zram_drv.c | 8 +++++++- 8 files changed, 55 insertions(+), 2 deletions(-) -- 2.43.7