From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f10.google.com (mail-pj2-f10.google.com [74.125.227.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 105F0377ED4 for ; Thu, 30 Jul 2026 06:02:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.138 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785391324; cv=none; b=R2t9MUsPsp/RsSNvtnqCDhjHPKQOJ48uCi5E9xXEe5vf1XMa7BVcJmlshtxhuVxBNUQjnm6WS/dPiu5YBYWPHwcs5/dKvHyhdlRjsnMiiv+4lZ1GLpEJOC3amesqQ/iOlYfUCa+G9JFWo/+yFtGzW2951aqY6497isugkHiVJYY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785391324; c=relaxed/simple; bh=JHpJYTLLB2ZMJKT2oo9BGd65bnXRYxol6hW4wZLX1bY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=duni3unPWL1BJiTH6+YpUYmVtt1gbuEhSMnnd3KGqwWEv0QdtB3OwIPiwUlR0JQB8Ns1lsnbMpFLdOdRjX3V1s0Ql0NpVGutHUUvJMF+fWIT5HXcn5T5Xf2YcH/1bA+4d7kH9e5zgWPHJ3pPIlpJf7tKJmNHyQpCIXqB2/eMknk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VPLPYKih; arc=none smtp.client-ip=74.125.227.138 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VPLPYKih" Received: by mail-pj2-f10.google.com with SMTP id 98e67ed59e1d1-38dc4f9462cso575751a91.0 for ; Wed, 29 Jul 2026 23:02:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785391318; x=1785996118; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cs489M3XU7xPRIbALvrKU2CC1mfn9Hj5q9oo8bImFmY=; b=VPLPYKihKF9uZ8IbsUi63b/nA8IYLCbdKHv4QcsSZVzuPqvSMEmnLseMvq/1s3fa5+ 2e2G2v+vN9AatG9CR38f6KzgEKrrjIjc6hLshpBbYA2sliowecUDyKZaKbckjW1rbhkH NtS1bT/IuGpEQpjADDb4u37hlVx4drzz1b7uEt42DrOmX7r7gBUfmLHFwigXjc7AZRZh T6XNmNPOBO721XY/906rfiiU7AjipvzHgMfy3cAMGPyZzLnVqraIg2SchzdOdwKS2x/V L8f2pmcNyaWulyK0ZRo3sK0SdhorEIWbqJ5kup4rBLTFF1UkI5RqGH4pao7U5LCFJjCQ YTJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785391318; x=1785996118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=cs489M3XU7xPRIbALvrKU2CC1mfn9Hj5q9oo8bImFmY=; b=fiWhiKFRNMIW3ztMS1rG9XtEdFVZpmPTZ15Yc1BwBlf/55W00IpeihuBYDu3BGU1iA 3kvczRQzuCFIk5KZO3m3gAEsSfCnZuDic6f2+0vN5m44ECWLOpgy3gsy15ZnOYXC9FnH Cj1YlrzF+QEbH6br9FDrgw5+Ung2Bb7ZsxCTU6sEp0spp2MmFTeiZiqDrPCPhLxpA4en fzWoUvQb+ZJs+0i6sDJ7fCjhtqMm1pH0x/X19Zt4uaj1mXh1Sfj6nHKFynKSPqVjtwMH 7aUmOn2Ime1hb+7yreb1S2MCPLAIYyOa1KT24D9HpA2ORzxWcJMUv2dfQI/ZdvRuYA4i s8Lg== X-Forwarded-Encrypted: i=1; AHgh+Ro8U31PHz50RGijKnbXZlt6x0BR6wo6ZqrhakAOvrmQWEnA3l44Zanq2X45cbZQUd93BnFuMzl2ArFFC4o=@vger.kernel.org X-Gm-Message-State: AOJu0YwkTsY4+8s00PaC7mAbCo6/7PPkXOMDCzCcxDyScYI6Qj4tPpz1 mMLQQp/VV4s+wR4ui1+bGt/mHJiw72GG6JSrw+PXo5xhrAUgbqUpWMDD X-Gm-Gg: AR+sD13wgRaUVSLDaM+lMYOUgjpXhGpvYdLGvpOtdl4hmtLs46PvJo+7kTHL2ddOXHv tIXb3Qpef2HasZrByOIPKY8AR08Yvzm1t5ncu6uq7xYy/lAunXl7nlxHoqXfgjWZn7A9t5p4jal q2f4t/PCv8CBU5928DT+9UHVi8mYWPefTihQsosIDF2c43ekUAcXpZS7MC5IcukOgWtsErE12zL BlxRNzXbksxjbUqnv5w0Sf7KoZdp3b0jXD/dnp8wB4rTORP0HonC3k2SZHoshD4hTSpYbA8IqQO Zyp0lBxqPAQ91pZNnIs37kgomt7bk7nU9ngUXfbESAH9lBW/WJejk5Ku8wnA9ZIkc8MT/QYKcKY 8wgCMoZhYb5xW64fw6TAOpbM6Opy5EZ+4/PkHPU7puFTLmxdH15qqvq5pmaEUj2aQDiKFBvdSj9 K1u+0WJSlyF3IgV9XSedtHmMoKrOuel0yQvPC0CGVfuGUkAX03adWf+N3C9uOXIo4+s8Nra0MIL sk5C6dI+9NYdZxAVa9g667PJipR3kZU+g== X-Received: by 2002:a17:90b:534c:b0:38f:7f60:ba35 with SMTP id 98e67ed59e1d1-38f9be28c63mr1157408a91.5.1785391318132; Wed, 29 Jul 2026 23:01:58 -0700 (PDT) Received: from HAOQINHUANG-MC0.tencent.com ([43.132.141.21]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f9b42d6c8sm430737a91.3.2026.07.29.23.01.55 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 29 Jul 2026 23:01:57 -0700 (PDT) From: Haoqin Huang To: Minchan Kim , Sergey Senozhatsky Cc: Jens Axboe , Nick Terrell , David Sterba , Andrew Morton , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Haoqin Huang , Rongwei Wang Subject: [PATCH v4 1/4] zram: do not release zstd params in per-CPU error path Date: Thu, 30 Jul 2026 14:01:30 +0800 Message-ID: <20260730060133.80233-2-haoqinhuang7@gmail.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260730060133.80233-1-haoqinhuang7@gmail.com> References: <20260730025240.17724-1-haoqinhuang7@gmail.com> <20260730060133.80233-1-haoqinhuang7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Haoqin Huang zstd_setup_params() creates global cdict and ddict stored in params->drv_data, shared across all per-CPU contexts. The per-CPU zstd_create() error path called zstd_release_params(), which freed those globally-shared objects. While the drv_data=NULL guard in zstd_release_params() prevents a double-free on the init failure path, this is still a layering violation: a per-CPU callback should only clean up its own context, not release resources owned by the compression lifecycle (zcomp_init / zcomp_destroy). Remove zstd_release_params() from the per-CPU error path and call only zstd_destroy(), which properly cleans up the per-CPU context without touching the global params->drv_data. Signed-off-by: Haoqin Huang Signed-off-by: Rongwei Wang --- drivers/block/zram/backend_zstd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/zram/backend_zstd.c b/drivers/block/zram/backend_zstd.c index d00b548056dc..2584f47c9b3c 100644 --- a/drivers/block/zram/backend_zstd.c +++ b/drivers/block/zram/backend_zstd.c @@ -161,7 +161,6 @@ static int zstd_create(struct zcomp_params *params, struct zcomp_ctx *ctx) return 0; error: - zstd_release_params(params); zstd_destroy(ctx); return -EINVAL; } -- 2.43.7