From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f1.google.com (mail-pj2-f1.google.com [74.125.227.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6515B347512 for ; Thu, 30 Jul 2026 06:02:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.129 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785391332; cv=none; b=OlNZzXhY4NvdUBYFCAhiG/7sJaF3mA2UKaRrwIVwfNQuEXZrc8Ktfu2auouFRKbyWcfY/Ggdv+FmTbvx7uX9vtlK3nTsXCrnRthyf+rDtp7qixkzWTU8uo1ZO/RdAMwYO31mc5r1UNUP4nVSYS40CPU/mjim9DkC8h9E3bOky84= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785391332; c=relaxed/simple; bh=gO2rSRxdGsv8jhZWsDvRPHMXr9zG+J3HKzvsn7gjT3E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=irgm0oUWksQTpS1YNQOlZ1FowRzJsm5CZ+weWNwH4yXIlIfOkOBX290tWuuvsyTJAvQvG8drs4gwWydWY4niWm8H2443qCJgJBofR/2KAJYER86KanXzNxQc8B8kkfVo5hO/3PQV0Nor1Mk2ksxVKrf6Z02OPsYa17MyraSINxU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nOm/7wKD; arc=none smtp.client-ip=74.125.227.129 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nOm/7wKD" Received: by mail-pj2-f1.google.com with SMTP id 98e67ed59e1d1-381072761d4so993538a91.0 for ; Wed, 29 Jul 2026 23:02:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785391326; x=1785996126; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cHaCQ7C+foYsSbEdZ9oP+KDLvwJIqs/bj2IIhPeo3vA=; b=nOm/7wKDpDO+DbhIaWkHQe/f3RZ+ICANVgO5X85G9sfGpLtrdRGGhIdgDbt+1yIl7r fZyUckOwd+9jizEXm0w5lAKp/HZnpFCeJG7roRD3yTIYXFYQhiSGHnZWGCVUwAd6tDXe MybA/V5mDtw0LNiUBYehleSmKnmI9rFu0c/65+8k+PhPyZ4j3lPVZFNUXcgTzwW8snHx +Pswr0BPKn/ERrc0FfZ3udgR9+KxO0wg4ke3u1qW7C0SvxGkmMktp1f/FyWkPrqGoSW/ wQ6MThVNo0G7MDPTbjzj5JmCUoNLa38hZX8+wLjrg9M7wEFtq4vYGt5AJZP+tz5Bfi9a axKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785391326; x=1785996126; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=cHaCQ7C+foYsSbEdZ9oP+KDLvwJIqs/bj2IIhPeo3vA=; b=AcsGaNzfbdH9/pPwPAZkA8V9tTeDKJrVMXI4Dhj6CGf9Ckr0lbKuBUCluPnn4SSqbP xebdCEHC4+PmSVealH9RmZh/1A3xyXI4ndt2KOSIa/yzW4QFhg0XrRvMCQpkXom+mRWq 9+DZrc9+2p+oAKUj0TLAmyo/r/t7mSNu59dAQHM0cTrCtQQ6DCU8NBY3QmVXECh1ed/d YoZVxATkV7RVxIlWIVd6ZNNqp/HotTVQ/vgonv6BN8LdiHWfjO326Mq3tPwoZJFuxNJr xchlBY0J0uPyCPr5tb7offcJcOulMlGuDknNDghVkXDgIDceq+w/T0OicGverO65ysWg YSIw== X-Forwarded-Encrypted: i=1; AHgh+RpvMi1VJYn8Q5+7gi7h8bMbxIbgZMiO7fWjlbxPL3lcb3pAPOMlazBRGFtDoqLiXcvSAu9s7jtzG6w3dq8=@vger.kernel.org X-Gm-Message-State: AOJu0YxSI1kLRMessqsABhddi4mn21Nf6+wvI45f72nc5TnhfOMtlujY tv1yi0cWHEKeGYSwhK2Bwthu7hEMPZZgMgVu1TpGtl6gIC42mpG+Q5qN X-Gm-Gg: AR+sD11I46TqQhG51OwckeEobnm1p9lmW+gnHkQKFKnKnWINBa6SQ8muyXwYu5cI01g R4xSucshEgRRNzXEbfWDcZWnftLnKQWtj7SKSCNi5bdPhJ9Qw3zb8//vdIlhky++cARTMHdAD9w JvQxxPtVbQ4hS3KbPmFlC1oMHiw94vP1TMNjt5gzn57abnHz6vXrwRZh468iaFOAZ3JGCQ2cQ2s D99g3T/VU8T51TSAGx4p9Bmg52QIHHvxFBnvqc6+Z0kxSPfjbnAXukgz4d7BVEmx+6ja2Zkcvcs lFOEjiC3EA++i79EZ4hNMPSF0QJWCu+g+hnja+xFIwreMwElddVcvzZvxYOEj7wFufzuuVl2GAr ixF9jADXZJjGxQC+0RVQETVwKQDeABVcFXguaEfab8bTGGUMQnjkzNuJ3bbiGaCue+GJTD0UzgH sYQ3eecAfQlVutn/zOLQ73ZCCVw0CODiFqSl2KKPD/GzKJA9Nc5j65BYDBi93b4Ds5uWTZOvgcA 28ffhKC5HjylH1MV7XSiovNnOZ86KWz+w== X-Received: by 2002:a17:90b:584e:b0:38e:9045:bac0 with SMTP id 98e67ed59e1d1-38f9bd3ed26mr1130584a91.5.1785391326329; Wed, 29 Jul 2026 23:02:06 -0700 (PDT) Received: from HAOQINHUANG-MC0.tencent.com ([43.132.141.21]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f9b42d6c8sm430737a91.3.2026.07.29.23.02.03 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 29 Jul 2026 23:02:05 -0700 (PDT) From: Haoqin Huang To: Minchan Kim , Sergey Senozhatsky Cc: Jens Axboe , Nick Terrell , David Sterba , Andrew Morton , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Haoqin Huang , Rongwei Wang Subject: [PATCH v4 3/4] zram: validate parameters in each backend's setup_params Date: Thu, 30 Jul 2026 14:01:32 +0800 Message-ID: <20260730060133.80233-4-haoqinhuang7@gmail.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260730060133.80233-1-haoqinhuang7@gmail.com> References: <20260730025240.17724-1-haoqinhuang7@gmail.com> <20260730060133.80233-1-haoqinhuang7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Haoqin Huang Dict and level parameters are silently accepted even for backends that do not support them. Validate these parameters in each backend's .setup_params() to reject unsupported combinations and out-of-range levels with a specific error message. Signed-off-by: Haoqin Huang Signed-off-by: Rongwei Wang --- drivers/block/zram/backend_842.c | 8 ++++++++ drivers/block/zram/backend_deflate.c | 9 +++++++++ drivers/block/zram/backend_lz4.c | 5 +++++ drivers/block/zram/backend_lz4hc.c | 5 +++++ drivers/block/zram/backend_lzo.c | 8 ++++++++ drivers/block/zram/backend_lzorle.c | 8 ++++++++ drivers/block/zram/backend_zstd.c | 5 +++++ 7 files changed, 48 insertions(+) diff --git a/drivers/block/zram/backend_842.c b/drivers/block/zram/backend_842.c index 10d9d5c60f53..91a22313fe82 100644 --- a/drivers/block/zram/backend_842.c +++ b/drivers/block/zram/backend_842.c @@ -13,6 +13,14 @@ static void release_params_842(struct zcomp_params *params) static int setup_params_842(struct zcomp_params *params) { + if (params->dict_sz) { + pr_err("842: dictionary is not supported\n"); + return -EOPNOTSUPP; + } + if (params->level != ZCOMP_PARAM_NOT_SET) { + pr_err("842: compression level is not supported\n"); + return -EOPNOTSUPP; + } return 0; } diff --git a/drivers/block/zram/backend_deflate.c b/drivers/block/zram/backend_deflate.c index f92a52a720d1..1a2be462bc67 100644 --- a/drivers/block/zram/backend_deflate.c +++ b/drivers/block/zram/backend_deflate.c @@ -22,8 +22,17 @@ static void deflate_release_params(struct zcomp_params *params) static int deflate_setup_params(struct zcomp_params *params) { + if (params->dict_sz) { + pr_err("deflate: dictionary is not supported\n"); + return -EOPNOTSUPP; + } if (params->level == ZCOMP_PARAM_NOT_SET) params->level = Z_DEFAULT_COMPRESSION; + else if (params->level < Z_DEFAULT_COMPRESSION || + params->level > Z_BEST_COMPRESSION) { + pr_err("deflate: invalid compression level %d\n", params->level); + return -EINVAL; + } if (params->deflate.winbits == ZCOMP_PARAM_NOT_SET) params->deflate.winbits = DEFLATE_DEF_WINBITS; diff --git a/drivers/block/zram/backend_lz4.c b/drivers/block/zram/backend_lz4.c index c449d511ba86..6577b484941a 100644 --- a/drivers/block/zram/backend_lz4.c +++ b/drivers/block/zram/backend_lz4.c @@ -30,6 +30,11 @@ static int lz4_setup_params(struct zcomp_params *params) if (params->level == ZCOMP_PARAM_NOT_SET) params->level = LZ4_ACCELERATION_DEFAULT; + else if (params->level < LZ4_ACCELERATION_DEFAULT || + params->level > U16_MAX) { + pr_err("lz4: invalid compression level %d\n", params->level); + return -EINVAL; + } if (!params->dict || !params->dict_sz) return 0; diff --git a/drivers/block/zram/backend_lz4hc.c b/drivers/block/zram/backend_lz4hc.c index f6a336acfe20..5d551d165213 100644 --- a/drivers/block/zram/backend_lz4hc.c +++ b/drivers/block/zram/backend_lz4hc.c @@ -20,6 +20,11 @@ static int lz4hc_setup_params(struct zcomp_params *params) { if (params->level == ZCOMP_PARAM_NOT_SET) params->level = LZ4HC_DEFAULT_CLEVEL; + else if (params->level < LZ4HC_MIN_CLEVEL || + params->level > LZ4HC_MAX_CLEVEL) { + pr_err("lz4hc: invalid compression level %d\n", params->level); + return -EINVAL; + } return 0; } diff --git a/drivers/block/zram/backend_lzo.c b/drivers/block/zram/backend_lzo.c index 4c906beaae6b..cdbb89aaa0de 100644 --- a/drivers/block/zram/backend_lzo.c +++ b/drivers/block/zram/backend_lzo.c @@ -12,6 +12,14 @@ static void lzo_release_params(struct zcomp_params *params) static int lzo_setup_params(struct zcomp_params *params) { + if (params->dict_sz) { + pr_err("lzo: dictionary is not supported\n"); + return -EOPNOTSUPP; + } + if (params->level != ZCOMP_PARAM_NOT_SET) { + pr_err("lzo: compression level is not supported\n"); + return -EOPNOTSUPP; + } return 0; } diff --git a/drivers/block/zram/backend_lzorle.c b/drivers/block/zram/backend_lzorle.c index 10640c96cbfc..58f7ddf5a55f 100644 --- a/drivers/block/zram/backend_lzorle.c +++ b/drivers/block/zram/backend_lzorle.c @@ -12,6 +12,14 @@ static void lzorle_release_params(struct zcomp_params *params) static int lzorle_setup_params(struct zcomp_params *params) { + if (params->dict_sz) { + pr_err("lzo-rle: dictionary is not supported\n"); + return -EOPNOTSUPP; + } + if (params->level != ZCOMP_PARAM_NOT_SET) { + pr_err("lzo-rle: compression level is not supported\n"); + return -EOPNOTSUPP; + } return 0; } diff --git a/drivers/block/zram/backend_zstd.c b/drivers/block/zram/backend_zstd.c index 2584f47c9b3c..4d19d6089f13 100644 --- a/drivers/block/zram/backend_zstd.c +++ b/drivers/block/zram/backend_zstd.c @@ -60,6 +60,11 @@ static int zstd_setup_params(struct zcomp_params *params) params->drv_data = zp; if (params->level == ZCOMP_PARAM_NOT_SET) params->level = zstd_default_clevel(); + else if (params->level < zstd_min_clevel() || + params->level > zstd_max_clevel()) { + pr_err("zstd: invalid compression level %d\n", params->level); + goto error; + } zp->cprm = zstd_get_params(params->level, PAGE_SIZE); -- 2.43.7