From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f4.google.com (mail-pj2-f4.google.com [74.125.227.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C4DE3161A3 for ; Thu, 30 Jul 2026 06:02:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.132 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785391334; cv=none; b=nVSzc5MweosCNmL29EexlRU0yp3i63Kh9HgkBcR8YmZwqXkTZ5doOtxT2rR4Z0Q06knhFUGEAqD9VuDMSpL3cnPGQtZec851RlejSBxsOU64qFQgy6tImadLtIXO2avvzyDu2uT74j2f0XVl4Vwf5444HERVt5lzmFpzSjocLNg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785391334; c=relaxed/simple; bh=7nGqUdXLkhzqgzqn9ZIyxqq/NbEURTBT8NmXn3owQr4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iR72+DKm96ebFcoCZxqR098rHBScbGaiMhysr1AXeFZIqbbuBfHMBNuxup8AX/OJXqMEweIbJ9o9Ikeuln6g+q2ONzStUsLe6Pyo+jYLbb6s5cEsMY2knT1joLDkuma1XAWZthtuZBqrJ7vCABvFMVg2Thl5lhoSaxl+xYfaJ54= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IUd6P3rF; arc=none smtp.client-ip=74.125.227.132 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IUd6P3rF" Received: by mail-pj2-f4.google.com with SMTP id 98e67ed59e1d1-38111ea8a88so1091653a91.1 for ; Wed, 29 Jul 2026 23:02:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785391330; x=1785996130; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ShJflXgq4bO2T2yjTVMinL4p4VKls2GUVGVA0j22m60=; b=IUd6P3rFnDARr/CYC1htxP5EPXykj1+Lj7yddwwe8vTtb/hUO5MvbIKUMGkgEUlqNJ sqJJLpVFTvyAirz75DiGOMeR2mf8ZsxSc8ECWvYJj/0zdKMc5J+8+8hMh1NbTTjQkUKj E2eMhhYR26l5IPA9wDWJn9ks9OlqEda9OdxJ10rDXvGR85gusyXI67q9GM5udAZKj+ND iCyDAJwTA+Y/XJH8n1NNHBT6tMceAR4oYQmW1W+2c+8CHPPO+BkUmWVeywheI0m5xpNe 48vUHnULftLw2/paTsZq61e8VpQYyqKdlKn9wKrrIWvPEZgj095MdbTo9Z7TgN+XICbd OWyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785391330; x=1785996130; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ShJflXgq4bO2T2yjTVMinL4p4VKls2GUVGVA0j22m60=; b=NhykaG5fMux46ndelC9Mz/lYUNQQ/DCO3m36ThVavkJL4i5mOqqAWYtMwEyBbolV39 omRZsUB7QheaptHGyWM3bD7JC5+sKd6x7K5+UInO2dxFx4mJ+8Mc1lDdL89ZrvtzAARF TeTCU22ny4MU5HfOv5qmDqIDY4Vx2DDTe/lWYBD4kiugeZgNSOTnOtSKR0VsfKalKPDa Rbk9/ybFUI2xfI7s0SvJ1CUgh8zBZGyMDCAKejatpyH8KZyHWNKCsQ96Wmf15AbX0D/2 0PHVRY+nFucW9BZ3ZY7DSGGXpcaUCNnSjpo+CJbgSa1zNQVYCkNGs/HE9QR9SqBBXWB4 6rOg== X-Forwarded-Encrypted: i=1; AHgh+RreH8q2u6CGK5NtGtAt08p5TYzp5HanJgtZGU/92SW65eRNH4Vr0eky6WTZ6/ZwEYZ418hNRagcm5FMnFc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0tc+FYcDhNNnT01C23YfGkg4sD8Z5+NoEtnUUttxyh+Ss3SBU vboEP7j1gzJ0fpKND06QRVBb4r8ZOcMKPheQIOSX6Tzt+Xy/Vfp2ojiT X-Gm-Gg: AR+sD12PDEEjqb5Y5i7r4f+nZDQh7nFGYKQeqml3z+WKFk1M3njRZ2+5zX4J01TTKwn GHONl4MSh9s2ciLw0GuR5o9WJBpQKI99O3VYsA+CgJLC1PefNXSzqj2WBpcBHIZ+MFV+JA7Szqp TZwd1F66SNH3SzgYzwpDBFp6DYvRg1mdEkN33EK0KUKzcoIAeuhb8+vAT3a85jnhF6FFM8flP3E vLBM6emZv68MF4illndkAQra3M+wC1GgMK7jLdtfxG8NQ8IJ7l8qhU0MzANocPNLMt6m2oQF8jc 64M2B+RJL+QC2I7S73i3VC7nTz1wmaYQ7DjhgjaBjzHBvQOh/SC2egFIgxjp2hTue9/ip/91pkY jtC1mmmLvxJJw04LFiZtEwonnvp5SajVHvMO4ndGZ0HxQtjoz7mgM+GKkyVzPHR07HWNjVVDvFJ Iwk1evgm95s/4caorJjNmqIq1ukVmGsDEPs2XmaGFJ6UO96FvRPPRHJVElDrWOpg7SKhNUhShf7 ErLRkOxJVajKJN2CGDKCjXwMo6Lj4r/KQ== X-Received: by 2002:a17:90b:1d0a:b0:37f:9ce3:ca95 with SMTP id 98e67ed59e1d1-38f9c032a32mr1174744a91.30.1785391330131; Wed, 29 Jul 2026 23:02:10 -0700 (PDT) Received: from HAOQINHUANG-MC0.tencent.com ([43.132.141.21]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f9b42d6c8sm430737a91.3.2026.07.29.23.02.07 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 29 Jul 2026 23:02:09 -0700 (PDT) From: Haoqin Huang To: Minchan Kim , Sergey Senozhatsky Cc: Jens Axboe , Nick Terrell , David Sterba , Andrew Morton , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Haoqin Huang , Rongwei Wang Subject: [PATCH v4 4/4] zram: reset per-priority params when changing algorithm before init Date: Thu, 30 Jul 2026 14:01:33 +0800 Message-ID: <20260730060133.80233-5-haoqinhuang7@gmail.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260730060133.80233-1-haoqinhuang7@gmail.com> References: <20260730025240.17724-1-haoqinhuang7@gmail.com> <20260730060133.80233-1-haoqinhuang7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Haoqin Huang Parameters validated against one algorithm may be invalid for another (e.g. lz4 accepts level=65535 but zstd does not). Although algorithm changes are blocked after disksize is set, they are allowed before device initialization. Reset per-priority params on algorithm change so that stale parameters do not silently carry over. Signed-off-by: Haoqin Huang Signed-off-by: Rongwei Wang Reviewed-by: Sergey Senozhatsky --- drivers/block/zram/zram_drv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 0223fd83bbba..814f0af4d77d 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -1661,6 +1661,8 @@ static void comp_algorithm_set(struct zram *zram, u32 prio, const char *alg) zram->comp_algs[prio] = alg; } +static void comp_params_reset(struct zram *zram, u32 prio); + static int __comp_algorithm_store(struct zram *zram, u32 prio, const char *buf) { const char *alg; @@ -1681,6 +1683,7 @@ static int __comp_algorithm_store(struct zram *zram, u32 prio, const char *buf) } comp_algorithm_set(zram, prio, alg); + comp_params_reset(zram, prio); return 0; } -- 2.43.7