From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7B313A9D84 for ; Thu, 30 Jul 2026 06:22:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785392557; cv=none; b=kdl1V6fECjJfqrrTfxlTOzOIsoAKVEoDQ/ArKwMXnKKhFPIjXYsbLZY5pRiHjcVX5RILB0No3JI1oFBUG/ixJBkdt4VAu6WfHc6q+r7AQM9gGNPrG5p29ik/ol3P90x6iIgausjv3zUQk2OpEwrglQCfBnzwQj2BvzTym21eFxo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785392557; c=relaxed/simple; bh=PfjvogKB/NYHnofS01o6t7oVIvnH2r1xqmTJ590ZdOI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bX+YdQL6jCrAUN8drVWJ7ZZ12r1z2LF0qd4nKYsduPGHSWBXO5XKpqHQ64P2iAdkT4OPrO2ZtP/J+hCd7CPKFXqrnGrXwz78mB9mbx3vOEKtqILgTaQGV+U7qaDGT0Y4+PcC8wO2jGG79eYUYtv4nwtQ82j808+O4ign8e3VuOA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PkjEzmZ4; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PkjEzmZ4" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2ce7d2adef4so26447295ad.3 for ; Wed, 29 Jul 2026 23:22:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785392552; x=1785997352; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=6BV+RTasTrqeP1Jp4o3Adp3Dn5TZT1GiHMHkH/KgnOc=; b=PkjEzmZ4x9diuilIwW+CKTCTuPpe+MN/fILS4oHFXa6n4KVJZDv5VxylgIeNTq00NF KgmZXWDEdj2LF1FIxJA+BB7gDCVbsZr1dyXas8rJ9lO6KSC2nRGLTXPCqV7Mfj6rKcjm yxk45sgPfrk57BHuRjkmxpUHmAwhVZht1razRvxsYKVLhdSuqpP+W7cjkdNwcfNJLh1c lwZyVbsjFUm8vaQTkz533yAe0JwkEc1PKMjDBZzvLLRi7BxrwfZscWOiI9rfHKAW/U8l 6nNwaJS4GGVGDFksDZzQrf3LaKlUjQE+DJdP9muu4TZhVscxq/0opfheaDdYcmcuSUR/ 4zxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785392552; x=1785997352; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6BV+RTasTrqeP1Jp4o3Adp3Dn5TZT1GiHMHkH/KgnOc=; b=oJlPyahsLkQLcRjnQigJlSmRdCABx62nqZa7ljRlDfFexFo+vEL9vSY7815tqTiJWY GPfLsrdVYJTEWXAJMWEA7rmX2rzdBaXWsmsj4KrkdLum6Ov905SLfk6y73rqwwT1stds v1RMt/FIHJJusZ/aBGBTtgXoD76Sxvory8AbYM+Wq6ZhVFsMJWsJ8A8cWlszlIj8E6Wg RG9d1rGUGhzUAVLbsKP5DxzAvSZ89l2lNDnRKUVStZdSmBBQuxDQry2LBtS2n4+J0Tf6 L4sR9J0Wa3Kgdc0eC7GdL18WzHqoh+wTRUyY3a+f0J1AIe6b+yUt99DD0BEviZz8MEnT 9DJg== X-Forwarded-Encrypted: i=1; AHgh+RrHmuL/ZmMNJoh0anHqZdCJ/CP7UZTZuWq4i+4weNphRUi2ZyzfRj7AR+IlbxzbzFh8LLHKhXZ3VI1+Ul4=@vger.kernel.org X-Gm-Message-State: AOJu0YwFhHqhNKNpvhzqwlZSDKFueET4EvKeiQecCX547c5KTj+quL16 G4ZU9B5jz1iRAkdVI+2aJXVDFOTydf6g5hthVLTi5PUbwWSk7txpu/Pg X-Gm-Gg: AR+sD111tBXR+KlVbI6n35Fn8J+SdSAfrr0SXfiOGH0H14VlVAkzn0wv94+1G91hva+ jgu2dJyEynhg0D7A/i7tx3QJev/xsgjPIdcuX1QBbDdAMFmBh6wLeV3td3p61zpZTFVAQn9CPHh mL/dDhZZUnttTsiwousMhwpnLtvuVXKmgo2GSXjB5tc0mZcbSWRmX89wgSRVErt21OyavpwHUkg XqDZzHWY4nbt4RO0Xm5u1b63S4WMjQ284/f5LVWGdntqfjYWY9fmRh5BxSmv21WXFZ0iFCR2YW0 l7K/rXjVYhQ63/pa+Dc7FrwRbhrvk02UFyipI+OydYJ3jQUunEjHBc+UWZnC7+j+BTFhc6LSASY BAv3Vnb2Ibu5fQKKyIqXiDlLqDrNRJ5oP7S8x919bm4XAJNUNO2aGNhhxyIl6vLb7i2qIErKSrt 17pBL+iVLE5ZJOfi1qIWZwxrJRG/7OY6YLWijsamb4HKa4dUSC46IqlL2E+2w2Tmb3rPoO83xUN 6adIc+hhQYh1oKjoh/gCRsxmO5FAc+39Pa3twgDnAby584MTzdNIMGJh2zdIwNX X-Received: by 2002:a17:902:e946:b0:2ca:6d87:cda0 with SMTP id d9443c01a7336-2d035b9ad22mr14382925ad.6.1785392552424; Wed, 29 Jul 2026 23:22:32 -0700 (PDT) Received: from nugod-NUC15CRHU5.tail9f095a.ts.net ([218.237.104.87]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d022a151fbsm20950225ad.10.2026.07.29.23.22.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 23:22:31 -0700 (PDT) From: HyeongJun An To: Amirreza Zarrabi , Jens Wiklander , Sumit Garg Cc: linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, HyeongJun An Subject: [PATCH] tee: qcomtee: user: check the parameter count from the supplicant Date: Thu, 30 Jul 2026 15:22:19 +0900 Message-ID: <20260730062219.2836938-1-sammiee5311@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The qcomtee_cb_params_to_args() walks the argument array QTEE asked for and indexes the parameter array the supplicant supplied, but it never looks at num_params. A supplicant that answers TEE_IOC_SUPPL_SEND with fewer parameters than the request needs makes that walk read past the end of the allocation. To fix this, reject a response that is too short, the way ureq_select() already does for the receive direction. Fixes: d6e290837e50 ("tee: add Qualcomm TEE driver") Assisted-by: Claude:claude-opus-5 Signed-off-by: HyeongJun An --- drivers/tee/qcomtee/user_obj.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/tee/qcomtee/user_obj.c b/drivers/tee/qcomtee/user_obj.c index 10452fcc7ccb..2a594ae299da 100644 --- a/drivers/tee/qcomtee/user_obj.c +++ b/drivers/tee/qcomtee/user_obj.c @@ -507,6 +507,10 @@ static int qcomtee_cb_params_to_args(struct qcomtee_arg *u, { int i; + /* Supplicant can not send fewer parameters than requested. */ + if (num_params < qcomtee_args_len(u)) + return -EINVAL; + qcomtee_arg_for_each(i, u) { switch (u[i].type) { case QCOMTEE_ARG_TYPE_IB: -- 2.43.0