From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 639D8346ADB for ; Thu, 30 Jul 2026 06:51:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785394299; cv=none; b=nHfuIbDHV1/YXD+7ohrjlPXSmSPP6TXRqwDFWRkdYkMI9yAQATuDWNays9UcqByN/E0e6vUW4PcRODzR5T9f2C8tnuABIsmuXj7rx2lcWRWn5IQPLmWD73Am0iGQ0BmPvLkggDzKqDMt6ttwfS5L6CU9H+eTvgUq43Z+gVL2bsc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785394299; c=relaxed/simple; bh=icMXTnzaSJ6+MSeJ5Apat14mapNo5PQAIFNRe+YMLec=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=F793nhlx5HxODyotnvrLn2IAaluBMHQhnC+sdlQa+Z5IdA++ev+Ufx7v01RwRbi5DkEsO0olQy4+NJUmtJY3mNViI3xG6dez9vNmG1mugLuGiWtNqGibEMlX8tNjGv3Hbu13GmXu69qXCA6FsScJtyHnlbpM1swhZfoOXkLf5pk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C4bnug+O; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C4bnug+O" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2cf27856f9cso18966975ad.2 for ; Wed, 29 Jul 2026 23:51:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785394298; x=1785999098; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=icMXTnzaSJ6+MSeJ5Apat14mapNo5PQAIFNRe+YMLec=; b=C4bnug+OpoaYI6Db1xXte6jzqprbUS7hz8vW/xRkn3Jy6FNxdFaTaAJMOAjs7A6FPr hXDiKpO6hBsaeo7ZaXNBSthYr0obejy1ovGNJ84l1KXijgJsFUmow+uOnztO5lZOVI5J fIa9VDKyPvrTm6NIguioUD28h9ZHyFJHmApk9vLPVaWN1AKVU+KKTUEI7GWvHw45jpG1 bOiWIBtPCGg2llF08yV7mlKLgibAesLjlWfbwOXcL+mIphrZgyltaZmke8tdCrMt6t7o lyPrt8AJLhcZgIuxpuAomwsExdp1lPvbVoyhaTC7a64wzrVFeeMG610sCaO0yqRWJ4yo DxYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785394298; x=1785999098; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=icMXTnzaSJ6+MSeJ5Apat14mapNo5PQAIFNRe+YMLec=; b=a4VlRNOfZk/nc3YktbFC/Fxofu8+nWQAMTjSdvTGxBbB46qLbrg1CFXVsB9UvEwW20 V9v+NwbyhaRdsnrgWjywv2BMxpF4slyHQdAETBVyLn880cE4NV+VoxBLOyFb5ew63LFF wo0NWR/ALn2rM8y+LCn3J89rbyVYYsbBc5piV0F52eZCeD940VQCUxMRa56ojZCOhPu3 Ay94IAd+qAof+p7n2LBOnslhHMpG2Ij8Is7Qi8PLRPx63JIxtjwp01aTh9fCYhj1nNwY +L9yJrRYTK8GBKFvIud3NS4/UgKC3MMJi5eX76wLmAw/o2+Bud9y/jO4RofLPnLbvbQU vXag== X-Forwarded-Encrypted: i=1; AHgh+RpoT7fwwumWf7Qz++ejPAkiykAVhDFwQYCfFltYiHgdyR/qO+F/6oan/2MvLckJZXu5WI8CjHofuyyx+Ws=@vger.kernel.org X-Gm-Message-State: AOJu0YwbBVEWRJNQGhgcxyCGQZfHv7ll/W0gPjpoU+M4LDpyuBLEVWqh 1EoiLLh/iB88WkqJMCOLZT0EWv7lzHc4vGqO/Ne60XpXopmavBgMvw/q X-Gm-Gg: AR+sD132pUeUIKPVNpNx4jUZ1y2WmCa+3R3qrr9gSrjSH74+Y4tQXWN+n+dZkGQVw3k MoZqGhnkIBKcZ8f/TToRlvrKpy7A65XkSNbYNN7RMergPxc8ph0MB2Tn4jsozbYppVSpVH3X/cG TG9ZqPioDQMFkVHF8ju+mJC8bLBV9vL8qHek+QDZsjqCClku5inObpes8pVOnLURDsVATS4GVx+ Xths96Ur5MNHoFVTQ7NTAbA7+e6pIBODCcM3yci6hRTRzXKErdGT4nPDVWCOpZVxsuwpMZ51zr9 nPrWltLuZl8LNjjk4pUKmkK3Umv3ADhpTPuA+Huwkmj621Nh7nLSaARSHDVgIBnRXzp06IOLH3g UAXaNa6kGTCH2QKWBrdtZPJ+jTGMeRI1IzLoRl1KDZX4x1wrrDKNQ973PwYt4E5tbj8eIH1NEyi sC8zjGPh2xVVZd+DFK1wP1BCoaNfkVvl2/H6K0ejEi+uqVYSelukm8g9J3uxld0tHE9WTTT+vC1 0aEBIc3Q3ijYDRcFA== X-Received: by 2002:a17:903:1585:b0:2c9:97a7:71ab with SMTP id d9443c01a7336-2d035d0097cmr15283805ad.38.1785394297603; Wed, 29 Jul 2026 23:51:37 -0700 (PDT) Received: from cyh-System-Product-Name.. ([129.227.183.200]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d022bca9d7sm21707555ad.52.2026.07.29.23.51.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 23:51:37 -0700 (PDT) From: "Yuhang.Chen" To: Anup Patel , Atish Patra Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Quan Zhou Subject: Re: [PATCH] RISC-V: KVM: Add arch-specific tracepoints Date: Thu, 30 Jul 2026 14:50:48 +0800 Message-Id: <20260730065048.3715824-1-yhchen312@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: <20260626103619.174179-1-yhchen312@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Anup, Thanks for the review. I've addressed your comments in v2. On Tue, Jul 28, 2026 at 09:05:39PM +0530, Anup Patel wrote: > Drop kvm_guest_fault, kvm_sbi_ecall, kvm_wait_riscv, and > kvm_csr_access tracepoints. Instead add common > kvm_vcpu_exit tracepoint for all vcpu exits just before the > switch case in kvm_riscv_vcpu_exit() function. Done. kvm_vcpu_exit now reports the full trap context (sepc/scause/stval/htval/htinst) and is placed just before the switch case, after the CAUSE_IRQ_FLAG early-return, so it fires only for synchronous traps. > Drop the kvm_irq_line and kvm_timer_update_irq tracepoints. > Instead add common kvm_vcpu_irq tracepoint called from > kvm_riscv_vcpu_set/unset_interrupt() function. Done. kvm_vcpu_irq is called from kvm_riscv_vcpu_set_interrupt() and kvm_riscv_vcpu_unset_interrupt(), covering all callers. > The kvm_mmio_emulate tracepoint is fine. Kept kvm_mmio_emulate unchanged. v2 follows in this thread, with example trace output captured from QEMU included in the commit message. Thanks, Yuhang