From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 095273BB66E for ; Thu, 30 Jul 2026 07:02:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785394961; cv=none; b=OxUZiwOnKck38Hj1eG8JwWHZZyLrp8shlrlnspYtbJCknpa5l1FTuM83uRAUO7w3Sx6OSM0Dy5gzHgO39XyHoG3WWh/PsUva++4NDEL8bncBWyX0jK9k0mAS3E6Z2UUlFAZAjGJTHNPXNb4SeJxxwVkvtkbR+0VxUYTsyc/N5Z8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785394961; c=relaxed/simple; bh=wJU3jDsZvwe6A/nHebd71vYMuOQRCT1kM2KdZRJa4hY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IFUFbTA9CR3AcZM+QapyaZOxkR0MmOmK4vhqFwB17xIjhbD26fl/6SoiIO+j+DTYXClVu/0l0EX4hSdi8qQFgzaQljHii45sjzGiEBu0dqqGZiV7+sywlQtOltr6/BE5Tt1uSncHj4dG1yiar8nUi5nJvnkpgva7dmZJ6i8kFJE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GrZPQHTr; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GrZPQHTr" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38e071ed6aeso1520407a91.0 for ; Thu, 30 Jul 2026 00:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785394950; x=1785999750; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=h+MtJnOvs8AYg7ENm20sNfdBwSbBhTZCGHZJyclXCfA=; b=GrZPQHTrRkdsH8IfNBqfrr9HqPq/1MHM+nBjQdGCYPfaLf2nf5rcV2LJ+UiWb3armt EWRn51TMpyIZCa2/v880R2CdQDa6si4La9UG6SuLrlvJ3tpG9B9Ih5k8clf8jAyCyaS3 K+xt0f5mXeK0ls6C3JFo9bPN1s+oQA2LcB+Tr8XdblSDlZ8tp/YkHm9tWBV1K8ES7e4Q /vcZVZXlIVnJHrHvUsy86mkt2iM0rufpyQH6X5riTN8pm6zubZ2M+bMmefs6xAzZjb6A DjRhaS7t6EJUopjXe99M+ZL9gpIt+ahyq735yUwDFo9pU58Lti+4Cd5iiPSehJsOxYWt LTHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785394950; x=1785999750; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=h+MtJnOvs8AYg7ENm20sNfdBwSbBhTZCGHZJyclXCfA=; b=n4tkgvfP/CpnCwboIrsdoGJfWuZfdFqXpC6BkCcA4XYoMm6OHbLJE07Q64rhlqIswA gfu+9iunkE3ypHNN83R1jeKb23NB0qAW/HIdczzm4vQk7MP4YB593bnud4UQ+s9EAImY R5ssG39HAoEyKjUjHFtGYSApmdkX8gtL8tj+Pz357M6IlmF2tqfflt0aW0Qjg+Tj8jS1 u2M7NLVFNc6R2U/DGK8mKaE46OMQVOy4c7eE8R0yfNqMjTSZdRTGGyo2gNM7+CIeK+CP ZPsFt/6s3U3zp6pb4ZW1dk1DLrmjjBpvUzp6xW0bh66xzWm3J1/ZyhylkT6mPiRdrznx uLwg== X-Forwarded-Encrypted: i=1; AHgh+RpegcItV+R89uur3Y2dn8miTnhJ1vsb3/9cWqMoM9/v+IxQreQf6dJeL8J7jPVz6HLJ8VRwUhG1mqImGQs=@vger.kernel.org X-Gm-Message-State: AOJu0YwmQ0n7ZzGmOa1F4gQHVXisrKmKqRUz9P6kqjNfiCLWRGU8QEpB 9g65hEpXxYLupC0VRunPEoXtwg/dghlz4ch1wCV0qCePaUUw/DqQSV8L X-Gm-Gg: AR+sD10E0EM8SfGI0eBkFHotxLX+hItKRj2LDB3uaAnG5Vkpjt62twUx2s6mODkbJrO XWRkfkqjhfHXB2UU3jZSTikOV0hMoJk77qNrPYcE8aZ3HUyN/pP2xhAoYPNm2YKLmxt9t/ztfgp PGQZFlzdhua5HE4bIRnewhK5x8f6kS51psAOPQrKZQfHfQxSuMoQrzpGhfWcTGdmzQzI7/Nby9U KMrreqrcfQvSKnDnSongJy9ToPpr6QdwXneN8L2ZaU71uaQuR31o4b24a1JFXgQg7XmaL7A9x6g GqNDbzjXVhgrRIMUjc3IkTyPtR85QUi8G0pqWnNvXZOvDJU/5fUkC1KoIQwBkSMGagf4WY2OETv rknuDM/l3MNH/JhsmadgbSJHzc4BUc0RVzSECYcQsBmbMi9uNOXFBTgKNajHjMur/j/DLJUJ0Aq tigh4UTuSxZNVLQaF8IZU3JU3JCu2CPYvpePjWUJP/4bAXGRalAX4A45tbV5k2E4QuQw== X-Received: by 2002:a17:90b:2583:b0:37f:c69d:ce69 with SMTP id 98e67ed59e1d1-38f9bd83fa1mr1421020a91.10.1785394949977; Thu, 30 Jul 2026 00:02:29 -0700 (PDT) Received: from Default ([2409:40f4:1008:1710:a945:87ad:2d3e:163d]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31504dd42a9sm21046149eec.30.2026.07.30.00.02.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 00:02:29 -0700 (PDT) From: Jeffin Philip To: gregkh@linuxfoundation.org Cc: xu.yang_2@nxp.com, Frank.Li@nxp.com, panjunzhong@linux.spacemit.com, kees@kernel.org, jeffinphilip14@gmail.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+8dcac923582c28505fd7@syzkaller.appspotmail.com, stable@vger.kernel.org Subject: [PATCH v2] usb: gadget: uvc: Fix Null Pointer Dereference in uvcg_video_init() Date: Thu, 30 Jul 2026 12:32:07 +0530 Message-ID: <20260730070207.16065-1-jeffinphilip14@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In uvcg_video_init(), if kthread_run_worker() fails, the error logged uses uvcg_err(), however, the pointer it uses: video->uvc is not assigned at this point, triggering a null pointer dereference. Fix this by directly using uvc->func which is assigned already. Reported-by: syzbot+8dcac923582c28505fd7@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=8dcac923582c28505fd7 Fixes: 7ea95b110811fa8e41f5960c278bcfc80b8b21c1 (usb: gadget: uvc: rename functions to avoid conflicts with host uvc) Cc: stable@vger.kernel.org Signed-off-by: Jeffin Philip --- Changelog: - Implemented fixes suggested in v1 discussion https://lore.kernel.org/all/20260730055705.13784-1-jeffinphilip14@gmail.com/T/#u drivers/usb/gadget/function/uvc_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/uvc_video.c b/drivers/usb/gadget/function/uvc_video.c index 2f9700b3f1b6..9ba09118bb74 100644 --- a/drivers/usb/gadget/function/uvc_video.c +++ b/drivers/usb/gadget/function/uvc_video.c @@ -821,7 +821,7 @@ int uvcg_video_init(struct uvc_video *video, struct uvc_device *uvc) /* Allocate a kthread for asynchronous hw submit handler. */ video->kworker = kthread_run_worker(0, "UVCG"); if (IS_ERR(video->kworker)) { - uvcg_err(&video->uvc->func, "failed to create UVCG kworker\n"); + uvcg_err(&uvc->func, "failed to create UVCG kworker\n"); return PTR_ERR(video->kworker); } -- 2.55.0