From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B8CA399361 for ; Thu, 30 Jul 2026 07:13:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785395611; cv=none; b=VnhQ5+CkjByXc6OAdveBXNPDGTqkLhoUxbkmY3SrvF5PT5+b8nYkdrRHnfMlXod//qStFkvHNkI0GBhLNBmOYFoqBWKL3D2vi8WGfeizepAD55tv4AQBqbhwsuSHo7jd5/XZcAicjv3vNtVbWyEOOFXrfJP7XD07AeAKpFDAw6w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785395611; c=relaxed/simple; bh=emxEg94ysxHiYRTLMk7ixDXbklGd+5bWK5o1MqHykbU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KKZsq0oV9erwM9KuGrs4HsgdXdRdN/kwLFJT46hEKs1WIGxk+Ysd57NIRCUGqyGSBM/IoJTeAb04abqewEPBWXv9WvOwZiU8Gy8R2VWWZbN8Gqfjlg3ASpj3S1LVjpmvL+Ms7eNrHo2eQFRL9GiQ88MuBWi6Gv15HcwkUpXG83o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KST5sPNQ; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KST5sPNQ" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-47de0093c42so1342079f8f.3 for ; Thu, 30 Jul 2026 00:13:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785395608; x=1786000408; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=CPrk4t4iG0XjStu+o65Zjwa966zGEs6R7VTzoqoByrg=; b=KST5sPNQuVw1yD21ITM5jMokE+T3nkUo/cqTF2mbMMgnc4c6jWBTshLTN8CDFLPLCA Df8Q/HqzQyVSbYd5arWNLKU2u+Gozma/buVy5dk4rhCQrggih2sJYqpLVE67WJQrD/Qc +O5CzsWwsn5WapfFDkX2rBvp/9+xkZN8Yd1tooAQeOtm+16CCqulP+GCxhDweHXO0W9E R3PNzgHEkRe0yWIprqgcdah2/4uauOgb+Wca8y0O5mYGnC8wmPyFsedIn3bm7CfUQ89L a3olDdWYw1g5QkG0PjKg9jmPguMHEA2RYwQvhRUsvSoTso/yY+Ecb7tV4BIgfInmbdJE HOiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785395608; x=1786000408; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CPrk4t4iG0XjStu+o65Zjwa966zGEs6R7VTzoqoByrg=; b=ZOPYpfigthgMCRUDJeXJ6tihyNWU0Y/fT2GiZaXHnho7fNkXZmuu5jVPOA/1eupWTj oPyQYYfwY6z9NmCUooYGM4LSGCkf4kbQnpTZpcOIZIAjkDAVnKbrQ3uhganz8sjObQ5i UYQkPLXw7hq8oY6v8guP4TZXdW0q4PD14kIrY/gM3F28x1eoCESoHF81g5JR498FIIHH Y/zKcvyrUSSyWUU1Pgk0hGgBA8oYkf8RzQa51T6Uti7RSw+lEsTPlbHZjN+q9DVwfZ/F 3gM93Mcs+skFk0Gdx5eyoB9THdF9cZWPzPMaLyhIu71pYvhEnuKxNyrJwp+MV07uGDXJ hckg== X-Forwarded-Encrypted: i=1; AHgh+Rqo74ZIQe7Arrjom4SI5cL9AEJgFY9cX3ZJe/587Uqa5LOqZkw4oaxkcAh4jjFjFdUHRQCyDdsr1NoNnsI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz41DCd0NfxCwXpQU07jhC752lngzSfAwf5lbBlUsTi37qT5pdx II8WV8VTr6h77FHwmCRzmZZD+/r1ZucCIxlMoPoVG4Wkt4s1wNkTHXM4 X-Gm-Gg: AR+sD11YhR9QCRk3G6gI6zv3fGVlbMNAFaynREeyvM1mZeKUhjVL13+GAmRkfAz6ByG 9/BYhXphVoK6GXPnYho20HHpangvPpeDmhTb/DGbXCbnndBUFx5EJBQuHqfQQ/aPS+28Xijbpr0 vTBiJuvcqsLZLVnmhY/A3UQxc9lePelb1SZwNHNXtNiGlUh+LaFRvwXKAU6qfDnGGABsMuwKQlD 9C656pqd8zcfmkf0RceXrq1ndfHvuG5mX4hRsexiA2Z6aDXujv4zSf8LvWr24nq2Upjro0lmlPb OBGg2kf+sD8NrAfJPDyyNwzTc8nZI3kXZlLCkO/sj7APfcxyek7rWwJ6rkgEEExVhTXCJgtZ7R9 6+akAyKDnM3+6C4WxpE7sMDk0O0cfRKPZ0F8N7quP0w3v3Xofjdu7uthaH04wLaD+C8o5lYaEKE +gz6F83L0tVm5hijvBaI4YZeA4R5v3sn4qZTszmDkyuPP+iVZI+uowtHNwXCvE4BHZJbZ3Nd3N0 pF6z4DyzeUcKw== X-Received: by 2002:a05:6000:4382:b0:47f:6efd:8421 with SMTP id ffacd0b85a97d-47fc81ee02bmr1757235f8f.13.1785395607476; Thu, 30 Jul 2026 00:13:27 -0700 (PDT) Received: from LAPTOP-AVI.taile24b5.ts.net ([2a00:a040:1b7:4f41:1fba:f3be:5adb:fb78]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fc88d6f18sm3534010f8f.4.2026.07.30.00.13.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 00:13:27 -0700 (PDT) From: Avi Weiss To: Andrew Morton Cc: David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Soheil Hassas Yeganeh , Arjun Roy , Eric Dumazet , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Avi Weiss Subject: [PATCH] mm: return -ENOMEM for page-table allocation failure in insert_pages() Date: Thu, 30 Jul 2026 10:13:23 +0300 Message-ID: <20260730071323.964321-1-thnkslprpt@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit walk_to_pmd() returns NULL only when p4d_alloc(), pud_alloc(), or pmd_alloc() fails. These are page-table allocation failures, but insert_pages() currently reports them as -EFAULT. Return -ENOMEM instead, consistent with the subsequent pte_alloc() failure and with the single-page insert_page() path, which reports failure of the same page-table allocation chain as -ENOMEM. Address and range validation failures in vm_insert_pages() continue to return -EFAULT. Keep the later -EFAULT return for pte_offset_map_lock(), which is not an allocation failure. Fixes: 8cd3984d81d5 ("mm/memory.c: add vm_insert_pages()") Signed-off-by: Avi Weiss --- mm/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memory.c b/mm/memory.c index ff338c2abe92..d8eddca8e251 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -2436,7 +2436,7 @@ static int insert_pages(struct vm_area_struct *vma, unsigned long addr, unsigned long pages_to_write_in_pmd; int ret; more: - ret = -EFAULT; + ret = -ENOMEM; pmd = walk_to_pmd(mm, addr); if (!pmd) goto out; -- 2.43.0