From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A35C43B1009 for ; Thu, 30 Jul 2026 08:24:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785399890; cv=none; b=NGUn/nGOgRY9I1uR2sDV6haK8RvijV7nH8fPBu8+8QrToW68jVnDpzs0X8ufiEf1t601H5JOM0/rdQVnToqFbNZdE1NCNqYzwyFWopo1cEo/+Lk8Eja3C8u/C3OrV2IoLggO+Fi2u1PLyRh5YVsTBreekBpmFstf3DUPrnK2l3E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785399890; c=relaxed/simple; bh=gntGOjhXBA07pEHUhCuN5FxM8fYNhjoRrBO+RAoJbEc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YdMlLZ7W1T/3cUG0TNI2FR7EyUZVHGutPuTGxc0DoHUP+1sC8ZFuIyxiw8l+3wOzyDPrfkVFgnHJuOfhgLslTm4SZY/i4f4Q+NXUjur41lFWNCmXG3r/SU7y+UNFv+03JjL7fJfUIh9Ykz1bwtfOG2CVEYgOnZjtP4/uO0hTngg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PxGNGUN/; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PxGNGUN/" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-38759bcd877so1618280a91.2 for ; Thu, 30 Jul 2026 01:24:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785399888; x=1786004688; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=W5J4K0JrlDOYNnYHo+BgER+kVovsWbiV6MG4x4gNbJQ=; b=PxGNGUN/Qa8Ut/M97G+OzzqrceHThC3ny/kB23pNtkCFf70B52XpizRrEavs4E5oxM yKg4dLMxuRJchi5pUk/4ycC+qgEQR5UL17TAWGBGkAA1Xf1mvh8I0qiOPPkjg//snt0a A1fHM7CSxcPsBoibhNd18NmPRFR6IaaxrxIWKkCVd75bnB7o6ZgCTgp3aJt0FteZTy8M 2Yv04QfTO279XSeVY9W4D4Kt7AegSE1ExkTsAnQQZdgCCvkZYi397Dvez9LTBJpZif0w hHnhWToUuNgGouMLaWXpo1V2Wl7mgNYdYvbZKRpG+oFl30Ksp9KxRABOB2Sw2p6suYKl E/9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785399888; x=1786004688; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=W5J4K0JrlDOYNnYHo+BgER+kVovsWbiV6MG4x4gNbJQ=; b=MlSYzTm5rZSWW3//nOCyrMsAbOv4Bs3EYgOcSyZ5zk7HMram0KRtXWvmyhkU2S61zI MjSK5uDUe2TCNmDIlH4oMoGDleg9EScJG7LIx96kGO0Lj3Qz19XAu8tat1ZM16r7evXL ddE0tSCWiquirh96Z+TG2BaspJnKbX7XUfoQIsG9PgNcl/QSbHwnTazsBFDD7WkrVB1X n37TqZDDdxb3d+EYf2ISxggl5tZZI39H7wZ+8AS/8qCj4VctKP6DDzyW14OWuAP2v5+B s8esI3qFwpK7EitujM0p0/UTfeTTX5Hthyav5kRPBvZr0OS7xgLOHUo741adIs95FFSk gNfg== X-Forwarded-Encrypted: i=1; AHgh+RrIX4WexNnS+HrJ22WOBWepjKJW97KOQ7uM+jA9Ro9KfQuxYQr2eh1lXn3WBSSqP8WA0zj0LyWI2zQxqwI=@vger.kernel.org X-Gm-Message-State: AOJu0YyDqBXCGr92x0lu5mFr3uJey+yjr2ie1OkhUSY3Aa1+mfjVPFEh SqOctLc8BAj0Ya0XBpFj1UBZV+UadX1nOBUdhR3pImSohRB4WFedrbHN X-Gm-Gg: AR+sD13NIegWy3hoRPKM99kuC6TeKT/kV/uT73bv8wRdZDU/NNR+B7ngHc7r2cTps0U 9cNpu2cT2Ne+yds/o8og4lYEelXluJIn+kRopUIHcwOeOVljt8hhhkHOPbvyQcQ2m+2L6vb7iT1 kD0hax6p2X+O+VKxn9PqgRM7+LM13XcAsbHwzj0hynDSbbuWyaSQHYz1/Hg3q7UsDAA4uCVH2/p g6vAPqweOarSY32L+EHBIKz8kZ7ydOE7VReOz+9Ov4r9D3w9V3QpOXZarh07MJ9Q6p2au1Xlhw9 6fExWERh/uJqSHf5t+BshqSIi6wqzvN3EOACZ1p5ztbsr6M940fWlD1QCxlXpvz/qwMgh0ZmdEx w2qdE5Sktu3VOH/DSAUi0kz5z3yY1YSLq7LvyIdIrWFIXuFJUf5xhk3YF5hmixh0a/p2DJLN7dn 8yYLOFefwkWzURzAUtpw+CiaM6qf+z80w2ky9hqGLLb9i5WYAULh9R8oAvaDwho/F3mQ== X-Received: by 2002:a17:90b:1d4d:b0:38e:5dc:af03 with SMTP id 98e67ed59e1d1-38f9c1016e8mr1412538a91.40.1785399887890; Thu, 30 Jul 2026 01:24:47 -0700 (PDT) Received: from Default ([2409:40f4:100d:2c91:aff5:d71c:30c2:c60a]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31504b124e4sm17281938eec.6.2026.07.30.01.24.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 01:24:47 -0700 (PDT) From: Jeffin Philip To: gregkh@linuxfoundation.org Cc: xu.yang_2@nxp.com, Frank.Li@nxp.com, kees@kernel.org, panjunzhong@linux.spacemit.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jeffin Philip , syzbot+8dcac923582c28505fd7@syzkaller.appspotmail.com, stable@vger.kernel.org Subject: [PATCH v3] usb: gadget: uvc: Fix Null Pointer Dereference in uvcg_video_init() Date: Thu, 30 Jul 2026 13:53:20 +0530 Message-ID: <20260730082320.9597-1-jeffinphilip14@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In uvcg_video_init(), if kthread_run_worker() fails, the error logged uses uvcg_err(), however, the pointer it uses: video->uvc is not assigned at this point, triggering a null pointer dereference. Fix this by directly using uvc->func which is assigned already. Reported-by: syzbot+8dcac923582c28505fd7@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=8dcac923582c28505fd7 Fixes: 7ea95b110811 (usb: gadget: uvc: rename functions to avoid conflicts with host uvc) Cc: stable@vger.kernel.org Signed-off-by: Jeffin Philip --- Changelog: - Small fixes addressed in v2 discussion https://lore.kernel.org/all/20260730070207.16065-1-jeffinphilip14@gmail.com/T/#u drivers/usb/gadget/function/uvc_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/uvc_video.c b/drivers/usb/gadget/function/uvc_video.c index 2f9700b3f1b6..9ba09118bb74 100644 --- a/drivers/usb/gadget/function/uvc_video.c +++ b/drivers/usb/gadget/function/uvc_video.c @@ -821,7 +821,7 @@ int uvcg_video_init(struct uvc_video *video, struct uvc_device *uvc) /* Allocate a kthread for asynchronous hw submit handler. */ video->kworker = kthread_run_worker(0, "UVCG"); if (IS_ERR(video->kworker)) { - uvcg_err(&video->uvc->func, "failed to create UVCG kworker\n"); + uvcg_err(&uvc->func, "failed to create UVCG kworker\n"); return PTR_ERR(video->kworker); } -- 2.55.0