Re: [PATCH v2] drm/tyr: add Job IRQ handling

[Laura Nao <laura.nao@collabora.com>]

Hi Onur,

On 7/29/26 18:51, Onur Özkan wrote:
> On Wed, 29 Jul 2026 11:58:29 +0200
> Laura Nao <laura.nao@collabora.com> wrote:
>
>> +
>> +    fn handle(&self, status: u32) {
>> +        if JOB_IRQ_RAWSTAT::from_raw(status).glb() {
>> +            self.fw_ready.store(true, Ordering::Release);
>> +            self.job_irq_wait.wake_up_all();
>> +        }
>
> You enable both GLB and CSG above but only handle GLB, is this intentional? This
> means CSG will trigger the handler, do nothing and just get cleared, or am I
> missing something?
>

The series that will later add CSF interface support will likely only 
include a firmware readiness check at first, with CSG bit handling 
added at a later stage. That's why we're only handling the GLB bit for 
now, but I agree unmasking the CSG bits here is premature then. I can 
drop this in the next revision, keep only the GLB bit unmasking/handling 
and add a TODO comment for the CSG bits.

Thanks!

Laura