From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05F15400E0D for ; Thu, 30 Jul 2026 10:25:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785407105; cv=none; b=txAwy32N5SMN8klHYtI0JjGAN6096xdehTlNlZZjsr/mgQZYUdc9eDgjMl6xWB2wuPEm6RbvNMp5lV/QD0yAa0Hc0A8vdc+bJjtTtu5h2BOw7wGZ81cwmdf+dJdL3snCgGMWHpLtsiqPjnyr9h90vyBOoWoVMZgD2Z/H0uLVjAY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785407105; c=relaxed/simple; bh=XUz/ShyoXvuqlw5THYosa3ImAZDVrvlgDzE2uZvQ3kw=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=f3o8K4EAjwBYJRQUccO3GJ4UkXDAOirDokBvrkgdu/qr3H83z2vcqkoQesjkNBqXgb8sUNrXyGyH971SYSWFWORUZnx+EHEPQ26vzDkiQSR1OGa43DCpRyWXgwOKHDDMIsGzdskhpeUYN9T0kC0V10m4h7oso6mJgTs8kaMxpbc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qBuNzwJ0; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qBuNzwJ0" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4956242332dso16796725e9.2 for ; Thu, 30 Jul 2026 03:25:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785407101; x=1786011901; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=HyaO/jLnPM53YSkqIOaOcGO+dZK6Ewb3QeITvgnsvkk=; b=qBuNzwJ0cMkfi60dyiHLexzN1SKuBukjsHXLRm28/Vp4rF3hClBIDxO8bb5CiOM4Xr TfMYzfgUZ8IyFnt50b798vinjERmkSkVVUq6/VjDYCAjBQUSrFKyZq2Y+TablMQpriAg JohVKzqstLSh6DZ5A7DqfnoYDMO/MFH/Mtd++Iy5Ch9ohHYd/kdRwCU6kG6ynSQLhx0d VOwSOZ9yUZVL9RuniAgQ07HIgtSy2VvUHst11eTsESs4vcJpqtnc5ywzSGR8Soxpo8Ji uHEFgEHxknritiKarr362dDHLWl8FE7iDGcUbh0zys8zpXnKDBrpzUNe7nwkGnm3UU1L c7qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785407101; x=1786011901; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=HyaO/jLnPM53YSkqIOaOcGO+dZK6Ewb3QeITvgnsvkk=; b=eTgMDzfc2gz4sKyPRWCNdC4GZeq4A9iWXnDI0aLmsy+vm1baG6hGbC4BG9qJ+JzxsY MjdEJ1rKRFGvpjsX94zX/122/UgZiESeiCIEaBPYs5qEB27uDdyjnIH0UUgNmuGtRNEM HLSwGFau97mBiVPq/1X99RTZfwnNiEpmW/TAUVeH/WOo51MZhZRGIrw3ZzwElYWBETbf XE/BhzUnX6uhbz5vuQ+NZR/tWWBOlGjIi6PWxhE+pxogJJwU1Nvxu+0QfCAhdi2djxj+ Er5hLXvzfNFXIThADjsrdp1lhX9H2w4eT4qPFkIcNieIgyWEyTYekAf5wxZ88v8w/pTe p4iw== X-Forwarded-Encrypted: i=1; AHgh+RqxdZXl/lN5jawx94rSpcDboZbJ047UeDVF5X3jplyQJL+qGTHlxljq0jATQ+V/Igl4MbfJHdZHBc8oagQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yyk333FEl9CflDky1+FD1aHODJKH/1ru+PM9mZd8IyD9L2c2cOy W71OpK6lXzHBghX9tELmpLjfNDos4B5zHhG1ycDjktxImHchsOcC5ltK X-Gm-Gg: AR+sD13voSIyc5dhnrmgy7EPAsCDbUPYm9adqtaSRSwMX5CsGxY64aLrtytIArffFhB yKbLcqlqblKFBpCmG/LGJ6O/wgPCrBz+ibFcaQ3F3znUjS+0U+JVXoTkt4ztWJSlBYnRweY1V/q //JO+Lg+iMFJtk2Mj81cteEvZESnKs5FQIySbMI9LycymkpD7YaGSsv+ORrRlEnL4GGyae5qmi2 6mz/N0nWOIY8ziguRdf6LiVHwx1qQBZjxyZQqmVIRqe4QUeXeA0yOo9Pm/NBih23JDZeJnN9pGs 8r+C5+BD2KIJoFQ5LAvjyzckGbAM8oZA6+JuAfXhiINMsKnl9Fl1nXbiEyhe54k4z4F80YpYcTL 41qII4DvqO1qPhcFWCyVYBUygM3JnRmaOVckaUohLSkEzA7Q1er/TzKRkzCOnr9vVYR1aava1Ns /BbD5N3EA+6swiN96cwUrx6uZh+tNrnn5EQ590QS2FNtdrtYj3kBh1P2eDem6eFXNvxhzEwiOE1 +kFiUk/6HYqvAt6QvaUq+0fOtk28C6Zbes366xy97k2gR8bxYuKQw== X-Received: by 2002:a05:600c:41c3:b0:495:4e89:3f30 with SMTP id 5b1f17b1804b1-49800e7b178mr13191645e9.15.1785407101144; Thu, 30 Jul 2026 03:25:01 -0700 (PDT) Received: from Ansuel-XPS24.localdomain (host-87-11-254-126.retail.telecomitalia.it. [87.11.254.126]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-498011fd5fesm44720295e9.7.2026.07.30.03.24.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 03:25:00 -0700 (PDT) From: Christian Marangi To: Maxime Chevallier , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , Jonathan Corbet , Shuah Khan , Christian Marangi , Lorenzo Bianconi , Heiner Kallweit , Russell King , Philipp Zabel , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, llvm@lists.linux.dev Subject: [PATCH net-next v10 03/11] net: phylink: add phylink_release_pcs() to externally release a PCS Date: Thu, 30 Jul 2026 12:24:14 +0200 Message-ID: <20260730102444.1967900-4-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260730102444.1967900-1-ansuelsmth@gmail.com> References: <20260730102444.1967900-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add phylink_release_pcs() to externally release a PCS from a phylink instance. This can be used to handle case when a single PCS needs to be removed and the phylink instance needs to be refreshed. On calling phylink_release_pcs(), the PCS will be removed from the phylink internal PCS list and the phylink supported_interfaces value is reparsed with the remaining PCS interfaces. Also a phylink resolve is triggered to handle the PCS removal. The flag force_major_config is set to make phylink resolve reconfigure the interface (even if it didn't change). This is needed to handle the special case when the current PCS used by phylink is removed and a major_config is needed to propagae the configuration change. With this option enabled we also force mac_config even if the PHY link is not up for the in-band case. Signed-off-by: Christian Marangi --- drivers/net/phy/phylink.c | 60 +++++++++++++++++++++++++++++++++++++++ include/linux/phylink.h | 2 ++ 2 files changed, 62 insertions(+) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index a5e2d342a92e..562e09d1838b 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -158,6 +158,9 @@ static const phy_interface_t phylink_sfp_interface_preference[] = { static DECLARE_PHY_INTERFACE_MASK(phylink_sfp_interfaces); static void phylink_run_resolve(struct phylink *pl); +static void phylink_link_down(struct phylink *pl); +static void phylink_pcs_poll_stop(struct phylink *pl); +static void phylink_pcs_disable(struct phylink_pcs *pcs); /** * phylink_set_port_modes() - set the port type modes in the ethtool mask @@ -917,6 +920,63 @@ static void phylink_resolve_an_pause(struct phylink_link_state *state) } } +/** + * phylink_release_pcs - Removes a PCS from the phylink PCS available list + * @pcs: a pointer to the phylink_pcs struct to be released + * + * This function release a PCS from the phylink PCS available list if + * actually in use. It also refreshes the supported interfaces of the + * phylink instance by copying the supported interfaces from the phylink + * conf and merging the supported interfaces of the remaining available PCS + * in the list and trigger a resolve. + */ +void phylink_release_pcs(struct phylink_pcs *pcs) +{ + struct phylink_pcs *pl_pcs; + struct phylink *pl; + + ASSERT_RTNL(); + + pl = pcs->phylink; + if (!pl) + return; + + mutex_lock(&pl->state_mutex); + + list_del(&pcs->list); + pcs->phylink = NULL; + + /* + * Check if we are removing the PCS currently + * in use by phylink. If this is the case, tear down + * the link, force phylink resolve to reconfigure the + * interface mode, disable the current PCS and set the + * phylink PCS to NULL. + */ + if (pl->pcs == pcs) { + phylink_link_down(pl); + pl->old_link_state = false; + phylink_pcs_poll_stop(pl); + phylink_pcs_disable(pl->pcs); + + pl->force_major_config = true; + pl->pcs = NULL; + } + + mutex_unlock(&pl->state_mutex); + + /* Refresh supported interfaces */ + phy_interface_copy(pl->supported_interfaces, + pl->config->supported_interfaces); + list_for_each_entry(pl_pcs, &pl->pcs_list, list) + phy_interface_or(pl->supported_interfaces, + pl->supported_interfaces, + pl_pcs->supported_interfaces); + + phylink_run_resolve(pl); +} +EXPORT_SYMBOL_GPL(phylink_release_pcs); + static unsigned int phylink_pcs_inband_caps(struct phylink_pcs *pcs, phy_interface_t interface) { diff --git a/include/linux/phylink.h b/include/linux/phylink.h index ca9dfc142388..15e6b1a39dfe 100644 --- a/include/linux/phylink.h +++ b/include/linux/phylink.h @@ -751,6 +751,8 @@ void phylink_disconnect_phy(struct phylink *); int phylink_set_fixed_link(struct phylink *, const struct phylink_link_state *); +void phylink_release_pcs(struct phylink_pcs *pcs); + void phylink_mac_change(struct phylink *, bool up); void phylink_pcs_change(struct phylink_pcs *, bool up); -- 2.53.0