From: Andrew Morton <akpm@linux-foundation.org>
To: Seunguk Shin <seunguk.shin@arm.com>
Cc: <linux-kernel@vger.kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
<linux-fsdevel@vger.kernel.org>, <nvdimm@lists.linux.dev>,
<Nick.Connolly@arm.com>, <ffidencio@nvidia.com>
Subject: Re: [PATCH v4, RESEND] fs/dax: check zero or empty entry before converting xarray entry
Date: Thu, 30 Jul 2026 10:38:04 -0700 [thread overview]
Message-ID: <20260730103804.063ce671588b02c2596d5de3@linux-foundation.org> (raw)
In-Reply-To: <m2v79wmxig.fsf@arm.com>
On Thu, 30 Jul 2026 14:12:55 +0100 Seunguk Shin <seunguk.shin@arm.com> wrote:
> dax_associate_entry(), dax_disassociate_entry(), and dax_busy_page()
> call dax_to_folio(entry) before checking whether entry is a zero or
> empty xarray entry.
>
> That ordering is wrong because zero and empty entries are not folio
> entries. Commit 98c183a4fccf ("fs/dax: don't disassociate zero page
> entries") added guards in the associate and disassociate paths, but the
> guards still come after dax_to_folio(entry), and dax_busy_page() still
> has the same problem.
Are there any known userspace-visible runtime effects of this?
If so, please fully describe them in the changelog. If not, please
also mention that.
This is important information for deciding which kernel(s) need the
patch.
> Move the zero/empty checks before dax_to_folio(entry) in all three helpers.
Thanks.
next prev parent reply other threads:[~2026-07-30 17:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 13:12 Seunguk Shin
2026-07-30 17:38 ` Andrew Morton [this message]
2026-07-31 8:56 ` Seunguk Shin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260730103804.063ce671588b02c2596d5de3@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Nick.Connolly@arm.com \
--cc=brauner@kernel.org \
--cc=ffidencio@nvidia.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=seunguk.shin@arm.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®