mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiaxing Hu <gahing@gahingwoo.com>
To: heiko@sntech.de
Cc: tomeu@tomeuvizoso.net, linux-rockchip@lists.infradead.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jiaxing Hu <gahing@gahingwoo.com>
Subject: Re: [RFC PATCH v2 2/8] pmdomain/rockchip: add optional per-domain power-on settle delay
Date: Thu, 30 Jul 2026 23:32:38 +1200	[thread overview]
Message-ID: <20260730113239.1417912-1-gahing@gahingwoo.com> (raw)
In-Reply-To: <3322194.D8ZAKjAxdT@diego>

Hi Heiko,

Thanks for looking.

Understood on the naming. The suffixes describe the fields the macro
sets, so a variant that also carries a wakeup delay should say so. In v3
I will add

  DOMAIN_M_O_R_G_W(..., g_mask, delay, wakeup)

and leave DOMAIN_M_O_R_G with its current signature, with DOMAIN_RK3576
switched over to the _W form. That also keeps the diff off the macro
every other SoC goes through, which is nicer than what I sent.

One note while I am there: DOMAIN_RK3576 is DOMAIN_M_O_R_G's only
in-tree user, so after this the plain form has no callers left. I will
keep it as you asked; say the word if you would rather it just gained
the parameter after all.

I will also drop the stray whitespace hunk that crept into this patch,
an unrelated blank line removal in rockchip_do_pmu_set_power_domain().

v3 is not out yet. The RK3576 inference bug is still open and I would
rather not respin the series twice, but this is on the list for it.

Thanks,
Jiaxing

  reply	other threads:[~2026-07-30 20:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-18  3:11 [RFC PATCH v2 0/8] accel/rocket: RK3576 NPU (RKNN) enablement Jiaxing Hu
2026-07-18  3:11 ` [RFC PATCH v2 1/8] dt-bindings: npu: rockchip: add rockchip,rk3576-rknn-core Jiaxing Hu
2026-07-18  7:49   ` Krzysztof Kozlowski
2026-07-18  3:11 ` [RFC PATCH v2 2/8] pmdomain/rockchip: add optional per-domain power-on settle delay Jiaxing Hu
2026-07-29 15:20   ` Heiko Stübner
2026-07-30 11:32     ` Jiaxing Hu [this message]
2026-07-30 22:57       ` Heiko Stübner
2026-07-18  3:11 ` [RFC PATCH v2 3/8] pmdomain/rockchip: cycle optional power-domain resets on power-on Jiaxing Hu
2026-07-18  3:11 ` [RFC PATCH v2 4/8] iommu/rockchip: take all DT clocks Jiaxing Hu
2026-07-18  3:11 ` [RFC PATCH v2 5/8] iommu/rockchip: clear stale page faults before enabling stall Jiaxing Hu
2026-07-18  3:11 ` [RFC PATCH v2 6/8] accel/rocket: add RK3576 NPU (RKNN) support Jiaxing Hu
2026-07-21 13:02   ` Alexey Charkov
2026-07-25 12:16     ` Jiaxing Hu
2026-07-26  1:43       ` Jiaxing Hu
2026-07-18  3:11 ` [RFC PATCH v2 7/8] arm64: dts: rockchip: rk3576: add NPU (RKNN) nodes Jiaxing Hu
2026-07-18  3:11 ` [RFC PATCH v2 8/8] arm64: dts: rockchip: rk3576-rock-4d: enable NPU Jiaxing Hu
2026-07-26 15:00 ` [RFC PATCH v2 0/8] accel/rocket: RK3576 NPU (RKNN) enablement Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260730113239.1417912-1-gahing@gahingwoo.com \
    --to=gahing@gahingwoo.com \
    --cc=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=tomeu@tomeuvizoso.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®