From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 686C141DECA for ; Thu, 30 Jul 2026 12:23:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785414205; cv=none; b=O9ZTIlId9S7v7BA27372IULGSykQ+2HG0CFFLP9/hGyzfvt9a2VXM/UKVVgUquOaLX6lyZXEYtcAUh1NwQ2rTkr68hLLqdqK93JWmspaP0naql8cNZc5A5Z6UMdZwrlbQd49/1W29NFZIkvG7PWrz3vAfDcijmqaCSgZP0JCt/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785414205; c=relaxed/simple; bh=J2wmxivQKVYrVgWMn8sB9HSR8s3yk5nPXX0yB3PXo5I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=l5ERYCX1ZD94+uTq8AaY2mVfdXkMi1CFAeQ/ZZ1SZfs8jPHhvs8gbVaqIZtNF5dve+XMkYNIYbWL6BQXyjdmqCf0uab7AL+0vJbGq6ZPjZcY2L9EtrCPuq1KreEldw1qgmvrT9YHl31r4kU6VYy9dMYVSxBpiuNqxDswFjqGZHs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jbvY8dQz; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jbvY8dQz" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-c8612812170so164668a12.2 for ; Thu, 30 Jul 2026 05:23:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785414204; x=1786019004; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=e+6hzrmSQg0II38t+n9rvv6qBh0adksxkagJYoybTiU=; b=jbvY8dQzVI1Nvsaz9UajqV2x6pX/royMFZ6TstlSEdBWuLeAgsn+mJy9jaSeeeruZW Ojj44IIo2Z4/30iOd6WZKqdT4RnYsO0rOtXwgaTkU0qJm+dKpAd/7Wiodp/gixskzae+ 6y57uuhFwhTJCW8JUDSdCawfX47YYRqpSBBogr6OHQRlJDcXx37LdUtS2Jo/eFBs7xVk lV6oHaeUVoXM13e3HAVSAGBJe406LOULvI07N+FHGdlV7XKf2IIB0DDkV0VBbOlChb4d onSetIkARzI5I8YlK53WOTtWD6ArBHbrvH1LVxELGPjWDr4DyiPsZs04ypHprVXpHEE+ APkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785414204; x=1786019004; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=e+6hzrmSQg0II38t+n9rvv6qBh0adksxkagJYoybTiU=; b=rvo4yBtFA5I1fdoUcN9iNwXQ1fMC3cezmG2pQ5BDIwYAeay9Tapfyk+iB3t5V4wU+u ykl0mKRvY4n6IJvRteNlusrN2kaNUCg5IAmM+onyyky1hKCW9JlIt/F9YAWDWKjceoMi /PTVnjFMoIrIP4ve9cXopDC1Y3j65sSEGh+Buiov5KnJp+1js+4SCdB+v3imgy1FgJrn kSb5qF1peHqgk+NiPn7ruAsE7ee12qeiWLSasmDMloChwXGr7lWMNK5ivUNz1odXU8qn h70zpCQYj79b9J04cBYb1U1v77UiPA+JhwSp5tC1Kw5Yw45a5tsjGJIMZpbEw0Mv+yPS o3yw== X-Gm-Message-State: AOJu0Yz+RcdRG72zpSQU8mm8l9QvDeNw6B6fX+v8v4+sN0lr/yJpDoVM hewM6tZ+7QmsmuXD9TG/iImuDjTDRMYwmNBkWLAmf70Xqh6OV6Gd47OO X-Gm-Gg: AR+sD101b3KyTeUCekhRTyAEkc53FPX6k0C6AmASdsORsMI8BFwVoIhC9VfhVuL2IwP MxZ/hPrkku4ZysuUfYOBQ3svnaMu/ioJVsDi8hrl5PT/hNJR8QidqrTqmqwiWFh+w7fx+dj06uJ cRPaTSGsElP7M0PL6y71IuV7EY19P+SqI/xxppIEa2EnTViNw9t1QmG4Vi9SF8J8Yt9O4pwpw2Y Dl93lN+Z05+sohmkhvNkHUDUtQyLgEeW81rBpZ7Hjmc5bBRSkcbFQeQwHbndg+9EQ/3ao0sjYtM hvqpfArrqIJaaGnoTVSwvZavf0z/hEbyr6PIsXVHooQ+HIWaK80cArdrQL3XHNppTpuumep+jD2 OzDaXeJaKCqsDHokK37uqgE78o3AaXlhudd5jpwGkZb1LxtSFj0zK6Q+bcT/G/pJdcnOz5wI1bx BO1/dtkiHTbHxxd47dlf62AUd818Cj5lYFpQGe1n/w4oAlOO7unnTOLqb84+4c1cucSw0xtwIMB zfwa5E7wYBu7qJm87jHqnyeuF+LqHGXzzhBH4dl5KOBVJCV4EsL X-Received: by 2002:a17:90b:47:b0:38e:ab3f:2c99 with SMTP id 98e67ed59e1d1-38f9be63443mr3215947a91.2.1785414203345; Thu, 30 Jul 2026 05:23:23 -0700 (PDT) Received: from debian.lan ([155.117.85.23]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f9b72d243sm995698a91.10.2026.07.30.05.23.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 05:23:22 -0700 (PDT) From: Xueyuan Chen To: akpm@linux-foundation.org, linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, zhaonanzhe@xiaomi.com, baohua@kernel.org, hannes@cmpxchg.org, youngjun.park@lge.com, baolin.wang@linux.alibaba.com, hughd@google.com, chrisl@kernel.org, kasong@tencent.com, shikemeng@huaweicloud.com, nphamcs@gmail.com, baoquan.he@linux.dev, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@kernel.org, ljs@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, qi.zheng@linux.dev, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com Subject: [RFC PATCH v5 0/4] mm: avoid large folio splits when swap is unavailable Date: Thu, 30 Jul 2026 20:23:00 +0800 Message-ID: <20260730122304.2496440-1-xueyuan.chen21@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This is RFC v5 of Barry's original RFC patch, "mm: Avoiding split large folios if swap has no space": https://lore.kernel.org/r/20260618221720.71768-1-baohua@kernel.org Barry's RFC showed the no-swap case with MADV_PAGEOUT on 16KB mTHP: the large-folio split counter increased by 1024 even though no swapout progress was possible. Skipping the split in that case kept the counter at 0. This version keeps that behavior, but makes folio_alloc_swap() classify the failure. The function sees both the swap allocation result and the memcg swap charge result, so callers only split when a smaller folio might still be swapped out. Patch #1 adds page_counter_margin(), a small helper that computes the minimum remaining chargeable space across a page_counter hierarchy. Patch #2 lets folio_alloc_swap() distinguish large-folio swap allocation failures: - -E2BIG: splitting may let smaller folios make progress - -ENOSPC: no global swap space is available - -ENOMEM: splitting is not expected to help, including memcg swap charge failures with no remaining swap capacity Patch #3 makes vmscan split a large folio only when folio_alloc_swap() returns -E2BIG. Other failures keep the existing activation path and avoid destroying the large folio when no smaller part can be backed by swap either. Patch #4 applies the same contract to shmem_writeout(), which previously split a large folio on every folio_alloc_swap() failure. It now enters the split fallback only on -E2BIG; other failures redirty and reactivate the folio as before. RFC v4 -> RFC v5: - Fix Patch #3 to jump to activate_locked, not activate_locked_split, when folio_alloc_swap() fails with an error other than -E2BIG. The folio has not been split in that case, so activate_locked_split would incorrectly adjust nr_scanned and nr_pages as if tail pages had been split out. - https://lore.kernel.org/r/20260730021630.2235914-1-xueyuan.chen21@gmail.com RFC v3 -> RFC v4: - Keep global swap availability and memcg swap margin separate, following feedback from Barry Song, Johannes Weiner, and Youngjun Park. - Handle early rejections and memcg charge failures with the refined folio_alloc_swap() return-value contract. - Apply the requested vmscan and shmem condition layout changes. - https://lore.kernel.org/r/20260717122514.51514-1-xueyuan.chen21@gmail.com RFC v2 -> RFC v3: - Use Johannes Weiner's original page_counter_margin() patch and preserve his authorship. Move the mem_cgroup_get_nr_swap_pages() conversion into Patch #1 so the helper addition remains a pure refactoring. - Add Patch #4 to make shmem_writeout() split large folios only on -E2BIG, as suggested by Baolin Wang. - https://lore.kernel.org/r/20260709145124.764807-1-xueyuan.chen21@gmail.com RFC v1 -> RFC v2: - Split the RFC into helper, swap allocation, and vmscan patches. - Add page_counter_margin() and use it for hierarchical memcg swap capacity checks. - Make folio_alloc_swap() return -E2BIG only when a smaller folio may still be swapped out. - Return -ENOSPC for no global swap space and -ENOMEM when splitting is not expected to help, including memcg swap exhaustion. - Make vmscan split large folios only on -E2BIG from folio_alloc_swap(). Barry Song (Xiaomi) (1): mm/vmscan: avoid pointless large folio splits without swap Johannes Weiner (1): mm: add page_counter_margin() Xueyuan Chen (2): mm: distinguish large folio swap allocation failures mm/shmem: split large folios only on -E2BIG include/linux/page_counter.h | 1 + include/linux/swap.h | 16 ++++++++++---- mm/memcontrol.c | 41 ++++++++++++++++++++++++++++++------ mm/page_counter.c | 20 ++++++++++++++++++ mm/shmem.c | 7 +++--- mm/swapfile.c | 32 +++++++++++++++++++++------- mm/vmscan.c | 7 +++++- 7 files changed, 101 insertions(+), 23 deletions(-) base-commit: c73b725a57f276a3702ca213bde78fca029bc619 -- 2.47.3