From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a7-smtp.messagingengine.com (fout-a7-smtp.messagingengine.com [103.168.172.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9305630EF63 for ; Thu, 30 Jul 2026 13:03:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.150 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785416626; cv=none; b=WcuDQ8Ty3HESQ2G4iBDBSh/4rAYiP1KNCeeNMrnuuZ2CxCDurQzqq3FFBvwkVKxzeqsGhH6Eoq5+/9bEw3x+yWcMIRGwayb1NPvZf4Guft5EMGujKcpVryAbR1hisdLU0LR/RBsiBMDcvLIRaCjDRXrvdB7xhxVJfWJNt58eFxQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785416626; c=relaxed/simple; bh=bUZTR2MOMyftvkgeSSM8OadxPRfkwPIMmDNvme6To10=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=deDLcv3Zp5VspMPEpoXTkmVJTG3qHazgyH9roSCOIu1wcAmlDSWgbI7i70aZ5xYaOmZOsKtULY2JvssIfcvmzSocn0+rFLJKmt5XqLq7sir++WAi81mZbaMzQig2UozoBRlxrxNn5fBAD/vZRMGYLcL5ZmTxIP/7OYp9Ay+5LVw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=o+BLe+GN; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=lHtYY3On; arc=none smtp.client-ip=103.168.172.150 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="o+BLe+GN"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="lHtYY3On" Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.phl.internal (Postfix) with ESMTP id 7526EEC0175; Thu, 30 Jul 2026 09:03:42 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Thu, 30 Jul 2026 09:03:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1785416622; x= 1785503022; bh=+5I29LCMJnWM6oveup8DHXJ4U3alTstiwmg4oOs9t34=; b=o +BLe+GNDnGUl4TuVJTV9mCZBlrZCxxuSUvXiHCZ279/jzgBZhJSN94AQgmGO7++Q evJ9Q1wQgUZCNR4tYf+FqMq70EJVGv+cYBmtj32i6Qca9BYd9mLjmg0hKJxvV6Hb kdCJIc4ytgtLrTk1q7XzhMyobz3hnZn8Tf0p4Y5TRgg7IoiygHbNMQ45mKUG4OhJ jTdeX2uZ+qxCo7jvrR2nOam0gCGQaUp70zYaP9eUD9EZ7voww6zsRV1Dcq3iMFhX GCRO7I0YPiWXtAVmpneNlOG19IQhxopl00ck7QwNyl7ST4OxvAPrOFMxS8gVGXH8 XCGBkS0+e+Wk8tqO5e/Hg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1785416622; x=1785503022; bh=+5I29LCMJnWM6oveup8DHXJ4U3alTstiwmg 4oOs9t34=; b=lHtYY3OnkYrN9QSjzShdLmDUpSbsiCBSHE5cRfh9RF1j5rObXzQ z+oJec/bTt4BkcpXZjWPWxql3H7VT1NCDcEUZA1NrH4MOfcZkrNMxZBBWLPRnRAi B5uQBokwgefXCNofY7350Ijnhy/6XQOEqf94V1166F4GXpsLa5Fx3u2S/kceEIAI R5EDpC8MGHpBf0BC3L7FZLrnWNOvZNwwhTWUAWNO/0RqlXPZUS68Swkckw5ykSWW cnZBeC6bh5nCe6F9ME9vbwBZe80p8qWbkE7GkOWeIIC6h7ByVhnp/JjWpjEjPq8j flqeHVP8katAKsdgn7f4g0XthnH++4MQhHA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGPUS7MHfzNSL5zYin0acDYO8LtCTPtC4nNZmIFWAOATUC/xJg9bnIzQnvRXoev1i 5mIw97didxQRa2MLFNjc0v2wwOXe2AReTBqvjBe6Xp6QZo7TDC105tgpqSQm5gY+uiTYuy yGwgPIPOgCuzDLshSu6bfi58yiu0azcGsiPwAiWDzIikXlkU9hpNn1XmFdzDamkjfIAAJC /sBMBn17OHBx6tJR2AAh8c0xE9ZCTCEMDLBdQqdKWWrKrPO3ZEYSMgQaS8nXfAkmi+XiP1 H8Ug3mSPDmPZ3+/4KaixacQ7PPhVkYRMyeFuBBjUxb3s3ySljvCdBm3e2cTIgg7kvuXrNH bo+vfTn6Y7PgJqqdDfLgHGDKa3qnM//MPC6MSdhU0X5eU50CVaP13k9LR8WZhWBNaDwD0g fhZk76s119cbQDlV6KDqGSLhCMq2pf01ce6KGBEBfIC6Aop/gSuVuYWb8cWq8bYmVnc61H b1Rxi9PIt8J6aK48SwR9q3gR2NdD+6ft+MFF6XlRhITAdsjDRLMAfGNORFfgfxPCRfqSR/ S501H7Sc6GGGDec5QcbdYzezWeVoyUSlaUvgyU0wHgUcbQ+6UAVZjUVDmmwBV2UEAFhKcw cgj9O7UbKK4eB+tgbFj+JKB4Q6qoTdOvhwU5nqUCOz4Ik/9kP1BDrM4YTWLw X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 30 Jul 2026 09:03:41 -0400 (EDT) Date: Thu, 30 Jul 2026 22:03:38 +0900 From: Takashi Sakamoto To: Sreeraj S Kurup Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/2] firewire: core: validate descriptor and sub-block lengths in fw_core_add_descriptor() Message-ID: <20260730130338.GA276250@sakamocchi.jp> Mail-Followup-To: Sreeraj S Kurup , linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20260727174231.2816-1-sreekuttan2156239@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260727174231.2816-1-sreekuttan2156239@gmail.com> Hi, On Mon, Jul 27, 2026 at 05:42:31PM +0000, Sreeraj S Kurup wrote: > Hi Takashi, > > Thanks for applying the series to the for-next branch! > > Regarding the change in generate_config_rom(): > > I dropped that specific change from this patchset to keep the series > strictly focused on the out-of-bounds issue in fw_core_add_descriptor(). > > `WARN_ON(j != config_rom_length)` acts as an assertion that the ROM block > traversal matched the expected length. Replacing it with pr_warn() and > clamping `config_rom_length = j` avoids a kernel warning splat, but if > j != config_rom_length occurs, it indicates an unexpected state during > ROM generation rather than a standard runtime condition. > > If you feel handling length mismatches gracefully via pr_warn() and updating > config_rom_length is preferred over the WARN_ON assertion, I would be happy > to send a follow-up patch for it. Hm. The case that j does not equals to config_rom_length seems to be a programming mistake and should be fixed immediately. So let me leave it as is without any mitigation. Thanks Takashi Sakamoto