From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55FE242642D for ; Thu, 30 Jul 2026 14:06:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785420403; cv=none; b=PysNFJgKwx/GuyzeRO3Alrxmdk9oDMO8ClFtKBoIBy55Q+RIdEK1z3WoIu06GZ/gxgqzEzXF0vYUhl7NqhkcS8hq4lVf+oewJmETEQUOZxmi4lXHoBNKuvxK2etLXFT2Kd4L2gjwMA+Nhh1l9jm/AF4mXF7MOgq9E5J5TluuAiE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785420403; c=relaxed/simple; bh=ALckN1nV5wzz8cd6PQjathMwp9PWXp/GbdcbSmSLNEQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T3J3gRqgUlO4qL11qeg0S0cZxZnxg6DoMXf54KBDt5+IqxQTN/OSF87G8YnwvhOMuqoFg3v9r2wNJUI/bvO2DxEgtG9oYPtUc/87GDBIp7b6LbjH8wIk1hkFO1fZ9x7Dw834Dlomj+niqkRBw8249AqhIsc1nxmsS23sRA4wfqc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PioGqGcM; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PioGqGcM" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-ca957432c7fso1626766a12.1 for ; Thu, 30 Jul 2026 07:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785420402; x=1786025202; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hJ72M8reVIZqxbhzSXS1Mi2+37hAcyZSuGI4YdKYzKM=; b=PioGqGcMKNkLX29ZrJEJQQR1aMICZ/Yn5eliNSp6LBJmsKOtJL1bkBu6vikLLHAeq7 fB6Lj6iRGX9BMJF+J0BdnF+uNu8/u8ENJybxX0ser1dMc4T5rA1NFK4WqolvlPF1XLHZ YPHm3he7b4Krk24S431jyuax2vSCBkKEF9kjohRrn71HfipBx7zkw6qR+a0yeYF2IrU1 0J5W97vc9TJMos7vzc/UTG8yetBjrzVGuzlSTykWl3+mIKaAK8y6hCXnhwtJSe33VpVA EQrljezOz8Qqu2Ha0GC3D3hPGm11D5ssKc+/t1IeRcNG7AqOpuZJ7LI0v7QdHSE+vPqc OE+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785420402; x=1786025202; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=hJ72M8reVIZqxbhzSXS1Mi2+37hAcyZSuGI4YdKYzKM=; b=AS0DEpZS1/r1FoE58inHS2kplhpTgK2tkodXy1NLWe4vglF3ssNv0yPO4KIlyrj3Cy m9lTyL4EQGMtmxN5yZcHm6oMrdLuWgL5hGDm67m9JTCc8RMmSFKmOlG70R4deLH9qMSc GsnLX/SqzRV76OiqMIUS7zBTYQD2KQHCLe+RmkYHfrwpAGPCNDudOySrWKlJ3Qd3Jsva coqGB3wk21YBjB7lIZ83NRbDZqFf8XpPAjG+QryjrOIP4oC/V5FBl/+qjVlS1lpDxt0C EvJRimjY1vYK5ejzufiI3BbIhEL1Kc3FaGkZ0WFp1uE952dO/gbRaB3+TbVAndexyubt Y8uQ== X-Forwarded-Encrypted: i=1; AHgh+RoCkGos+g8T6FCp2nOjlJcSXfXa8+2xxDfoPjbeajBuMXD9Wg6ZiWLXukWYSiPcCGCLD/ln8X+5R2re9x0=@vger.kernel.org X-Gm-Message-State: AOJu0YzPYbXiB6xDLG5DBWg4xKEoTh1+fsz3YpoVTwRMMvpfDNjRp6r5 wuaMdnEGHM/ye+E+tw2QDKh0T3aDMUA5ifXLiTfvmXgOv1TQq4Vn6Inc X-Gm-Gg: AR+sD11uFZih+R3F4hZh1ldFP6AS7s2TccL9Y9jZPGH/U5VxJb6HupGqCj6+W1qfmsP 9H3A3xEQvxor++lbQqIcNl7ixZiV5C2rILBwObdxfpJGIyNqcR814xgCSjwzJ/A/NwMz7Sv1lli SdW6Pf1b88qGD1offnuR3IaST9xPqibTbiyurVhlYzUXTcQga1Z2P1DBT8Pp74GOH2H2fVEKRb3 ZnhQO3SOsmNQyED4hGSONDRL5mdwxeWP/5RiH6veq+NmjlaOYHRDlFPbKqn/4cf+tKj5w6/ULgT r2YwncFJI+jtHewYGEpLXu/QFu8NrTw+NSVocsInieh+ZrH/vFhNWoSDhZNiT3v9udFEBh2wvqP 4jbBWPhdBVJuPi5gIkoBbFwRioeVI7XbIL8QPgGKJuhJnrbFaJ+haKJMGpxEv+kEKt4cBfCFCIz nmkr0JDjWGDwbe9ydQCMwE/uBZEGIUhzgWkZw1Sa9HMToAVI93tdhgy1AN5DfL9yzYPxgNwEQ= X-Received: by 2002:a05:6a20:7346:b0:3bf:d0c8:2aa4 with SMTP id adf61e73a8af0-3c90067d9a9mr2533292637.8.1785420401598; Thu, 30 Jul 2026 07:06:41 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:5fd6:849a:c1fd:20ef]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31504b15f77sm23551069eec.4.2026.07.30.07.06.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 07:06:41 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Andy Shevchenko , Broadcom internal kernel review list , David Lechner , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Mohammad Shahid , =?UTF-8?q?Nuno=20S=C3=A1?= , Ray Jui , Scott Branden Subject: [PATCH v2] iio: adc: bcm_iproc_adc: Convert probe() to use dev_err_probe() Date: Thu, 30 Jul 2026 19:32:45 +0530 Message-ID: <20260730140405.369634-2-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260730140405.369634-1-mdshahid03@gmail.com> References: <20260727034009.5c6b0be9@jic23-huawei> <20260730140405.369634-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mohammad Shahid Replace open-coded probe error handling with dev_err_probe() for resource acquisition and initialization failures. This simplifies the error paths, avoids repetitive error handling, and automatically suppresses duplicate messages when -EPROBE_DEFER is returned while preserving the existing error messages. Also remove the redundant error message after iproc_adc_enable(), allowing the error to be propagated without additional logging. Signed-off-by: Mohammad Shahid --- v2: - Convert remaining probe error paths to use dev_err_probe(). - Remove redundant error message after iproc_adc_enable() drivers/iio/adc/bcm_iproc_adc.c | 52 +++++++++++++++------------------ 1 file changed, 24 insertions(+), 28 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c index cf4738b16e62..08e056468d8e 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -522,52 +522,48 @@ static int iproc_adc_probe(struct platform_device *pdev) adc_priv->regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "adc-syscon"); - if (IS_ERR(adc_priv->regmap)) { - dev_err(&pdev->dev, "failed to get handle for tsc syscon\n"); - ret = PTR_ERR(adc_priv->regmap); - return ret; - } + if (IS_ERR(adc_priv->regmap)) + return dev_err_probe(&pdev->dev, + PTR_ERR(adc_priv->regmap), + "failed to get handle for tsc syscon\n"); adc_priv->adc_clk = devm_clk_get(&pdev->dev, "tsc_clk"); - if (IS_ERR(adc_priv->adc_clk)) { - dev_err(&pdev->dev, - "failed getting clock tsc_clk\n"); - ret = PTR_ERR(adc_priv->adc_clk); - return ret; - } + if (IS_ERR(adc_priv->adc_clk)) + return dev_err_probe(&pdev->dev, + PTR_ERR(adc_priv->adc_clk), + "failed getting clock tsc_clk\n"); adc_priv->irqno = platform_get_irq(pdev, 0); if (adc_priv->irqno < 0) - return adc_priv->irqno; + return dev_err_probe(&pdev->dev, + adc_priv->irqno, + "failed to get IRQ\n"); ret = regmap_clear_bits(adc_priv->regmap, IPROC_REGCTL2, IPROC_ADC_AUXIN_SCAN_ENA); - if (ret) { - dev_err(&pdev->dev, "failed to write IPROC_REGCTL2 %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, + ret, + "failed to write IPROC_REGCTL2\n"); ret = devm_request_threaded_irq(&pdev->dev, adc_priv->irqno, iproc_adc_interrupt_handler, iproc_adc_interrupt_thread, IRQF_SHARED, "iproc-adc", indio_dev); - if (ret) { - dev_err(&pdev->dev, "request_irq error %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, + ret, + "failed to request IRQ\n"); ret = clk_prepare_enable(adc_priv->adc_clk); - if (ret) { - dev_err(&pdev->dev, - "clk_prepare_enable failed %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, + ret, + "failed to enable clock\n"); ret = iproc_adc_enable(indio_dev); - if (ret) { - dev_err(&pdev->dev, "failed to enable adc %d\n", ret); + if (ret) goto err_adc_enable; - } indio_dev->name = "iproc-static-adc"; indio_dev->info = &iproc_adc_iio_info; -- 2.43.0