From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E470442FDA for ; Thu, 30 Jul 2026 14:56:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785423361; cv=none; b=ZPfXM9qSD+Aws7etgTEOy2OA9B4StQ2vi8mVAHZtGm/wYtJ1+zNIBPf0J7gnrkXJSRd7mjnr5rsJftHcnLTBmI+vjRg2zR9JS5UqwZAHyJVOuq1LypnQ+5e0NG+XjDyGW4petjqIdxfzFDVMxl+56gHsIp90wbEga8G7X5l6aiE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785423361; c=relaxed/simple; bh=6d6a6opuXTN9H4VHkMA8Ovce9yM3y41HUy6w/yHPAHY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NPxUg6Y6Nn5+EG+h7DSPFOBXEN7sZdIb+SnWmDxUNFTewiJ/DKzsii/mFAg/0FiAaq3j6tqD/B19oX+XERNlZ5Qp2kxKQaXA4gtt8CJqnDNWnoSmYa468lKQ2jBDfVl8ba13FOcUEsY5UIUsOT8Iih9p0lAGPUViZCGMSZDpORs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MCXeRynh; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MCXeRynh" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-47f7854678bso1211692f8f.3 for ; Thu, 30 Jul 2026 07:56:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785423359; x=1786028159; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=putRlIHUpdFyZ3nmd/q6KtU72HQBPLS010r6rfjazVQ=; b=MCXeRynhCeRGOodQOZPv8+5fHz7mynwvc5itvX/GoafMRL/rbyC1xjJixY0ZUCGoYX HLsJQi2K7C2PBZV43/Nf8f8fUgl0MOBoEnOC7bYZv7Ae/nROp4VnlesXAO2UGrvra5nu db51xcym11Qzo+i8UWsrps7FjgnPBgXfgwfAkcxRcDos92Gfiz4KuFA/C0r01Og/zPra 7bkPOUAznmTdp4u4S/D/oL9b766hej4CBmBsZKqSY6j6y4ceIL1wtnbtRuNgscF3+1d7 oPb0RCQyPJa9myRgS9YalcdTP9hEypeFB2miPnFV0KchnkwdHOOpXZu3/3PRjJuSxKaQ xL6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785423359; x=1786028159; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=putRlIHUpdFyZ3nmd/q6KtU72HQBPLS010r6rfjazVQ=; b=jjpDIWNM7AKSPUwxwxRJAV9tLKkj5HQTWG7bD7qeNE+iLtHT5vfkoQJdgITxJRQ4zo X+f7xoBrb4dw26syAls3lkDHQvW9xzaPzfZL4zfnJ0k2ELuTeiteJG+7k9sP9JWuLJMH Kl7PAfBV0I7uZaVRClkHHbgLaxleBgi+Vz0KW/ziiBu66GGcCqcqSgdC36HsixiI3eYW 4eHhlMaZoZA7WkB9om9pvdwsriApZl6Jro0y/jjlZ5gYZT3a5J77uPxp3ogxkGqFJwB8 wtR+MurOWXgpAXcmoTUoZ2Io7naxmHUlglmpDI/fLxxq4mLqQGL1OO28009wG4PexwtB nttA== X-Gm-Message-State: AOJu0YwN5d5AYi7D1T1GTbawmC4RueJpaMXWtxaromkjW8VfOVSgDcDR JpeEgnsEYQKNfmQ9jeFTxwi5GOy58PQjHWOm5OR9cN8uMMta4V3DeFV/ X-Gm-Gg: AR+sD11EI0QbCD7xvwYE9DOZ2QzKoAKLT4Ytk9qbli0lcwZWspvs90GscauriSyzB8T XWEWTOCHmm2yywCPISEpvZK0K2TAPAHJbQmopwChCIdklYCtZn/dkrTIQcsIklctqL2xHlS1voQ D3o8VSNdg/ecCVJSvNSgfe8sJXyOWmu+3ilRID1sTDaZ3I1NrgP9UrSpws2dlEjJ28seA99QSDn VIx6irbEYTzNUngy9VeDixZc6c0jdTM6m2eaCBmMgWdSHKbbsR6FiMWmfm50R8vPamKpMOcjKSD lanhMu5+V4/c93OQ3rjYVZy+A3UL7J9OuMVxoIK9vGgT8I3rQVCAbz+6x6J8kyuh/NfZ+Eiu6i4 LvZgD5MbYi9KHnZ223j3kustaXy+FnmdB8qe0eSPU+zH+VP2X01CSHuYxKxisWrVNCPTG6igU38 w1zuG0wnjFJiP7tJxiJUxEMiurEQ4FX+EFzLW8Jm4xo6W1JBYMa67i5ufw+Rj/H6h7uWyB+E39T FWDsfsOb/BaeXZfk+rYI8Vwvqo+YweJZdgD+o8wYg== X-Received: by 2002:a05:6000:420f:b0:47f:959f:f69c with SMTP id ffacd0b85a97d-47fc81ed15bmr4314815f8f.7.1785423358350; Thu, 30 Jul 2026 07:55:58 -0700 (PDT) Received: from fedora ([105.190.201.81]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fc88d985csm7257138f8f.1.2026.07.30.07.55.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 07:55:57 -0700 (PDT) From: Jad Keskes To: linux-edac@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Borislav Petkov , Mauro Carvalho Chehab , Tony Luck , James Morse , Robert Richter , Jad Keskes Subject: [PATCH 1/2] EDAC/device_sysfs: Use kstrtouint for poll_msec to prevent truncation Date: Thu, 30 Jul 2026 15:55:48 +0100 Message-ID: <20260730145549.148229-1-inasj268@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The poll_msec sysfs store uses simple_strtoul() which accepts an unsigned long, but the target field (poll_msec) is unsigned int. On 64-bit systems, a value > UINT_MAX is silently truncated when stored. Fix the mismatch by using kstrtouint() instead. This rejects values > UINT_MAX at parse time, making truncation impossible. Also add a check for value < 1 to reject the 0-delay case, which would cause the poll work to spin without delay and consume 100% CPU. Fixes: e27e3dac6517 ("drivers/edac: add edac_device class") Signed-off-by: Jad Keskes --- drivers/edac/edac_device_sysfs.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/edac/edac_device_sysfs.c b/drivers/edac/edac_device_sysfs.c index ac678b4a21fc..e2ee5c6c56d3 100644 --- a/drivers/edac/edac_device_sysfs.c +++ b/drivers/edac/edac_device_sysfs.c @@ -90,14 +90,21 @@ static ssize_t edac_device_ctl_poll_msec_store(struct edac_device_ctl_info *ctl_info, const char *data, size_t count) { - unsigned long value; + unsigned int value; + int ret; /* get the value and enforce that it is non-zero, must be at least * one millisecond for the delay period, between scans * Then cancel last outstanding delay for the work request * and set a new one. */ - value = simple_strtoul(data, NULL, 0); + ret = kstrtouint(data, 0, &value); + if (ret < 0) + return ret; + + if (value < 1) + return -EINVAL; + edac_device_reset_delay_period(ctl_info, value); return count; -- 2.55.0