From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3681D468C29 for ; Thu, 30 Jul 2026 16:04:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785427492; cv=none; b=LSUmDckNLl/wg2rauGNlwQO7gD2PXuCcL3f4ezWoFqPyvR75svlMpEQ1ZklLciMmm3nH7H+YIDIPGwedV6zc4/CAvog9RHqaIhbw0+DBCEyMhwm1k3/8y4jIISTYhbDEaudWg8AeEnrqEVghrHwuqpDbeFoIcSO2SC/GAChaG7w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785427492; c=relaxed/simple; bh=Ha19f45cKy4P+0OsFEr+btZcY5O+YERSKZjpgYlX3f8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DtQcqcR5FSr/QhR+hkTDoSeltn2N4zazMx+89KjRcnt9d/FFbBIcFphVxt2Iv7uHs9Kt7eBNkvteRyvWxsSOqTElTnz4wMGdE0mZ2p+KvaJB2DZa0ipWMY+itfBgtUG/vIgNxIWeYRHCsBngu7fpg57+T2lJC+VKGZExHe4mnWo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=o5EX2o8V; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o5EX2o8V" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-38eca09faa2so3732a91.3 for ; Thu, 30 Jul 2026 09:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785427490; x=1786032290; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Ts4xsj5jidC5xPXZCTNfYevbfQH6viS7Pn42+gUfDKI=; b=o5EX2o8VAdONPSgoi8ITux+jlge/VzCXlCy1pQnLbXSfA5JVJd5VUkj+PtXGbD41QM sUxIzXSh5q4R0B56h5BGp8l2CzOtFOzAxOVojuahVlPdAn4Npj9LBhyQBAZL3V7T2vOH ESqLnka1R9czPN6HRkTZsFEpTVCOnB7hrJSowzYcZ7vg7O5wdDzMrT6bauedPJIwEfPi MQjhWK4ruuITEmutrNiYVeC5VPM6h9ULxjamIdW8qH+edj4N2jsYGvsIyPdOCm/Qw5Pe OqPrEtqWLx382J//tEVnDMdZaGJPbZ9TVyPLrlKyCrM1pOVhO1hl0GYNhUJ2JvarB2eX mHEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785427490; x=1786032290; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Ts4xsj5jidC5xPXZCTNfYevbfQH6viS7Pn42+gUfDKI=; b=Bgaoq43KpyPEVDQtiv/Eft+K78krQEnXaLXnCY5pLtYSA6EsTByfwa8WUyphpCUXHR 0yHvXPrIYXP0QigG+9sH8zeRyjHmJnyXw04s1WCtO54N9SFt/BVB4UZS/vNweqYtyx1F obo6ueAJe8gB2htP1pcwoMZSD85lYhTuLf/VuhCPChcwpdc5xFlwXtL9zyG9HSWhoXwE srk18qfzSeH2CF7BcqS6RnC1NAwMqEJVTpftEl1wIPB9wuwWFehJ/ChovVOZ0il0Mi8m fMpmrGbsUmI5tgIXWsVdmvVGbL+Rn6iHYwDR54wpa8dn5mjmWh31GUCdtcbpZKJKx/Zb 5njw== X-Forwarded-Encrypted: i=1; AHgh+Rq0Mbc042kBuohd/nJQqAXxgrk9IS85yBcLBfF0EJ5K5M4iZ8E8uzmXrGxkrFNVw2wAbG1fx1owUCKuN0w=@vger.kernel.org X-Gm-Message-State: AOJu0YwPHWI9SfSvovgO3PIpKRiiwK91SO7LtqyUNUs2EBmfytO04run 99eSPpxULPkYBPqi5uwNSPrKK57JWEP65Zp0TS8HoEWXfJvOcwnI6Mys X-Gm-Gg: AR+sD13uJERRLyz7lG8fZ0y7ywobvLAqs3F7bruYdR47v2ne7nvP4T9HNqAWb8Hh4fv eDlGqe/kJHD6XVpHUODAQNtZwnwr+K7/6cLQer2Vm1MCwz/cYiM2CQvOghS/htBnHrWI67g1pQv C9bHWX7JJnBstvZ44AmiuxaR5RnRqcOAJ9KPkeazvIWXV3bg5Tl8sjDVAkKygvaM361h77WunDN z7mEwEtFrMQKNRUtm6Vo9zv3R/nUGOtx2P84rJoT7gqCAHNdaSJqeirb0ZyUzshF+s8icPN1G+W YkbNSD5Xrqr1RVI0lBptrM/7piM0fq2TgzMvH0chnJn/e6qLi4vG+jf+BjvrOVRMSNRsBnz1wZK uQxmNiPH2KzP1b6WFGkSV5gwWhW7i+nAhM1bIdlEGBv99IUjyn8WQanoivJrpzpHhgkXy/Nj/CN gAM/jTruyfs1flhaANHRKGb7Mry21l4zRLu2g/vBcz0OjaHIIxthCX7K4xxNai4qLNP2h7mhlyK FM= X-Received: by 2002:a17:90b:1f82:b0:38e:6d4c:14df with SMTP id 98e67ed59e1d1-38fa7f26f3cmr902246a91.1.1785427490492; Thu, 30 Jul 2026 09:04:50 -0700 (PDT) Received: from Potato.tail66a299.ts.net ([171.76.83.76]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13e72643a12sm35012783c88.5.2026.07.30.09.04.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 09:04:50 -0700 (PDT) From: Shivesh X-Google-Original-From: Shivesh To: arend.vanspriel@broadcom.com Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, Shivesh Subject: [PATCH 7/8] wifi: brcmfmac: fwsignal: safe no-op on duplicate MAC add Date: Thu, 30 Jul 2026 16:03:55 +0000 Message-ID: <20260730160425.11933-7-shivesh@example.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260730160425.11933-1-shivesh@example.com> References: <20260730160425.11933-1-shivesh@example.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Removes technical debt TODO by safely ignoring duplicate MAC handle ADD events from firmware. Signed-off-by: Shivesh --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c index a43f1a38b0e3..3c1ca355e8ee 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c @@ -1037,7 +1037,9 @@ int brcmf_fws_macdesc_indicate(struct brcmf_fws_info *fws, u8 type, u8 *data) } else { brcmf_dbg(TRACE, "use existing\n"); WARN_ON(entry->mac_handle != mac_handle); - /* TODO: what should we do here: continue, reinit, .. */ + /* Firmware re-sent ADD for the same MAC handle. + * No action required; it is a safe no-op. + */ } } return 0; -- 2.53.0