From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72D81448BBE for ; Thu, 30 Jul 2026 16:21:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785428506; cv=none; b=cylBnNzv/ssBUhqjmrnx8Ntui6lv1/w6ZT5g5JTJJYuev0oIq5g+SU+PdGAA5GeRtBlGya3ghQTkipZOce7zUu9x+cGhaAr5wVncyfTxmUNXEpgEZzv7tX1wSy9BWbIdFfZFpxntBWo8Vs5n7Akf37/gwAsIiV1GwU+I1eeI1yg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785428506; c=relaxed/simple; bh=Hdwf42WICGC+EP1O8Z+0XvId2aI97zszyMJuW5ia80Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hftORPDmGSoNLsoqZgiVVgL4PPbiCSpWvIw22jj0JtYjo7o+6X3hHHB/MQQzJULow27fHRXdGwuJx47HvUKtn8lVIgk9HBmPdeKA2+3V4CocR+6vJC3iRlki4yO+P4M67a7PaiFO4XpRxPCkfqk/KaK2EIDG9AHMwfXEvu8r+OE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EX66aCNw; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EX66aCNw" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-38115bbb83dso3800a91.3 for ; Thu, 30 Jul 2026 09:21:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785428505; x=1786033305; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Yd5GnMV4YHUFaBqZ8HhG5oCdvPmPlqZROl7g2jgvDNU=; b=EX66aCNwRqYT6TFJGmBEZp9ZvfTZGKa3fl6cfr3IMViwe2CYvMkywOstQSq8EzY1dJ oQXcCMYgdqqGQxV5ILXzyNlXv7zw0Y8uIT4YE7b2X8mq3dxLVpzw0pBEH5H3cJbe0e1y BlQW7UPAf8lUYKAytjIpuTKK/dOFEdW4TDXEJc8NDs9U2uuQtid7Rm5bdZ9EMyA+1onx shUcqMwFUgiBV6LuyE7GvD0Jtrhp3cdxh33GOL+ToNN24zYnVwr4evWoLowR7wsJM7RQ Bj5LAsx98V9yvlpNp3fk5HDT7SHPUm75JETjWPHI5TIwucCTFwFenPg3tbWUCQgzwRxQ 5GbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785428505; x=1786033305; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Yd5GnMV4YHUFaBqZ8HhG5oCdvPmPlqZROl7g2jgvDNU=; b=cwDBpaUyfc5JBduJhQRTfeTmwhjzYB0TmSkmbnwx7f5wS3Uaoq/PqxRonstspNZbal 0/qpm60/Xp6xXHr5hBg6H+/N04yADZ8x4vrkN/FfuzvxDEXVztMKYhUCWQlegGOVO8FR Hr/k9pAcI7a0MwpG922l3DLlD6DC+ifEOg725MsKFMIAFch0F/zFELnUNSio3yFK6PlW Qr8lTJd8LjtXtBuNi0Dm6awG8rR6lK/WsxbIocL6hgbu00tBHl6BK3AI9VgwkRvPAHyv qxj8SISPrA9GvXrqEWupnH0nRuc/fEnXo7hkfLFQbTOOa4bkUk180ceoWVEMsTdI+Fm/ TGVw== X-Forwarded-Encrypted: i=1; AHgh+Rqlt0rcHBl2wSw0akqf6BjJ/C4GC5H9Gtbyp+0rHY8oUX552yle4kM/WL7eKDmJglAw2xjNlqBv7o/q0mw=@vger.kernel.org X-Gm-Message-State: AOJu0YzjcFTYNh7lyGAKTMROaEaQs/y0sWYnq79wL7QMr3x6eU1Siwtd k+Xby2nSiY9YvSWbUL+/htteMy7MG95YFzxt2eRc4ooVraIvi8Ph6x7y X-Gm-Gg: AR+sD10vG1JBY8uFfVTQWrxi2qae4jSIXh5LeLOPMQ9z1ICy8DIoAc0OrAn+kMUzYgG SYIBj/JugWl7vw0TIeHxgBCpJHlCw1jBOpUr40JDttdZvXehcT2KTKU3xpb2/FC28cVW+aqtp37 MrjIpPiqIIU45kngWtRS7ThEaHU7K1479nTp436UlcKQHbfl+sqwb1t3Q49jZUdlU97I9JzrKnl 4CngndmzwggJgJxw2t0hf1p8jLpVVLiMJOi1cO2ZevgHT19xLYrdwuAc8d1o8ASBcl8HP6+avBY wrTOQPzvl6C76CSXRuLgIkd2QQ29tRIFi1CNr5wdTm8z1MSIv9L/NsaX7jCbhd4qJq3ShWybjFX VTvR+/ycQsfWa7aRDQ5gqgE+1p6MaaVgNx7qyb9KBoIOPoQpWE7IYVl/uHM6K/4Dps/NGIvmQTP 6dEF8EdR2oSSO5ML4vMR3AxX1OAue5r2BxDwuideXL7MKir4s6PUIuqEdYUY/umE71BmZ8zB+S+ 64= X-Received: by 2002:a17:90b:3c50:b0:38e:549:9e04 with SMTP id 98e67ed59e1d1-38fa7f28d64mr892779a91.1.1785428504732; Thu, 30 Jul 2026 09:21:44 -0700 (PDT) Received: from Potato.tail66a299.ts.net ([171.76.83.76]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13e7275973dsm19964269c88.15.2026.07.30.09.21.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 09:21:44 -0700 (PDT) From: Shivesh X-Google-Original-From: Shivesh To: arend.vanspriel@broadcom.com Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, Shivesh Subject: [PATCH v2 2/8] wifi: brcmfmac: sdio: coalesce host locks in rx path Date: Thu, 30 Jul 2026 16:21:05 +0000 Message-ID: <20260730162135.12278-2-shivesh@example.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260730162135.12278-1-shivesh@example.com> References: <20260730162135.12278-1-shivesh@example.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Shivesh Tightens host claim scope to only cover hdparse calls, avoiding unnecessary blocking during skb manipulation. Signed-off-by: Shivesh --- .../broadcom/brcm80211/brcmfmac/sdio.c | 62 ++++++++++++------- 1 file changed, 38 insertions(+), 24 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c index b725c64e5b5c..4e414403d747 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c @@ -1645,37 +1645,43 @@ static u8 brcmf_sdio_rxglom(struct brcmf_sdio *bus, u8 rxseq) rd_new.seq_num = rxseq; rd_new.len = dlen; + + /* + * Claim the host once for the entire header-parsing phase. + * + * brcmf_sdio_hdparse() operates on data already in host + * memory, but may call brcmf_sdio_rxfail() on error, which + * writes SDIO Func1 registers and therefore requires the + * host to be claimed. + * + * skb_pull() and the num counter are pure host-memory + * operations; keep them outside the lock to minimise the + * hold time. Both hdparse calls (superframe header and + * each subframe header) are grouped under a single claim/ + * release, replacing the original N+1 separate pairs. + */ sdio_claim_host(bus->sdiodev->func1); errcode = brcmf_sdio_hdparse(bus, pfirst->data, &rd_new, BRCMF_SDIO_FT_SUPER); - sdio_release_host(bus->sdiodev->func1); - bus->cur_read.len = rd_new.len_nxtfrm << 4; - - /* Remove superframe header, remember offset */ - skb_pull(pfirst, rd_new.dat_offset); - num = 0; - - /* Validate all the subframe headers */ - skb_queue_walk(&bus->glom, pnext) { - /* leave when invalid subframe is found */ - if (errcode) - break; - rd_new.len = pnext->len; - rd_new.seq_num = rxseq++; - sdio_claim_host(bus->sdiodev->func1); - errcode = brcmf_sdio_hdparse(bus, pnext->data, &rd_new, - BRCMF_SDIO_FT_SUB); - sdio_release_host(bus->sdiodev->func1); - brcmf_dbg_hex_dump(BRCMF_GLOM_ON(), - pnext->data, 32, "subframe:\n"); - - num++; + /* Validate all the subframe headers while host is claimed */ + if (!errcode) { + skb_queue_walk(&bus->glom, pnext) { + rd_new.len = pnext->len; + rd_new.seq_num = rxseq++; + errcode = brcmf_sdio_hdparse(bus, pnext->data, + &rd_new, + BRCMF_SDIO_FT_SUB); + brcmf_dbg_hex_dump(BRCMF_GLOM_ON(), + pnext->data, 32, + "subframe:\n"); + if (errcode) + break; + } } if (errcode) { - /* Terminate frame on error */ - sdio_claim_host(bus->sdiodev->func1); + /* Terminate frame on error, still holding the host */ brcmf_sdio_rxfail(bus, true, false); bus->sdcnt.rxglomfail++; brcmf_sdio_free_glom(bus); @@ -1683,6 +1689,14 @@ static u8 brcmf_sdio_rxglom(struct brcmf_sdio *bus, u8 rxseq) bus->cur_read.len = 0; return 0; } + sdio_release_host(bus->sdiodev->func1); + + /* Host released; now do the pure-memory bookkeeping */ + bus->cur_read.len = rd_new.len_nxtfrm << 4; + + /* Remove superframe header, remember offset */ + skb_pull(pfirst, rd_new.dat_offset); + num = 0; /* Basic SD framing looks ok - process each packet (header) */ -- 2.53.0