From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4632446C4A4 for ; Thu, 30 Jul 2026 16:22:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785428527; cv=none; b=idbsLtf5OLEyhhX/ZHRntuW8D555L9RrGnBZT9+7oWCXrJ7O28GnaFJC3t6BtrV4CAdxvJ8qCh/NoEDrM2+a76yofkyj6m5ftoNeC4SH+8uA8Ve1NfsmgEKCIVVzeo1YaR6O2sOYmJ55vUlsKOp6nAaOy9cVYiZEFnAaEoZ+3wU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785428527; c=relaxed/simple; bh=/RZ3/Y/ZlOJg5G1yVeQGiGHh8zDUuB5gPSaN4Pn9iwc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MNq2Q4PJg2L6+EVe+v3ozue7U9G/LeQ0QflQTaRLApktElUSJQIdRR79Zl5Fb85t1HdoMeHQYs4aHU98ZV5O9gC6n0JnVVmXYB59RswfUE3xT/Xt8nKGFM7m6LX+6Z4X7mPXkEuJQ0us4bAgnubcSvUwa8Tp3x+X2cIV90qv9WQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dph8ZKDY; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dph8ZKDY" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-38115bbb83dso3838a91.3 for ; Thu, 30 Jul 2026 09:22:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785428524; x=1786033324; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rtE+fcyTa/nEHTvbkkFzvfqX94g1NeErZWdBjlXHpz8=; b=dph8ZKDYRaGxNX4AQpz2GGas0vgBCvSOq8+T8Y6s6sEGL58/XO43vSRpenRzgn24Lc mj0BTFfnxvTIMcynhWneU5JmSc8NIfoyZ0v9fvrn4HKDk+0ot7o7Gt3TY+eV89G+74Hf dnwRJRrnN4MJxqzc4S0Ix9mkAMk8O79096GnjZKhUPdVooVJ4cao6IqQizsZJF66mLjd HrRriGn2Jp7Ovt4ChK+rLZ+rxC7lUW1ik42iOXMcxA9uZ9la2L5bqDfxhcAmMM2g/0rY HhnW96TB+3IXMXxNA07nDtCDovHSK2jMytXi4k2wpLXADkadCUu1OLeZ1TNDL0RNZR8+ z9rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785428524; x=1786033324; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=rtE+fcyTa/nEHTvbkkFzvfqX94g1NeErZWdBjlXHpz8=; b=XafVG/F9Cwbg0EbQ6X8W7EbMKtLqeY8bYUPZvULr/EMlA7qAqOWXEddsETjnngXjVz SIqERA38Tzvpjl+G4v4nr6rv9oTcxlHDqmuGyJTasN/ldwhNLle93u0v3gewmLxq+aJ9 vzQ/pnrAzZoepHra6R0sLfzZOAMxSOonUva/pXZgDcNVBwxoVro4dP2CslY23ZESZFrJ 2XjVm1JjCDKGK8GSmqZHk4hQMeMULTZ+bUEnvYgulEHgu44n7LL8vY5b1AKc1ACAajZl 3ug0iSBIX4UcRQB0aqAuc5nlRN51l8m10Z5KCO0Ekce7ukEn68qvR8v2BsDKkTVV3Nfw rRpg== X-Forwarded-Encrypted: i=1; AHgh+Rr6IAJjpMJtk4GGM4a01P6yBLASVADrTk16DhOXImF8JCTwuG4BEaLSEWRNKzO23q3Gp+oCBiuygORhCAc=@vger.kernel.org X-Gm-Message-State: AOJu0YwdKCh0bqkA5yITx6LZow1TlJr1uicepysupGUT2pm2kC+yn4J+ cX4ZQ195D6P2TuAgQFm1foaRkcTd0+HpZI9lH5X+DQF6Jo1LiPkvrrCG X-Gm-Gg: AR+sD11iRNC2EfBTeqA6U5ECW3Xak35Es3eualr+qmNYuXDXJghDXvJl3G+uSCF5+cb vwdy0tUa8kihtqo8uxMxKmoGxZYkM7kPEoNgofwrZZbRYCnSWBOANVY2/oHtzCfNBbIFk8SNUoD yLcj/X50gzQd5eC7/q1w5fRVqU2YZj4QVKSxy+falspEijXKApneDFRBoESMWJ1ynNmq1LtUs3p Ymi25e6mb8YPtowz5yfm69qz0tgNQ3H2S1ZJLphqEMvwEBQguB6mxdU79EgizlcUO3IiFjoOzsc tUXQhFSOTa0dMkh42Tmv++yWO94X65MkJlRwXONQgbgJgFPlMOd+hHH4Hv2HRxDjidSf09Bqe/P uWLAePhFjdr/zG+1NQPbMctCgTxPEGwDVYWUzU8fVbF+BfLf9ALWva8lEMzmRIa4oQthBqAC8Iv XrtcbQg+gV4vL6T1jHcLY8xfrti43xcUMQpqN7MhflBC1iK5spqBvV0tMqxo56IxB/qTH9YYuPN 9A= X-Received: by 2002:a17:90b:3c50:b0:38e:549:9e04 with SMTP id 98e67ed59e1d1-38fa7f28d64mr893861a91.1.1785428524560; Thu, 30 Jul 2026 09:22:04 -0700 (PDT) Received: from Potato.tail66a299.ts.net ([171.76.83.76]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13e7275973dsm19964269c88.15.2026.07.30.09.22.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 09:22:04 -0700 (PDT) From: Shivesh X-Google-Original-From: Shivesh To: arend.vanspriel@broadcom.com Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, Shivesh Subject: [PATCH v2 8/8] wifi: brcmsmac: ampdu: clarify standard compliance on QoS change Date: Thu, 30 Jul 2026 16:21:11 +0000 Message-ID: <20260730162135.12278-8-shivesh@example.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260730162135.12278-1-shivesh@example.com> References: <20260730162135.12278-1-shivesh@example.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Shivesh Updates XXX comment to properly reference IEEE 802.11n requirements that all MPDUs in an A-MPDU must share the same TID. Signed-off-by: Shivesh --- .../net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c index fc7a5dd2e5d8..3fd8bdbd35e5 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c @@ -516,12 +516,11 @@ int brcms_c_ampdu_add_frame(struct brcms_ampdu_session *session, return -ENOSPC; /* - * We aren't really out of space if the new frame is of - * a different priority, but we want the same behaviour - * so return -ENOSPC anyway. - * - * XXX: The old AMPDU code did this, but is it really - * necessary? + * IEEE 802.11n standard requires that all MPDUs within an + * A-MPDU belong to the same TID (Traffic Identifier). + * Since priority maps to TID, a different priority means + * we must close the current aggregate and start a new one, + * so we return -ENOSPC here. */ first = skb_peek(&session->skb_list); if (p->priority != first->priority) -- 2.53.0