From: Jakub Kicinski <kuba@kernel.org>
To: Tim Fuechsel <t.fuechsel@gmx.de>
Cc: "David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
fmancera@suse.de, ebiggers@kernel.org,
Lukas Prause <lukas.prause@ikt.uni-hannover.de>
Subject: Re: [PATCHv4 net-next] tcp: Add TCP ROCCET congestion control module.
Date: Thu, 30 Jul 2026 16:53:12 -0700 [thread overview]
Message-ID: <20260730165312.4b0e8d0a@kernel.org> (raw)
In-Reply-To: <amHMvwtUk6CocMBr@volt-roccet-vm>
On Thu, 23 Jul 2026 10:11:43 +0200 Tim Fuechsel wrote:
> +static __always_inline bool is_in_min_rtt_probing(struct roccettcp *ca, u32 now)
this seems to not be called, please remove
In general please remove the __always_inline annotations sprinkled
everywhere. Modern compilers will inline things correctly, and it
just hides such unused code warnings.
Please respin for this and whatever else in the sashiko bot response
you consider worth addressing. Looks like TCP experts are on vacation,
maybe v5 will be luckier.
--
pw-bot: cr
prev parent reply other threads:[~2026-07-30 23:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 8:11 Tim Fuechsel
2026-07-30 23:53 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260730165312.4b0e8d0a@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=ebiggers@kernel.org \
--cc=edumazet@google.com \
--cc=fmancera@suse.de \
--cc=horms@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.prause@ikt.uni-hannover.de \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=t.fuechsel@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®