From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 471BA40FD86 for ; Thu, 30 Jul 2026 17:12:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785431561; cv=none; b=G0Cifwrngqfk6Cjdgy1m183xGYjwgjQP4txciH7F3DoObLSxMDkL5jgWMCrp+JyRGvsM5FI5Ne6Kp6iFZEvCusWrc7gaMyj8BOz7262RpVZX9N3aBj+C11tiIHyVtRljgizVQezMJE2q78+dZsyPvG3EbjU0w5yAD4KZwVxsFTY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785431561; c=relaxed/simple; bh=irJiAlE0uebSDxrA7+RQHhRTNXJB7f3ha5b2+fbTaaY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qhLszwkdFakpv6O95uLpObDx7chK8ECt78r9jg2BkDflutkEX+Iq96fNxUSCmF5we1e6pJ++8f9381dvXoUv+bgdbdHBKwsqAPtdXEH/OAoHGVLol73vpMLNKiV8X/6ULMMwL6NP87zZrEq5CLqahyNUHN68XHGQti/Z1bA4M8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Dq2z/vLK; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dq2z/vLK" Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-39c8dbf4f38so554851fa.3 for ; Thu, 30 Jul 2026 10:12:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785431558; x=1786036358; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TBrurJyzVlD1+XYXbZ2mHYJRmHHdubezJzBygUS+NMA=; b=Dq2z/vLKFv2pAyvVqe6cT8IHCZofQakmNLB8bMTy0j6GRFAPTJDGggQwKV7W1/9pwn 54t31TrTNN8+CMH3d1xn1yDVObgbflTh2vLtVOQiPCdirZfsof7ow7mmtDMhM4tJiyIl YK30cSbHN06yS1hx39xfst8UEsWJG0MqpoxGHuHmHQ1DMFNDFzHYmjdSc4eO7IAHSwmk CZgr+L2AN712BIm6IOgD+2YaJ1oi4/mKYdVZnuyZriqnTcVVabNb2ywF/t4gPRUV9t2B sWy0KbCFkDMSlZhrZIG+OEfxvUVi7p/7ySg5yc9OFjJcnZ9sCuArdyL/brBohZPR0DFA 3uug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785431558; x=1786036358; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=TBrurJyzVlD1+XYXbZ2mHYJRmHHdubezJzBygUS+NMA=; b=Kv/HbEfPKJjp6/KpTueCCU7RjwIVs40GGqCv6rFQE2BsEZq5RI6ahQSA4uZwbEAEY0 MJSYQI/Pqo9VXzx6Zli8V2+Yi++mTw32kiDOkwY50BT+qWyDkmJwVW7J0O/oxybmxZNv 1nN5SK+wRT2HXHukl32rj+fMkpLZ8Ao0wMbDMQpIRpWv1K4Y/vVlIXN02scfEjVJA9Cj /v6Pxr5ozycg4Iz1FoPtrB1RIxAYFbtuYj646E9vwMzAuZOkJunjEHpydB31Y4CEXGyV ErZqEA+IK31id5OZLIAr2bwHyr6i3qFv7rWzizt+w8HEfUbs6svoUewQjDW1rzd8v2Kt 3AFA== X-Forwarded-Encrypted: i=1; AHgh+Rp0c07am7xp0JnV2uIqu46OaMA+vn1b0sHnCrH0mVyEavfu/f3OWEZGpu3XC8ykaoW6T4Pxj+DDIU/pJgQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwCjBloOTDCR9jrFIepaZgZVlXq3kyMZfPhyfG5OC/I9q2sV08t nrxb1rGYoy5VGu7Gej36rv6ShbL2/Jh46ZIWFI4if+Df9NgdkQCYJndU X-Gm-Gg: AR+sD13JfoU4H8Gnwhsb07koe6TLOJ5aAWULSbr/pRFvKWu8zN3idnmlEcDQwse2VXS HDriGhOwpbODDpCT9qYQ+6sR7hVl5b4gvqB83CJ046XUPTVPw4VRMfURNKu3up/Zgdi8gU2lLUn mOb+sDYswQ58nWBB1V4f15M5iH7cHXlAQDhjjAHz6VwWqTxldyX5C/2MiwJnAorpWFgou76xf/0 cZKGLSU6hcC7kB3al/zXsVmlACKZWVUChHOUf2gTfr5xhnFjVpP3LDvYrA2zan4aGKYEymj6N8W GekXV6ryNL3O5gzfwOmCVWs2xIWaz3lmg5jZUqS2hEmtSKTpBreRDdPzQ4Vjs/7IZrQZ2/iQ5KU P6dK6DVDT6/JNAlCYYqGccPa22AHhKDTEEuz0RTmKdvPZQQDIGc6OG5RgrAo7nyw/RSFiCExYG2 fQVR7L4f6fnyjABpUX82vJKRSkpKWZXmQJL6nMLtrkvd/E24mK80nsgP+Olw1JbPZioASNF7F62 HIid1QD7nz6hB7Ou7+S6jDnI5VDcPYSyNX/h2yjJRfioIx64ujGlZ8SnA== X-Received: by 2002:a2e:be27:0:b0:39c:92e0:528e with SMTP id 38308e7fff4ca-39f6b8171cdmr5519091fa.10.1785431558137; Thu, 30 Jul 2026 10:12:38 -0700 (PDT) Received: from localhost.localdomain (46-138-176-102.dynamic.spd-mgts.ru. [46.138.176.102]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39f6ac5ed84sm4288341fa.25.2026.07.30.10.12.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 10:12:37 -0700 (PDT) From: Artem Lytkin To: Jacob Keller , Jakub Kicinski Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, horms@kernel.org, chrisw@sous-sol.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] rtnetlink: truncate IFLA_VFINFO_LIST instead of overflowing its length Date: Thu, 30 Jul 2026 20:12:13 +0300 Message-ID: <20260730171214.76860-1-iprintercanon@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <0773587b-b355-46cb-9f4a-f3eecf8e01ad@intel.com> References: <20260725132236.88318-1-iprintercanon@gmail.com> <20260729185513.52564971@kernel.org> <0773587b-b355-46cb-9f4a-f3eecf8e01ad@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, Jul 30, 2026 at 02:17:35AM -0700, Jacob Keller wrote: > I'd argue this is a "fix", as we were previously doing objectively the > wrong thing by randomly truncating the message at arbitrary points. Our mails crossed. v2 went out ten minutes before yours, taking Jakub's 128 and 256, documenting them in the netlink spec and dropping the tag: https://lore.kernel.org/netdev/20260730090700.65867-1-iprintercanon@gmail.com/ I have no strong view on who is right, but the tag decides more than bookkeeping here. With it this goes to net and gets backported, so an ice PF with 256 VFs stops producing a corrupt link dump on a stable kernel; without it that waits for the merge window. Against that, nothing regressed: the interface has been able to write a length it cannot represent since 2010, which I take to be Jakub's point. Happy to restore the tag and resend against net if Jakub is persuaded. Artem