mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Yi Cong <cong.yi@linux.dev>
Cc: linux-staging@lists.linux.dev, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org, Yi Cong <yicong@kylinos.cn>
Subject: Re: [PATCH 0/4] staging: rtl8723bs: fix several memory-safety bugs
Date: Thu, 30 Jul 2026 09:36:37 +0200	[thread overview]
Message-ID: <2026073019-ambition-muskiness-2f9b@gregkh> (raw)
In-Reply-To: <20260729022509.2863634-1-cong.yi@linux.dev>

On Wed, Jul 29, 2026 at 10:25:05AM +0800, Yi Cong wrote:
> From: Yi Cong <yicong@kylinos.cn>
> 
> This small series fixes four memory-safety / resource-management bugs in
> the rtl8723bs SDIO staging driver.
> 
> All four are tagged:
> 
>   Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
> 
>   1/4 - kfree() used on a vzalloc() allocation (HalData) in the probe
>         error path.
>   2/4 - double free / UAF when register_netdev() fails: the error label
>         frees objects that the caller also frees.
>   3/4 - NULL deref in c2h_wk_callback() when the re-read allocation under
>         memory pressure fails.
>   4/4 - NULL deref on a bcmc station lookup in the 802.11 defrag path,
>         reachable from a fragment with an unknown transmitter address.
> 
> Yi Cong (4):
>   staging: rtl8723bs: free HalData with vfree, not kfree
>   staging: rtl8723bs: fix double free when register_netdev() fails
>   staging: rtl8723bs: fix NULL deref in c2h_wk_callback() on alloc
>     failure
>   staging: rtl8723bs: fix NULL deref on bcmc station lookup in defrag
>     path
> 
>  drivers/staging/rtl8723bs/core/rtw_cmd.c     |  6 ++++++
>  drivers/staging/rtl8723bs/core/rtw_recv.c    |  5 ++++-
>  drivers/staging/rtl8723bs/os_dep/os_intfs.c  | 10 ++++++----
>  drivers/staging/rtl8723bs/os_dep/sdio_intf.c |  2 +-
>  4 files changed, 17 insertions(+), 6 deletions(-)

Did you forget to document the tool you used to find and fix these
issues?

thanks,

greg k-h

      parent reply	other threads:[~2026-07-30  7:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29  2:25 Yi Cong
2026-07-29  2:25 ` [PATCH 1/4] staging: rtl8723bs: free HalData with vfree, not kfree Yi Cong
2026-07-29  2:25 ` [PATCH 2/4] staging: rtl8723bs: fix double free when register_netdev() fails Yi Cong
2026-07-29  5:31   ` Dan Carpenter
2026-07-29  2:25 ` [PATCH 3/4] staging: rtl8723bs: fix NULL deref in c2h_wk_callback() on alloc failure Yi Cong
2026-07-29  2:25 ` [PATCH 4/4] staging: rtl8723bs: fix NULL deref on bcmc station lookup in defrag path Yi Cong
2026-07-30  7:36 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026073019-ambition-muskiness-2f9b@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=cong.yi@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=linux-wireless@vger.kernel.org \
    --cc=yicong@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®