From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34407369D5E for ; Thu, 30 Jul 2026 19:14:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785438864; cv=none; b=YS8IRn9jQL3fiFQTcVgOKvAcZsoCYEq0VZf5Knd5eGZtsrRV+C/PmQPalUEUj3ZLBJ0w7WwesMKOTWmBgo8ChWP6hV+MIc68Q2KYxhf0xygZDWNM3ZI+JqgfxKKI/M5F2ZPweDt9TgMdnRO3QN6GUet8NTSpcpu6EiQrfeSbiH0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785438864; c=relaxed/simple; bh=Al41u0D2pnJS8WocszBwWiSEn2YksALdmQcPmnCVh2U=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XSXFU0NqbIzY8bj1+5OpIubOr6QdNTwU7bvd1UcXriEukjWFQLr+h8JsWUIW9bvMt7tozZfVMiCFlKP17EfK58tOoP6OCyBgoJREPPVA0sNyK3ZKWtiBAvyjTLlTl6umw+w4ICstK91BxtxS1bqjujnxgHIhAZQ5E0RnGtyaV3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=r3q9OBP9; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r3q9OBP9" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2caed617615so1724885ad.3 for ; Thu, 30 Jul 2026 12:14:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785438862; x=1786043662; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=QPVJbWuKxr05NUtfKny0+sjUmegHOFlNmdHQ6QVfAkg=; b=r3q9OBP9LHgUhCm8VJVc3lzD8MPzvy844pz6X32RSLYl0kalSMZ1KRJeOabtTZh10T YEiApqP+wpe1GMMOCNao2tesnfhj0mJC3JeV/dhaM1RLj8vqjFZDhUIBlwXNAZLkui29 9watxnwZ9w742g/7J4/ZCsPP1xZddYISy/WDhVXJMV0fj2af9laHe8CHSkI8biM4vtR4 dQEa61DXfJEEUNe/jNAAl3ood2ts3hm/BsClk23derkq/MVuGdgHxesAQ//1sRiKHNzB t0QfaeDVZukGexS70WsB17lSXJpfdoHO3yXW3TKeHaELigg4QSBxyh6udcKKjJ3qKH5v n9Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785438862; x=1786043662; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QPVJbWuKxr05NUtfKny0+sjUmegHOFlNmdHQ6QVfAkg=; b=dOwdE43kRyses1aGoTuV7WcE/X6ZLtl4ratjX+9XH2lOxvTNwrdoAMBe7nKVQNtWTM NYLtsjF/X7HJyF5BPhhw5op8JGvJ51/dKlnRZVigsbS3StsNNsVA/UglJ9iKw2226XJh FbI+MbgkDVpccIX78l/WhF9Oc+tVzX+v1Ed1YZ1nKKCD1CSnefbXxoOlhKzHSs+70/bD 7AsVG3bd0Pc3dnBgxLRTJOxsx+QT30ScjyQYTkADswXbd328j2nV4CFgKBfWeBYzxYe4 SuLp5aGNP9A2B4TmnJVcLA9eTOm7wC1LI7c/+fp2dc+sBxw0QP2UOC/o2r/AxpnLl3aC SB0Q== X-Forwarded-Encrypted: i=1; AHgh+RqxOjAI+4p9ux+AX0qGcUpcN66rSPCiD5H18tjEHrLjY83G/PLe47nVTxtCSDx4SJOC3d/BppyHuoXsDyo=@vger.kernel.org X-Gm-Message-State: AOJu0YznOgFyRosgd7Vf1TPJxjetbQRzidnO4vT8C1ASv6cmalUsNutx H1MJqfKZxDJTiXq+PQMenaUvRdxCVDms0BeHitNTABsFD6vrHimX4n7bCBbXz/h+ X-Gm-Gg: AR+sD12dJugJQmKZDJyx64Kp9LTy5+mTRkRXKfjxV62qHu2pTXntuBl3kHK3PbUnbfM dRYN/hw44Ik4W1i8+t6X52pxKHj6Cw+moTJK6L+WYWEp7W9MZSY47Wtl9TRZNGI9a8DEkKz2IUH TlNDEQ3SscmWFWdUQD2rCNOovqPe+3xF0ZSbip/ByTDCxPgVAJnOAR5DNYV6IYmfbpzEgb+f7Ie 97mugljGUd1k9Ted7TudJb9VC8PbYUSiqzcBTWmAWlU6bZArpKh8IGVN6IfaoxlqOOQ9e0q+Rq2 BJu5rltVUwcQruwrtqYOo+SQFl8HKAaWBawSydYW96yHsRCJSRiF5IeeN6WE1ACPjLWWjQpk6Vj 2nqDcxG+YBb3wT8/38gN3+jjBO8K2DjR3ga63hnI6c4dnPbjOUMvmAildC2aI+G2lS6gA6x8FT3 QH6jMyp+VVgPQ4podM6mP2zzESlPPNY97rgDVwedUBXJWo+jS1OjID3Me+bsKElD0NZ5gQ9Ia+2 xgWRDhJshcTuE8mx79ySHdmMK5v3sCxcDcyuUYlpD9IfAdqxreFsbGtV6Tu/Tj6+ymQbugBjcJ9 3c+EjuM4pj4mltLcj4XQDdXFpa4ziS6URHwErw== X-Received: by 2002:a17:902:f601:b0:2ca:329:3da1 with SMTP id d9443c01a7336-2d035c4d126mr35655755ad.16.1785438862471; Thu, 30 Jul 2026 12:14:22 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d022c50f2asm30755595ad.82.2026.07.30.12.14.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 12:14:21 -0700 (PDT) From: Rosen Penev To: linux-crypto@vger.kernel.org Cc: Herbert Xu , "David S. Miller" , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] crypto: amcc - fix racy teardown with devm_request_irq Date: Thu, 30 Jul 2026 12:14:20 -0700 Message-ID: <20260730191420.1043871-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver uses devm_request_irq() for the IRQ, but cleans up the tasklet and DMA rings inside the remove function. Since devres frees the IRQ only after the remove function returns, a window exists where a pending hardware interrupt can reschedule the tasklet after it has been killed, leading to use-after-free of the descriptor rings. Fix by switching to plain request_irq() and adding the corresponding free_irq() calls in the remove function and the probe error path before tasklet_kill(), ensuring the IRQ is fully torn down before the tasklet is killed. Rename goto error path to err_tasklet as that's more descriptive. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/crypto/amcc/crypto4xx_core.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/amcc/crypto4xx_core.c b/drivers/crypto/amcc/crypto4xx_core.c index 0271b5e4d923..fd010bfb7020 100644 --- a/drivers/crypto/amcc/crypto4xx_core.c +++ b/drivers/crypto/amcc/crypto4xx_core.c @@ -1294,14 +1294,14 @@ static int crypto4xx_probe(struct platform_device *ofdev) core_dev->irq = platform_get_irq(ofdev, 0); if (core_dev->irq < 0) { rc = core_dev->irq; - goto err_iomap; + goto err_tasklet; } - rc = devm_request_irq(&ofdev->dev, core_dev->irq, - is_revb ? crypto4xx_ce_interrupt_handler_revb : - crypto4xx_ce_interrupt_handler, - 0, KBUILD_MODNAME, dev); + rc = request_irq(core_dev->irq, + is_revb ? crypto4xx_ce_interrupt_handler_revb : + crypto4xx_ce_interrupt_handler, + 0, KBUILD_MODNAME, dev); if (rc) - goto err_iomap; + goto err_tasklet; /* need to setup pdr, rdr, gdr and sdr before this */ crypto4xx_hw_init(core_dev->dev); @@ -1310,12 +1310,14 @@ static int crypto4xx_probe(struct platform_device *ofdev) rc = crypto4xx_register_alg(core_dev->dev, crypto4xx_alg, ARRAY_SIZE(crypto4xx_alg)); if (rc) - goto err_iomap; + goto err_irq; ppc4xx_trng_probe(core_dev); return 0; -err_iomap: +err_irq: + free_irq(core_dev->irq, dev); +err_tasklet: tasklet_kill(&core_dev->tasklet); err_build_sdr: crypto4xx_destroy_sdr(core_dev->dev); @@ -1331,6 +1333,11 @@ static void crypto4xx_remove(struct platform_device *ofdev) ppc4xx_trng_remove(core_dev); + /* + * Free IRQ before killing the tasklet to prevent the interrupt + * handler from rescheduling the tasklet after it has been killed. + */ + free_irq(core_dev->irq, dev); tasklet_kill(&core_dev->tasklet); /* Un-register with Linux CryptoAPI */ crypto4xx_unregister_alg(core_dev->dev); -- 2.55.0