From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4895E441635 for ; Thu, 30 Jul 2026 19:56:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785441363; cv=none; b=KGz/UoNpbSQDbZZNNIw+Q6e5NwZ12RuyrxI32/D7qkr4e844whn9BJBL0BWfXKv+ou7qoYRfMwi7xL9wlnSkR7juIxpDn3blj2cGUGdhrjNaPgu0v1ZeYABypH81LweLhTlQBHle+Diq2wLMhEG3W7JgevyneHbTLzBM/cunYFM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785441363; c=relaxed/simple; bh=4EcwdMDzmeY7eDBJ08o417Y4f1FatjcQBhIsh0yvjVk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rj4ll4MbV4L1KFG7kBnrft5N6Wo+gFTtDsNZnlP4ccmhWgu1cet5lIu62LGhRzFF9/bBq+HUl9jMHSChZAYFM8tszDeGn+CFeg9qyrLi4EUQ382fKuXzCce+5Ln0Af+C6xRUYs5k9bbjQkTBQjQW5dWT63nUYEUuZlIimpLykdQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WWa2LEhg; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WWa2LEhg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785441361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G7pXERsaJxupz3ibBtEt7AN3qvnUBtFJM+fFekmGGOQ=; b=WWa2LEhgkbzuYhspHhMabteVgFJq53EFVIcwRdAVCD06BWK0HouxA8svDBmXRRUacLlyhQ jREfRyq1St9ELIxu/B9w4VOq4mwBptNElczpoJENNqUqHmdmkeOAifXcluPKsucBDZrhtG ljE+DbYcqQdh/h0m8rMrNYjHHfYVDLo= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-672-DgDdUgqmO224STtwxfjrUg-1; Thu, 30 Jul 2026 15:55:55 -0400 X-MC-Unique: DgDdUgqmO224STtwxfjrUg-1 X-Mimecast-MFC-AGG-ID: DgDdUgqmO224STtwxfjrUg_1785441354 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D4F14180035C; Thu, 30 Jul 2026 19:55:53 +0000 (UTC) Received: from GoldenWind.lan (unknown [10.22.88.35]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 79571424; Thu, 30 Jul 2026 19:55:52 +0000 (UTC) From: Lyude Paul To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: "Maarten Lankhorst" , "Simona Vetter" , "David Airlie" , "Thomas Zimmermann" , "Maxime Ripard" , "Danilo Krummrich" , "Lyude Paul" Subject: [PATCH v2 4/5] drm/nouveau/kms: Only allow enabling atomic modesetting on nv50+ Date: Thu, 30 Jul 2026 15:51:08 -0400 Message-ID: <20260730195523.1467423-5-lyude@redhat.com> In-Reply-To: <20260730195523.1467423-1-lyude@redhat.com> References: <20260730195523.1467423-1-lyude@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Atomic modesetting support was never added for pre-nv50 chipsets, so make sure we don't allow it to be forced on. Additionally, print a small warning when it's not supported. Signed-off-by: Lyude Paul --- V2: * Check against info.family, not info.chipset drivers/gpu/drm/nouveau/nouveau_drm.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index ae489dc1b1943..33f60f5d4d9f3 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drm.c +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c @@ -770,8 +770,12 @@ nouveau_drm_device_new(struct device *parent, struct nvkm_device *device) goto done; } - if (nouveau_atomic) - drm_driver->driver_features |= DRIVER_ATOMIC; + if (nouveau_atomic) { + if (drm->device.info.family >= NV_DEVICE_INFO_V0_TESLA) + drm_driver->driver_features |= DRIVER_ATOMIC; + else + NV_WARN(drm, "Atomic modesetting not supported (needs nv50+)\n"); + } ret = nvif_device_map(&drm->device); if (ret) { -- 2.55.0