From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 433FE42F710 for ; Thu, 30 Jul 2026 19:56:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785441363; cv=none; b=o+CuEMKXNcpWgYPihvbQXYSiECkYSR2jz9EYlGtK4KSJX44ykY88ksiNeAXWL0xBMkUN/Zd7K/V9QGi2ZoiHEGD0LQsVzl8WNFFw4Qcl3gQMfB2iKp3n9VhoR4reIq0rZRvZFtFwCW7ZfMPIETqd8w+L8cV44noIMPUsGtASM9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785441363; c=relaxed/simple; bh=oEUKDTTZE1QwOwAT2bVSvTJWMfD4adKwKub+4LPrxec=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X/TB34KMpvzGw/fd++6j97GTHsDg4qI0SyOLNd6HWYyOQsQUkvWKTJu071tIIu3erIIYuVY/d/32FUUetOJGlwyuGbJmggR+xr5Lh16/xrS9jwQ+9EN5jk+mrc/5Nv/QIWGfgGLmbDzVb8uMjoo5UD8HOCQ0lTytnXx5rodM4wM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ACLSpG4l; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ACLSpG4l" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785441361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s2pWr6FDrLfR5TEyfoazdJ2qFxzrYbwO/WWxngqJPT0=; b=ACLSpG4l9CN+lStijVLS6XzzkMElWLWW0KKCzwQ3NS7eV7VKuDUU1dKqEIselkSqyYSYoV +iyMlWyirHXbHpMPnOMejXsi2r3l89ZZLIAXtach3vPmTkH8mOHUuM5D2L0QFERHdnuEyt B19koOjRbmu0cS/izwJ4uv3bxvhHIUA= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-463-34eK-XZVNfqNC8-zl4_LUQ-1; Thu, 30 Jul 2026 15:55:57 -0400 X-MC-Unique: 34eK-XZVNfqNC8-zl4_LUQ-1 X-Mimecast-MFC-AGG-ID: 34eK-XZVNfqNC8-zl4_LUQ_1785441356 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0015B18004A9; Thu, 30 Jul 2026 19:55:56 +0000 (UTC) Received: from GoldenWind.lan (unknown [10.22.88.35]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 97EB6423; Thu, 30 Jul 2026 19:55:54 +0000 (UTC) From: Lyude Paul To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: "Maarten Lankhorst" , "Simona Vetter" , "David Airlie" , "Thomas Zimmermann" , "Maxime Ripard" , "Danilo Krummrich" , "Lyude Paul" Subject: [PATCH v2 5/5] drm/nouveau/kms/nv50-: Enable atomic modesetting by default Date: Thu, 30 Jul 2026 15:51:09 -0400 Message-ID: <20260730195523.1467423-6-lyude@redhat.com> In-Reply-To: <20260730195523.1467423-1-lyude@redhat.com> References: <20260730195523.1467423-1-lyude@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Nouveau is one of the very few modern hardware drivers in the kernel that doesn't have atomic modesetting enabled by default, in part because when it was originally written by Ben there wasn't much in the way of good atomic modesetting clients to actually test things out with. Nowadays however, atomic modesetting is very much the norm - and support in userspace for non-atomic drivers is starting to bitrot a bit - leading to its own set of issues. At the same time, many of those issues are fixed by just turning on atomic in nouveau. Plus, I've been running nouveau with atomic modesetting on by default for most of the machines I work on, and I've already fixed quite a number of issues to the point where things seem quite stable (excluding a single screen flashing bug on my desktop, which I am not particularly convinced has anything to do with atomic modesetting). Now that we've protected against breaking things for chipsets where atomic isn't supported ( --- drivers/gpu/drm/nouveau/nouveau_drm.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index 33f60f5d4d9f3..6da38d2e77c82 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drm.c +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c @@ -103,8 +103,9 @@ MODULE_PARM_DESC(modeset, "enable driver (default: auto, " int nouveau_modeset = -1; module_param_named(modeset, nouveau_modeset, int, 0400); -MODULE_PARM_DESC(atomic, "Expose atomic ioctl (default: disabled)"); -static int nouveau_atomic = 0; +MODULE_PARM_DESC(atomic, "Expose atomic ioctl (default: auto, " + "0 = disabled, 1 = enabled)"); +static int nouveau_atomic = -1; module_param_named(atomic, nouveau_atomic, int, 0400); MODULE_PARM_DESC(runpm, "disable (0), force enable (1), optimus only default (-1)"); @@ -770,10 +771,10 @@ nouveau_drm_device_new(struct device *parent, struct nvkm_device *device) goto done; } - if (nouveau_atomic) { + if (nouveau_atomic != 0) { if (drm->device.info.family >= NV_DEVICE_INFO_V0_TESLA) drm_driver->driver_features |= DRIVER_ATOMIC; - else + else if (nouveau_atomic == 1) NV_WARN(drm, "Atomic modesetting not supported (needs nv50+)\n"); } -- 2.55.0