From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB9033BE16F for ; Thu, 30 Jul 2026 20:49:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785444560; cv=none; b=t+gmquTIbLvnZXKnXbrDutiQhqaCDQrHNTRVUdd5Y/uiCuugeZ3r1y7lyMSU6eAXJjbL/i8//azZnZsHRPUTmAtKeU+di+r9rWX5Duvw3ZNEVWqYQW6+IWDt3Xz6j/ok94VcByb/X18Z5AUUMG8QkvuklEteWlLv4ekVxukUNDs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785444560; c=relaxed/simple; bh=KQjDx8OiIfwfzPDkx8703XvKPDz7tifMvyh1UpP5Wqg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MBvpmmTISYjX742Y2h+FPUOTa5m3FEzzA+EpmGUxloavPC6M/DbmkQi1gL8SwTvgwF0XFq6RiTyMT/hnhtHGwbuIFT+NIYRPKeWjkLz3rnEofBtXRCqbTvO3JpDvr5KfjFUScovrNMJBHxpCYdiqWMBiAasYUeV0CBWV9GrR/so= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jTGCtw7t; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jTGCtw7t" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2cf52d15d88so1974325ad.2 for ; Thu, 30 Jul 2026 13:49:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785444558; x=1786049358; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=0+ztttA4ibcaxOlaFxobuUDX/tAujvV4xkdOsxKr0lQ=; b=jTGCtw7tEAgY5HmB4KiPnrCuedn1tlwzMvyfiawk+uec1EuczngwIe6r0Ng/hVXBim N012siuQLVWaqeyo/kT1n9NEnNKoYZkSroFTvGsGWW7OF+NU0ZSwSYz/FmdB9+bQaJro Un7oa3yVhUS932wm4UiU2+nLkIjI1E55CCdOtxRANEojsp7Ikiq+ccxbCndQhfGzrzDj e4kUU9Wv1txpZQ8MpkPUxxaTFV34UOidvk54dyZgMzHpP6fcGx9B+UXBRItAt3yQ6R9h EK1DLN8GGqBOWzA1+kriTi+KyN3nMYV6FiDskR+1GE8hnAyhE0xu1tGBbs7pcGLgVBDM arow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785444558; x=1786049358; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0+ztttA4ibcaxOlaFxobuUDX/tAujvV4xkdOsxKr0lQ=; b=m8DqFYnePp23i0MHjBGPunCLv5OEtvKTFU3TDGbd4HucQSqfXIpJnqyu/OzAnHVudd Q86NQshnwXwhZxHurpNHi8ECymZcyXYG8TDH2bgPCtShBjRjp42txKVfiPvyQerLOqzq p8J127kKn1kOG4/YJWMHlRcu2S8xSysYBbAaXxv1nZc1emyg1ssGia4Nd9K5iWfMmWTF C4KRZrYkurNt2cowkfimptbFNgY5h8+jArSbE4DEYQ8PZnHb/behYWCc0xDjLlxeW32C 8q+eLJAmRsWvs3cg6D6Db6+5fgmkcJVL3In08CBW3UArzskr00jPC1STNQ3gvBV0B/rR ldEw== X-Forwarded-Encrypted: i=1; AHgh+RoCK+J0RV18sOaZMRBbvpKAz5Y0aAlmBw8Ks4Kou7tXJaaf29Y2/u5esX/ml2bNe4c2vt+riXmYr8K0F98=@vger.kernel.org X-Gm-Message-State: AOJu0YxQkogwtX7+K9aouC+WxcviDYw5oIk0GROx3PZAiFJGXPwPFLDG u1xa/EKVhDQrxpE/PXY/Dtl2QznMSa0lDssP9tEJKuQHOdxMwMVcFq6U X-Gm-Gg: AR+sD11pDthMMe2lN9OvRB0wy7bn+BAZ4jZMVYGv4KpcD3mn4NEEFx/UEp5BH7+lbPO cja2JZ0TeY+mpAEfZ6E+A3mn/1EUpTKhv05fQ93TT1QojkgEUuR/BoDI9hj5lz7ilUD73kFPkre pZb1RC8VjYUumSl0LxWN8x4Qc+9VAaOlX6QCX1HYTO6G/FpQNBoYUEcRxGjpjxWxlrm3OqYICmA Vu9+3jJvtIFPImOCRye0PGdpRmOtP4c+F7dmt776R/WA9d89Ydp8ZH+C8Rn2Logm2jO5Y2a/A2E /3kkIwi7msDwGCf/+gtzxPKAI7zLfo73IH6smSoAnovtJLnTfylHPRASyOxHrwt0pdFs7ziNn9o yX4+N0423Cexgo0gONFwICzehKIedlzz9/co8uSREB/vY3gGV3kYgpfjvkEJGpOuwFb05X29s/V zfNImJ2DDeuciAr2TgwrFTOhebXxOl0atwPnqT7ePzWNhEZvdRMRXUN73uB7ucyanHX4OwFWXbC AQa4MctfWD6t/FHJAd+u6+l7r6tKN8va7SWgqWdQMsGXBIY91oQtYAwqsX4Jq9gVvFrkR6wJuV9 6YnlIAR8lVR7msIKtdK9bef2+TgSSJh3dseotw== X-Received: by 2002:a17:902:d986:b0:2ca:cde5:29c4 with SMTP id d9443c01a7336-2d035d301f2mr39429585ad.47.1785444557946; Thu, 30 Jul 2026 13:49:17 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d022a154ebsm31416485ad.14.2026.07.30.13.49.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 13:49:17 -0700 (PDT) From: Rosen Penev To: linux-crypto@vger.kernel.org Cc: Herbert Xu , "David S. Miller" , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] crypto: amcc: get irq and ioremap resource first Date: Thu, 30 Jul 2026 13:49:15 -0700 Message-ID: <20260730204915.1102403-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit These functions can return -EPROBE_DEFER and require no special setup other than the platform_device which is already provided. Avoids doing extra work when not needed. Signed-off-by: Rosen Penev --- drivers/crypto/amcc/crypto4xx_core.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/amcc/crypto4xx_core.c b/drivers/crypto/amcc/crypto4xx_core.c index 0271b5e4d923..ec18aa90a86f 100644 --- a/drivers/crypto/amcc/crypto4xx_core.c +++ b/drivers/crypto/amcc/crypto4xx_core.c @@ -1206,9 +1206,19 @@ static int crypto4xx_probe(struct platform_device *ofdev) struct device *dev = &ofdev->dev; struct crypto4xx_core_device *core_dev; struct device_node *np; + void __iomem *ce_base; + int irq; u32 pvr; bool is_revb = true; + irq = platform_get_irq(ofdev, 0); + if (irq < 0) + return irq; + + ce_base = devm_platform_ioremap_resource(ofdev, 0); + if (IS_ERR(ce_base)) + return PTR_ERR(ce_base); + np = of_find_compatible_node(NULL, NULL, "amcc,ppc460ex-crypto"); if (np) { mtdcri(SDR0, PPC460EX_SDR0_SRST, @@ -1251,9 +1261,7 @@ static int crypto4xx_probe(struct platform_device *ofdev) if (!core_dev->dev) return -ENOMEM; - core_dev->dev->ce_base = devm_platform_ioremap_resource(ofdev, 0); - if (IS_ERR(core_dev->dev->ce_base)) - return PTR_ERR(core_dev->dev->ce_base); + core_dev->dev->ce_base = ce_base; /* * Older version of 460EX/GT have a hardware bug. @@ -1291,7 +1299,7 @@ static int crypto4xx_probe(struct platform_device *ofdev) (unsigned long) dev); /* Register for Crypto isr, Crypto Engine IRQ */ - core_dev->irq = platform_get_irq(ofdev, 0); + core_dev->irq = irq; if (core_dev->irq < 0) { rc = core_dev->irq; goto err_iomap; -- 2.55.0