From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31E8A3CB2D0 for ; Thu, 30 Jul 2026 23:17:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785453462; cv=none; b=LCB0n26gGx41QrAPcKP0ALt5Xz5nbO/lZBIIaZblGvnrSHhuRYKOkl7IlmdUoPKWsBwUZzItXmq1GgyGcyKte1EnGS37hbPAQm56MvIRIHtJGTKm/ggXftNvSseUtQMIF2iJF3SvhKkUA3zvXG1joaBVVt2/jAufxIPBLEWcZUU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785453462; c=relaxed/simple; bh=EHvfDpfxxWUHYnVRRayq7I+H5XtU9cbfpd1Wv3pIpgs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Z9HSbdakNh0uyYl0cNuoC11aOJVadfr/lA7jcTLYwpB3KekgBDj1Jw/fC9n4BbT5J3N1Sd2dZov+T1P2K0BkIv35zA9GrIpk5taPlrki5cO2BRybtdFL1IhxbG+lut1YkB7HI1AIt3Pdh5KnDbFXtae55mIYAHHFASkCdZWeOK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=k3gVn7OR; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k3gVn7OR" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-c96b08cdd1cso248900a12.0 for ; Thu, 30 Jul 2026 16:17:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785453459; x=1786058259; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RXdvAClsqaKvl5me0t3HAq930Gjdl6GY+XY0N1BhN0E=; b=k3gVn7ORzlvLSeLCxW68ndpTuKiJJLtUu+/bRWOWOTXUu9UAwDm8k8iZWJw5XzVZLw dcGUAwx78wFlISxK9zqRHuZNDzxEKHpJ8yPIaE+0czZKfojgDJ2pDg1dZtfre8nXtRXh elD04IydLMSukEGF3G9oEM0KAZzDfyqcuI0sK0UEDPhoErmYR1DM5GR/EotHCgd5TQoE HXoFGJ2bATEPgZ75T5R3M+XrQ8CeUpjDemRm+hSBHQKBMWbood/wLRjv+C3WtT6UxVQl T0BkHAUCDld8yVT95tig4tL0a7/YsA2oBMRFxw9TvVl5evBsEMpKo7QAsOYHkDgHYgOW nt4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785453459; x=1786058259; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=RXdvAClsqaKvl5me0t3HAq930Gjdl6GY+XY0N1BhN0E=; b=q9SZXCbkNiJ02O/GPSGjVPVe/iwmzx66XBVndVOUqrvNWVbbZ6z9VVXrUkHeEXz1KJ cb1mM67N2KlpwrE/sRTS1dlULDJaFu/OSKwOpjKTkLhUCJmPQgMsOjed6Hg+y10xkl6C 4olRSO8qT+zStx2V/SGdl9xSBDtVBNyyE/dcKL5PY280ctcSh8aNm95kAYNLi9DKvBH3 k3B0wcAA9ICpQPTIDw/JJQMevKRbZDaGUO+LZAt6wCOs9hdV3KGtkG4G+jAhbFP35bd1 YE5aVJRF0A+OmXUO1j0jm/uQjCPtkkitMB6Dm+AaBXmbWtrD956Ei1AdrWqFzKL3lVfj 78Ng== X-Forwarded-Encrypted: i=1; AHgh+Rru6NwGLP1FTpqHiUZ2PxgeJ1BmphzSfUc/98mGOa84Booh+1yCAj4UogFavzLal5E0IEeqGKxSHnn1yTo=@vger.kernel.org X-Gm-Message-State: AOJu0YwomU7fETxss0rByGvygTKE1TaL8EPQSz5/13QvF8L2sgvD3UfB caXoJEJfg3fBHQB92FoOvwsUu6DDDI8BIJ8oY2SdYaAfegpjy4zLvQPz5SFSq0Y+ X-Gm-Gg: AR+sD12tpZ1LIZjg0J+0TifNKZqolYERsvrP+lZfJONr3TX9n+jeVmP78oLbhlvgGhP TQl9Iy1KGPYOQAB2yjPl1mNjhIkHYCyHGLW3piVcgy1BD1tuhgleAKfNW3s5AvoJMHjLXX5EV3B YcBhmEZJ2s8GP8KFms7kYpNLI+8c66OsC0+9BPqIOHTIN2NENAszwsQ1IcBASH3tUoYMB+1cael fOW9OVKFK0Jzj6xE4dHg5SX7gOd8/Q6BHo1NlnUPanJnHFC5Waez2/tzJRrkQiWtKPGtean+oIU FdhQXatVsw/Kxcm9U2zJyaZv3qcb/k+2JBd2B3mXStXXQ9inDa3p/j4E/AWPCrcYHGiqAOznaSH ut79CTEBOmFuRnUBBc9NcbTCNuk4Ip5/nPV9WCmsry3216o7Bb6jiw6AM7ZSDY7bqHS5TrECqq+ mpwWFvNGaPH/gi07iiyIPMtO7L44kvmO5WCPD9nU43YKj/nmeMP3XO0UtO7u5qXhOXBWEz6BHar yblRUD4cFJxlNbtGRsBF2PFr2qfW5pWG+Y/TjY029GgllKhDzrmuyG5s/bZ X-Received: by 2002:a17:902:e550:b0:2cf:b066:7de2 with SMTP id d9443c01a7336-2d035cccd3dmr45068535ad.22.1785453458798; Thu, 30 Jul 2026 16:17:38 -0700 (PDT) Received: from bloom.localdomain ([2604:3d09:178e:e100::6868]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d0228417adsm32537195ad.0.2026.07.30.16.17.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 16:17:37 -0700 (PDT) From: Ivy Lopez To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ivy Lopez Subject: [PATCH] staging: rtl8723bs: use kfree_sensitive() for key material in rtw_set_key() Date: Thu, 30 Jul 2026 17:17:14 -0600 Message-ID: <20260730231714.81977-2-skunkolee@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260730231714.81977-1-skunkolee@gmail.com> References: <20260730231714.81977-1-skunkolee@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit psetkeyparm holds WEP/TKIP/AES key material copied in via memcpy from psecuritypriv before being freed. Use kfree_sensitive() instead of kfree() so the key bytes are zeroed before the memory is released, consistent with how psetstakey_para is already handled elsewhere in this driver. Signed-off-by: Ivy Lopez --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index 1196ec011455..fb45f7295386 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -1926,14 +1926,14 @@ signed int rtw_set_key(struct adapter *adapter, struct security_priv *psecurityp break; default: res = _FAIL; - kfree(psetkeyparm); + kfree_sensitive(psetkeyparm); goto exit; } if (enqueue) { pcmd = kzalloc_obj(*pcmd); if (!pcmd) { - kfree(psetkeyparm); + kfree_sensitive(psetkeyparm); res = _FAIL; /* try again */ goto exit; } @@ -1949,7 +1949,7 @@ signed int rtw_set_key(struct adapter *adapter, struct security_priv *psecurityp res = rtw_enqueue_cmd(pcmdpriv, pcmd); } else { setkey_hdl(adapter, (u8 *)psetkeyparm); - kfree(psetkeyparm); + kfree_sensitive(psetkeyparm); } exit: return res; -- 2.55.0