From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A07093DF002 for ; Fri, 31 Jul 2026 08:54:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785488086; cv=none; b=hTAD7CBrYUgg8BmIHlJZmsUacCinOU7i7FQRq16PIeQIhDYe/ZREDDDMz32l4aO675B0wk2SYHIPbJntIOU0VwiEC4Y2mf9mg9gYm5nb3GcrKl9F/qdXZ+bRb/NzmPB1HXGM+a1oSCQSCRKpO1rAECe3qQdAJn3dyZCE8I5lPgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785488086; c=relaxed/simple; bh=OZdD1ENp/Pvi/iFDguhGhQl/TfJcv/72CnXp+PHgYIQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dVbTYRClqOwhABHKwLfkKRBq+6IsSVxqQggX+0Zuv4WYupwb7OkaHIBsjx/xkWan8sPPA6mgzMUvJrBngxvpBNPJbdPuEG3rXxB0uvF+paeQWBCFyTiKCOPbg9+anN6/+l7Tg+OFvGRZQFtQvQRnt+7ifoweBQhNHxdiR/a54wo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KgSWpJ9p; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hXa3UInB; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KgSWpJ9p"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hXa3UInB" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66V8lPgf2991332 for ; Fri, 31 Jul 2026 08:54:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OqS1G3B+9SOZ15glFniS7ntN2KoHD2hpe3SeHaPoXwc=; b=KgSWpJ9pYNt5nA3E 0h0ty0uUChPhHs9w8wUWBRSxIQUe5S+be1ZV79QMozw7LFZfGhktgymAL0yu5TmW AodFvTO7A+CYaAyLmHiJcFNGypWTv7ob2tY26Lc2qWBQCtXw9gabrJUhB1DZzWCW OM1F/CobXjQ96/gWsUE16d80NG8SEuHL7BVGvktYdy8RS9NuySw54lSXn6TaT6ht QkweAIi69SUJ+s1JZRA2W905BxRC4s2YFeaQyFlqDyU5zrCBntwy92DBc+9JqKE5 c9RQ1c/0VCGEOM0du8GHA8NAH8X54TdhmYAH/lrVq16bFCDvyD1XDU7UX+wjVVLd dRtBkQ== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4frrgpg0xm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 31 Jul 2026 08:54:44 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-907e49dbae8so6246376d6.0 for ; Fri, 31 Jul 2026 01:54:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785488083; x=1786092883; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OqS1G3B+9SOZ15glFniS7ntN2KoHD2hpe3SeHaPoXwc=; b=hXa3UInB6ZcO5WgvnQscmwqDSGIUi1caP3qq013GUe9nvit5zNf+ERosRHyECwW8q2 FcWhbHJUp9nyWvZTcPjKUv9X3ChzDVukyLV/UutNKXe0djP1ZfrfMFmd4tgKF3As0W7h e9VBR6RLxxq13j0JdnUzUCxRUrvVRX3jyGTZfWdAZGUBmLiV3aoyUUSZI6Ss8ZbwyJPf TNA7DlUOtLSeFj4mpm8YVZtqeNgd2j4qAiFGcT8vH0d/VMhyxzZcTXhtqKJcdl3rbEhV wxV2mI9Fj9BQcIkrh49Q7fWcNaj6K7OEHEWOYZ8WjZ4GvmA55w6eXwz2BZHnRlVGmsFj yB/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785488083; x=1786092883; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OqS1G3B+9SOZ15glFniS7ntN2KoHD2hpe3SeHaPoXwc=; b=ljt6qvzESdUjm6OV/XUbtcW6kr4DGL2Z+q/5SkUejv9DSwOzH0zycXkjKNwYbv8b1v mNTDJwoIWxyQLQv5XwfVxwBVbtmVpD1pQAlZvRXAQukPB072G3ftHR58J+pSH3gPddUB GJu6cl+cJf3oMxVGSNin0Kv8A2F7nAcW5RDSYsEoDYztQKa3qe82HvSpwepCV8htols7 z8km5YrHLACLup7LT0IS/ngMpxgdDhhaToAb3RRI3RIr82FJpoeHipy7eH/KbkSgoZb1 nHLIHLyqUyF98A6WI9QnLGehL+9QaTKSi0rJ/LRyB/FJhigvFlf/jlp4ZUuDKH5ltWxY VLDQ== X-Forwarded-Encrypted: i=1; AHgh+RrCd+H1OdpmAP+oAbkKcCI+3nUg8LL8Nn3DyPqsn6lGhnLO7tPDR0V6C3uLL6XhRbzf9HTceO8x/tSS/sM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5VfO1skZfsJl9s6Ep6xg2G1EXPJzxTDd8Oexpeb5DtBfUDN1Z bH8Gbu/IyvR+JanKYQ7CISiHGNLnMt0SenaqTtGktkGTLyp581tzjL2arDVTMbBKDBcsL3Knq9T 4amkbtKhaNkfztNBUoprOejlWC5MQEwhh8I6121JdWhPMB1OHv7sOoGbdDGcaio93Ttg= X-Gm-Gg: AR+sD13EGwb8ekozBcXl80onsTPumKaDSXUmt8vB/SHbl1y2vqxLSi766otOuMPZBNn M9nhDrVxz596YmDXyM54nsH7y1h8LMlkj10xHNzceT+5lzhXEi1tmBMJ9JkHIsD8DW80z+Pf/YU 4ZNjQI1gUYuItdaEfKb+8IPTA7d6eAn2MkiXp3LKtF602q7D52z/aH8iYJJal7i8u+5Uz0283/F We7/T4L7XcjVBBsgewVVn1wBPg2jOpwXkK1v3XHxPmmBDqK3/FGF4ZiHA8qr1bHPdYJA+NudtCl lRGYJIoNCU8NTlzB56mZQGw+qWabgdouId/lH1D8cnjEVTKCKll3dcNJbAQ6hYzQ4ewBqADKZoy IUsr++LpVqzfE6cxMTi2OeOJoAVnJObF3mWKgRLNMtniztO08zQzZTLo87J9ZhGNyqXduYLH9c4 trXPlUYwoAC9c5E7COw/smjS4swaBGqvgY4T3jkOBobgC7ewjXx1aZ X-Received: by 2002:a05:622a:1107:b0:51b:fc67:c738 with SMTP id d75a77b69052e-52b4af2baf8mr12319251cf.29.1785488082968; Fri, 31 Jul 2026 01:54:42 -0700 (PDT) X-Received: by 2002:a05:622a:1107:b0:51b:fc67:c738 with SMTP id d75a77b69052e-52b4af2baf8mr12318871cf.29.1785488082533; Fri, 31 Jul 2026 01:54:42 -0700 (PDT) Received: from QCOM-eG0v1AUPpu.na.qualcomm.com ([2a01:e0a:830:450:61cd:dcd3:c61a:ac3c]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd44e9f0bsm61899366b.43.2026.07.31.01.54.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 01:54:41 -0700 (PDT) From: Loic Poulain Date: Fri, 31 Jul 2026 10:54:37 +0200 Subject: [PATCH v4 4/4] media: qcom: camss: Report hardware version via media controller Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260731-camss-version-v4-4-be8b716a8c4d@oss.qualcomm.com> References: <20260731-camss-version-v4-0-be8b716a8c4d@oss.qualcomm.com> In-Reply-To: <20260731-camss-version-v4-0-be8b716a8c4d@oss.qualcomm.com> To: Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Loic Poulain , Konrad Dybcio X-Mailer: b4 0.14.2 X-Proofpoint-GUID: uNlpCU_47GXMALB2egJFr0AFLuCvT8lQ X-Authority-Analysis: v=2.4 cv=SK5ykuvH c=1 sm=1 tr=0 ts=6a6c62d4 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=_VBxEyf9HguAcaXgWQEA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMxMDA2MyBTYWx0ZWRfXxJXCGx7mwIYR GOHRXmfcU4EdpCBrdqxbjMbgYQHS0awovC+G6GK+PKPoaockOPIVumFUBU3CUnoOo2Q3YECcxuv H1oIBFN5n35dzc1NzZCiZRgo+CjJKIPSNh0+H9pAQ98DAqJ2DYBoGgcgZB69MaD+cPCfhCdcjCx PFFcw8soW2UHlMSJYFxH7r4K+lLVKmL43V/t8aErInl1uABaVyYFVNKGjzxq9hZZclqVCUqahbp JSq5SSDKgwX5OcofY2BTEE4F7aR7hyWpuSaUiAAyxbEslFt5SOUS/G5MWVv9y7dKCIvNTkKtS5/ hSDdXaS+AlxcVqJacRJdcTpEM430Y2JFQ0bgTPwcFxqRbK2R7uuhB4slkJBY2uT2Ow8ehNKnQoy o5nGzwPezQaSidSyEkBTorNYIzOzPoVDJXGmenIWld3jyrSJRFwx1wZq4gQKbevf1ta6Y5I7aJK AfsthuZ4d/eRkOrrg3w== X-Proofpoint-ORIG-GUID: uNlpCU_47GXMALB2egJFr0AFLuCvT8lQ X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMxMDA2MyBTYWx0ZWRfXzZNblf125jV6 IQ4w9dGP6brJk8ObBEA4cxo6HWIXN7/ReLbieqho3ZgTc4afQrgDKXNeRh77G2A+BNeFO7R1wp3 Vvk+g6ACc9qVL2F2cN+ts3wbfcJQtps= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-31_03,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 spamscore=0 impostorscore=0 malwarescore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607310063 Populate media_dev.hw_revision with the top-level CAMSS hardware version so that user space can query the exact hardware variant through the media controller (e.g. via media-ctl or MEDIA_IOC_DEVICE_INFO). This can help identify the platform variant and adapt behaviour accordingly, for example allowing libcamera to apply quirks or enable features that cannot be discovered through standard V4L2 or media-controller APIs. The version register is exposed by some platforms through the top-level "top" reg region (offset 0). When present, map it and read the version once at probe. This is a no-op on platforms not mapping the region (yet). Reported media info on Agatti/CM2290 (Spectra 520): Media Driver Info: Driver name : qcom-camss Model : Qualcomm Camera Subsystem Bus info : platform:5c11000.camss Hardware revision: 0x00050200 (328192) Reviewed-by: Konrad Dybcio Reviewed-by: Bryan O'Donoghue Signed-off-by: Loic Poulain --- drivers/media/platform/qcom/camss/camss.c | 40 +++++++++++++++++++++++++++++++ drivers/media/platform/qcom/camss/camss.h | 1 + 2 files changed, 41 insertions(+) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index f688d11990a71aa6d745db1fdcebefe5a5119ca3..6807239a19677709481bcba0246e66ea5ebc4a83 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -33,6 +33,9 @@ #define CAMSS_CLOCK_MARGIN_NUMERATOR 105 #define CAMSS_CLOCK_MARGIN_DENOMINATOR 100 +/* Top-level CAMSS version register */ +#define CAMSS_HW_VERSION 0x0 + static const struct parent_dev_ops vfe_parent_dev_ops; static const struct camss_subdev_resources csiphy_res_8x16[] = { @@ -4677,6 +4680,29 @@ void camss_pm_domain_off(struct camss *camss, int id) } } +static int camss_read_version(struct camss *camss) +{ + u32 hw_version; + int ret; + + if (!camss->top_base) + return 0; + + ret = pm_runtime_resume_and_get(camss->dev); + if (ret < 0) + return ret; + + hw_version = readl_relaxed(camss->top_base + CAMSS_HW_VERSION); + + pm_runtime_put_sync(camss->dev); + + dev_dbg(camss->dev, "CAMSS HW Version = 0x%08x\n", hw_version); + + camss->media_dev.hw_revision = hw_version; + + return 0; +} + static int vfe_parent_dev_ops_get(struct camss *camss, int id) { int ret = -EINVAL; @@ -4866,6 +4892,16 @@ static int camss_init_subdevices(struct camss *camss) camss->csid_wrapper_base = base; } + /* Optional top register for hardware version info */ + if (platform_get_resource_byname(pdev, IORESOURCE_MEM, "top")) { + void __iomem *base; + + base = devm_platform_ioremap_resource_byname(pdev, "top"); + if (IS_ERR(base)) + return PTR_ERR(base); + camss->top_base = base; + } + for (i = 0; i < camss->res->csid_num; i++) { ret = msm_csid_subdev_init(camss, &camss->csid[i], &res->csid_res[i], i); @@ -5459,6 +5495,10 @@ static int camss_probe(struct platform_device *pdev) if (ret) goto err_v4l2_device_unregister; + ret = camss_read_version(camss); + if (ret) + goto err_v4l2_device_unregister; + ret = camss_parse_ports(camss); if (ret < 0) goto err_v4l2_device_unregister; diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h index fe5fe25d5f18d8a3ce35b48077a975f1453c341f..cce79e56f58c8bdc0097f4a1702df22c4248f2fa 100644 --- a/drivers/media/platform/qcom/camss/camss.h +++ b/drivers/media/platform/qcom/camss/camss.h @@ -133,6 +133,7 @@ struct camss { struct ispif_device *ispif; struct vfe_device *vfe; void __iomem *csid_wrapper_base; + void __iomem *top_base; atomic_t ref_count; int genpd_num; struct device *genpd; -- 2.34.1