From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1073B47A0B4 for ; Thu, 30 Jul 2026 23:48:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785455330; cv=none; b=sKoHkNcRT5//EWEIYFaf+57d/73RVNLQ/HXIya9MxvBlQU5pd3jRuaDbWXdur925hpPSn4Gu9hwzu1hw/jMFSd9IiYefdrtnmZ/Jk694UbdTK5X1XW7x3CvuYosOPjoJ6+yApYjiwQwu0xlQbV1S/a599BsoO7J6XZzS3UV4u/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785455330; c=relaxed/simple; bh=fZh8pXjBLV7CL4L4cLP+s2vvhCR34CRwnZrtXuVWgK4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XSsmh+diU7RMNpOdqqh6Sd2r8bOi0HzSQ50eujea/abPmwWpTfSAhxDB5y4KRam1CgoB6yGf3KH/vPyHXrEWTErPBcCP1oS173oURjZTR9yRgPYAtYYAqYVXLFxniuZTRUevxmh7om9058A4LtbCHeVHQLym55I030J+pm3rvWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TS9cePoi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MLWfudYB; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TS9cePoi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MLWfudYB" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66UN2EvJ2415467 for ; Thu, 30 Jul 2026 23:48:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JE84nLukSQ0KFz43ytsORYlHeEC7W0lihrEPK4IA49Q=; b=TS9cePoi+R8phAXC bisSxjvPa4QgUXFywAOWOlnhdemlHoHTwk4m+LpkwY4ztptduYFe5QzcnGGyHgUY ymlaFEDLANxwcOirTnE6hkUPyEwiUBl75AvI5UlpMB3YSTdMlIQE+MqLHxh/3++I z77ekWRVYZziXaoj2rBtuIw7KolR47jauxB7gYvnR0np/vSjDIsnRTkqRfxeSd3P gRsU9DDK2pOr61H3kL0PVDXcCYfcTr2uZnf06UsqStutDYAo0v/GcIZbmsDixPec VkaSpOqNKArjiCvrmCTaHRpiJiA5ccXx8uZSxAbMejgDfPv6S5OKM/XjQkP3Isxw n4b0yQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4frfxbg3rx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Jul 2026 23:48:47 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-526da7e3c9dso3224911cf.1 for ; Thu, 30 Jul 2026 16:48:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785455326; x=1786060126; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JE84nLukSQ0KFz43ytsORYlHeEC7W0lihrEPK4IA49Q=; b=MLWfudYBGRBBiByrVSxnkAc3buytNpBFvsFaO6v8HetugdUL8DpLlP3SPPNrqkplZR 8W/6PC7K8Cc0cBfPeUmjYfCZqliKr4IpFZgXEWCJvrj//IOt1iNBOKlXIciKB4Ux5Ceg OcOUiXXs/Jt5joah1xe2vieNsjdSvEqTxEr3vFRReAL7H7QJkxBwv1WNBRnfOjXlHYId kfeMUghfqf1juW1upKdTi5j3W7DnVLYdG6oDlk/n+5SjhmnB7Ho0a9+n8B0QJs6qIhvx 8QIvOARCRRmj3C56wokmC8jTLmot/4IaVjq7cm103/HhCYv7ZlFf8XOU3ZwCFgQrd+Ku Gizw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785455326; x=1786060126; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JE84nLukSQ0KFz43ytsORYlHeEC7W0lihrEPK4IA49Q=; b=YniEdlC20AETmpOnpmA2nzK3TyTVPL/Vv1i5sH9w5VSqzVQZjl/DCSmbJWEFj4kF5n Mjpo1KMZxLFTdHs2pWxelk/493rLoWvxFuknN0IlaQ156YfkIlVpn1Y8NP/khMSDXEk/ ZwjL0033jAwhAe7VT/l9oPcNcKvRJvzwy5D+QFaX4tLiyKiGy7DkiPBYQdFXP+5k0XOJ vdb4i0xeNIzWBENZlrt5qqBg2qz0lbIeshzfoHI/K52iEfuY4vGbCf9vKoTX5agSZBah YzRpMVfPr17CL7WmDIAeDw/UtxEKP4xMSfhmWJC1IT5qrZFgkshKROGZs/ZjOGSPVvqH 5JxA== X-Forwarded-Encrypted: i=1; AHgh+Ro5G3hakHnjEpQyiGYA56ohfIjGvh/JKUmKq7IznDkiaZ/E91kbEXGQDoplBbkoVvlpJJrn+WEjIuTkKZQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyoqUsCn+t8vhYlcoLR1yi6VNHRqHFCfRIyU7Wk1m27ogt0rrzN 0VOwkEUJ60od1YJDdzQRoRNvV0CUKPQemtqF96dd+uYP+6PNed2n13A5HmXvyd2ZwyQ8rJ5G9v5 YYelmr5osG3+pqja8FknIwB1YCmz89auWX4HntchlyQex4Fe0jB8Pijfbh+E58AW9BgQ= X-Gm-Gg: AR+sD13Itg3ws/f7oZVi37yPvXEn5WnUYQ8HTAkXtC0j9y8fzt9L1AMMm4yrf4EmEfS b6rGzbzi/coamKYEKYOg6783cVZBMkguyb/qu4M2qPqS9ubsIveBdNzxT9f4VQVWxgPQdBOO+2W bg3cJoi3ehfWiQM4FJNSdgndLoQseCEUmuHQJX99Q9tSjhXQSbIy3H/Oy1V1r+5BFodN73+wUnn PJNH0yRT7Yue9SG8m5dMvGX8xE+VbLRw3U2JmQ1BRdye8n1RpX2Fpkvm840qGgwVCJ+6wQYOy9h KdP1BjCUxPmTX+0VuuIewNEbvF/n69nLHTX3PsATy6yG/may+D8rmkqYBYzqapL0fA1MGnkofgx UV8YrgyJmxBpbg9divdGzwzhJLW+Uewl+ecm9cySGTPUMwd210ld9z/O4c/Fs6qsda5MpgcWkOy rSrbkHA4zTSj6ojQ== X-Received: by 2002:a05:622a:5888:b0:51a:8c97:9389 with SMTP id d75a77b69052e-52b386b597fmr53956181cf.64.1785455326137; Thu, 30 Jul 2026 16:48:46 -0700 (PDT) X-Received: by 2002:a05:622a:5888:b0:51a:8c97:9389 with SMTP id d75a77b69052e-52b386b597fmr53955881cf.64.1785455325631; Thu, 30 Jul 2026 16:48:45 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b2db9ba724sm634487e87.45.2026.07.30.16.48.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 16:48:44 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 31 Jul 2026 02:48:28 +0300 Subject: [PATCH v9 07/19] media: iris: Introduce interrupt_init as a vpu_op Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260731-iris-ar50lt-v9-7-d71a782001c0@oss.qualcomm.com> References: <20260731-iris-ar50lt-v9-0-d71a782001c0@oss.qualcomm.com> In-Reply-To: <20260731-iris-ar50lt-v9-0-d71a782001c0@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vishnu Reddy Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Dikshita Agarwal X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4931; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=7Dbo3Pf/QK/63owqGZ1NO1kT389qxHGUCVTVhtY9Mcg=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqa+LKPms//l5F+EEFGefMemOsO6O4QNbl3InQ6 2Yll94A27mJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCamviygAKCRCLPIo+Aiko 1eopB/wNOg5Mw2Cibf6K13520CjRtafYBDP5LMjwpCUpl41jjuVOkpMh3dQbaJutQE+gU8sLexT OHRWSZyYQabf8BkxuTksDgc0Ss8XDHk1oMq5Ima+0sab42qM/Vm5wQY1MwX6/r2VORweZxO3VZw F29gcoC2gdJQmpfS76hJkryRqxZlyFI70BmteP7dk2yl2vhohjX9aGf1Myqk/a743z1EXxB7zSm 3skhaRK0xVTyZmRBlWHJP1sTiW9F9oz+p2yGpq4+GMH16UrBUrwF7clR8PEgDy4dyNojz1bTzF5 hz1U4rbrXBLJFnOfFeF8i320lmv+LfiXhN2YteyMlSIV1Ovu X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMwMDE2OCBTYWx0ZWRfX9Dsr8RzV0spD I5jfGUx+lnuvveiukacIkOOunTDKRnK0Pw9lnPgTZj/SJzz/Qpg1J7doAUQghP2Rkmb5PPdjkW0 wCYtvynyiVANTbukhSkhjf+c0Ofxjmy8t59FF4rYkok4abHoNYguwhIDUYliBZw93zchpPBw2ke pLuJOEpZAAPi6KdWBUVIYWsi8iQ713P0zpP5a0iXJElXSjowujrKJN5ROAlfPLKSDq+/IaalNpe DcY+05unw4Z4dnGGNdBQCrFFo4O0GyGYt/SnbpyR+SF/MMGhWuI2ynUERhPQj/CKEefDu3kOBmA HYpNYqNoYs82UJ6VO0WbjezTivLMSLhS0SvFzhAuHi9JzLTP6jy5Rj34s64QFZ6revQckhxpeHw HfEeqLMCZF5XESgnUC+EQxTQ2kPN87B5cc8h5Y7dX9wk6xlg9oG2+LyXEKKBWewNNNEN0aiQbGI xIrHh9bpoV8pTYstU2g== X-Proofpoint-ORIG-GUID: i04ehcDxad8GQHpqZJ3cU-URkEkR2vSF X-Authority-Analysis: v=2.4 cv=Irkutr/g c=1 sm=1 tr=0 ts=6a6be2df cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=2EYiHOum3YQmkHKk0wkA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: i04ehcDxad8GQHpqZJ3cU-URkEkR2vSF X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMwMDE2OCBTYWx0ZWRfX4JwBa+CKwvAa APuspLv+F0CJLSUrQzDfkPCfeDYqQepQSRiEl5T9QYBOGIreoaZsEL1iQgh2mhKiNU4ZbOvvivr 5OSku3Giq9rhcI7Wu5EDE2GtHbRHUNo= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-30_07,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 spamscore=0 clxscore=1015 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607300168 From: Dikshita Agarwal The interrupt_init sequence is currently shared across all supported devices. Starting with Qualcomm QCM2290 (AR50LT), the register programming would differ. Move interrupt_init into a vpu_op to allow per-device customization. This change prepares the driver for upcoming hardware variants. No functional change so far for existing devices. Reviewed-by: Dmitry Baryshkov Signed-off-by: Dikshita Agarwal Reviewed-by: Vikash Garodia Reviewed-by: Vishnu Reddy Signed-off-by: Dmitry Baryshkov --- drivers/media/platform/qcom/iris/iris_vpu2.c | 1 + drivers/media/platform/qcom/iris/iris_vpu3x.c | 3 +++ drivers/media/platform/qcom/iris/iris_vpu4x.c | 1 + drivers/media/platform/qcom/iris/iris_vpu_common.c | 4 ++-- drivers/media/platform/qcom/iris/iris_vpu_common.h | 2 ++ 5 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_vpu2.c b/drivers/media/platform/qcom/iris/iris_vpu2.c index 2dc121a3f5e8..dd2eeae0d9eb 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu2.c +++ b/drivers/media/platform/qcom/iris/iris_vpu2.c @@ -46,4 +46,5 @@ const struct vpu_ops iris_vpu2_ops = { .calc_freq = iris_vpu2_calc_freq, .set_hwmode = iris_vpu_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; diff --git a/drivers/media/platform/qcom/iris/iris_vpu3x.c b/drivers/media/platform/qcom/iris/iris_vpu3x.c index dc02ced1b931..c3b760730c98 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu3x.c +++ b/drivers/media/platform/qcom/iris/iris_vpu3x.c @@ -262,6 +262,7 @@ const struct vpu_ops iris_vpu3_ops = { .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; const struct vpu_ops iris_vpu33_ops = { @@ -272,6 +273,7 @@ const struct vpu_ops iris_vpu33_ops = { .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; const struct vpu_ops iris_vpu35_ops = { @@ -283,4 +285,5 @@ const struct vpu_ops iris_vpu35_ops = { .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; diff --git a/drivers/media/platform/qcom/iris/iris_vpu4x.c b/drivers/media/platform/qcom/iris/iris_vpu4x.c index f608a297d4a3..90ccdc0d2a07 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu4x.c +++ b/drivers/media/platform/qcom/iris/iris_vpu4x.c @@ -369,4 +369,5 @@ const struct vpu_ops iris_vpu4x_ops = { .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu4x_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.c b/drivers/media/platform/qcom/iris/iris_vpu_common.c index 39adf8aa91a7..9a89e8ae06ce 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu_common.c +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.c @@ -31,7 +31,7 @@ #define UC_REGION_ADDR (CPU_CS_BASE_OFFS + 0x64) #define UC_REGION_SIZE (CPU_CS_BASE_OFFS + 0x68) -static void iris_vpu_interrupt_init(struct iris_core *core) +void iris_vpu_interrupt_init(struct iris_core *core) { u32 mask_val; @@ -485,7 +485,7 @@ int iris_vpu_power_on(struct iris_core *core) core->iris_platform_data->vpu_ops->set_preset_registers(core); - iris_vpu_interrupt_init(core); + core->iris_platform_data->vpu_ops->interrupt_init(core); core->intr_status = 0; enable_irq(core->irq); diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.h b/drivers/media/platform/qcom/iris/iris_vpu_common.h index 21ed4c9bd5e3..9151545065cd 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu_common.h +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.h @@ -23,6 +23,7 @@ struct vpu_ops { u64 (*calc_freq)(struct iris_inst *inst, size_t data_size); int (*set_hwmode)(struct iris_core *core); void (*set_preset_registers)(struct iris_core *core); + void (*interrupt_init)(struct iris_core *core); }; int iris_vpu_boot_firmware(struct iris_core *core); @@ -44,5 +45,6 @@ void iris_vpu35_vpu4x_program_bootup_registers(struct iris_core *core); u64 iris_vpu3x_vpu4x_calculate_frequency(struct iris_inst *inst, size_t data_size); void iris_vpu_set_preset_registers(struct iris_core *core); +void iris_vpu_interrupt_init(struct iris_core *core); #endif -- 2.47.3