From: Borislav Petkov <bp@alien8.de>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] x86/kaslr: Remove redundant if checks from address selection
Date: Thu, 30 Jul 2026 17:02:31 -0700 [thread overview]
Message-ID: <20260731000231.GHamvmF6EScjVpbxwq@fat_crate.local> (raw)
In-Reply-To: <20260714205752.133163-2-thorsten.blum@linux.dev>
On Tue, Jul 14, 2026 at 10:57:51PM +0200, Thorsten Blum wrote:
> The loop in slots_fetch_random() either returns the slot address or
> exits with i == slot_area_index, making the if check redundant.
>
> The if check in choose_random_location() is also unnecessary since
> commit 8570978ea030 ("x86/boot/compressed/64: Don't pre-map memory in
> KASLR code").
Sorry, you lost me here.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2026-07-31 0:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 20:57 Thorsten Blum
2026-07-31 0:02 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260731000231.GHamvmF6EScjVpbxwq@fat_crate.local \
--to=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=thorsten.blum@linux.dev \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®