mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Pei Xiao <xiaopei01@kylinos.cn>
Cc: vireshk@kernel.org, johan@kernel.org, elder@kernel.org,
	greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: fix coccinelle false positive on potential NULL dereference
Date: Fri, 31 Jul 2026 13:20:16 +0200	[thread overview]
Message-ID: <2026073103-ecard-substance-3fa4@gregkh> (raw)
In-Reply-To: <58151f69faefc2145954b95261506e3e7c14ca89.1785228166.git.xiaopei01@kylinos.cn>

On Tue, Jul 28, 2026 at 04:44:52PM +0800, Pei Xiao wrote:
> In gb_bootrom_get_firmware(), when fw is NULL, ret is already set to
> ERRNO before jumping to the queue_work label, so !ret is always
> false and fw->size is never dereferenced. Add an explicit NULL check
> to silence a coccinelle false positive warning.

Why not fix the coccinelle tool/script instead?

thanks,

greg k-h

  reply	other threads:[~2026-07-31 11:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-28  8:44 Pei Xiao
2026-07-31 11:20 ` Greg KH [this message]
2026-08-03  1:05   ` Pei Xiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026073103-ecard-substance-3fa4@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=elder@kernel.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vireshk@kernel.org \
    --cc=xiaopei01@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome