From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f11.google.com (mail-pj2-f11.google.com [74.125.227.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F1CE3750D7 for ; Fri, 31 Jul 2026 07:06:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785481595; cv=none; b=D6dTvHDRACzwzoqYn/cdUOkxlOl70QtUU8uAW/L+k4xC7RQ+avGbX+P2JsOwoN5f0o50vW26yatGzPoGJ9IFTUlb2fUMMiWsXNblP7Mf3utzge40GwXb7S/yBisoe0ovtSitmHq7TXHJy7pnTcbduI9IkbGSeWgbZINh+ppv+n4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785481595; c=relaxed/simple; bh=kgH+Unk5jFkTbBsM5Q2SSn1BubqFz43+w/4uwL0fHis=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d/KRwQEhpJeHNk4suWRpUZZlSQYUoyC+zxEho1X4DWaERH4NACW9MNlVjFDGgNOrmR4I+gnPZzSIr+Hu5GAJMzX1qrMIsNHvHli2z7p9G+NYCGpV/fU31lpoeUY896k5HNdpELvxZwBW6LuzLuPq0cgm9X81W/r3lNgS/KRlhxQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CY92gw/w; arc=none smtp.client-ip=74.125.227.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CY92gw/w" Received: by mail-pj2-f11.google.com with SMTP id d9443c01a7336-2cf02ecb572so5592975ad.1 for ; Fri, 31 Jul 2026 00:06:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785481593; x=1786086393; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rfHEkC18UILYbYSRhqGinmN4Aeu2njCcFmZPfPXNvtQ=; b=CY92gw/wJ4wbXjDl6tON3ZDQPISRIRthw+JmtQ5M4zh0nx7xIer4AHZTxKoTF8Mx6Y zFxk2Ua0TYN8BmqOQR1BFbm0LWtJIs1KFvecNZoxcpF9AtvA4DdND0ipvxAYr7ObFP/Z VFQapicUQ1483dXpOHnp9VFjGMVP9els8rHcY98o6hFoQqz7GRtbh9/lxayI1YAn1Qyp l7bOLCRT8vGLl+ebFzvx2xt/rzkw8u/X1gBVo9EoCtA7XHSFIeS10pmmaMP2pqDJghrb MbTPIPLwmlkSsg+S5RuKRgYSv3GPXP0ycNlzN7AatCvGkQs2dY9I/lgReBnqj22xlMVN T8Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785481593; x=1786086393; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=rfHEkC18UILYbYSRhqGinmN4Aeu2njCcFmZPfPXNvtQ=; b=HGyTe6vMGc6gLAOMM7AxYIB9jdG/ASlp8cTZLeyxbRKdpe7D6wgi8itUIFp078cXkF 2tLlWsarEMzHo3Gv4dW672RiJlSmZPz/gLYm+sMeZt6LGt4Ee1oqrues5b+yQ/F3rLwo eWyt8J1FGov0/is4PyBCrCk6R4Kner3Y4vG86FtozEvSvz+QPEOchlnzy3MjpKjitpkA Sc+FiUnt5XzmheiUBXufiBRvPx0XOOhFR298pUt8NssARDhKeDlWW+cOeMq1olOQv2zI KMMR7ioMOkAoC124SvPtd+bEW8Ek1fELD1HqwAJUX3kYVbYSp/a400cMxp59ZjKvxwyu 619A== X-Forwarded-Encrypted: i=1; AHgh+RoH0Z7HeLgGe3RSfz2C+b9WZdhiHjIdif6cHkNKMl4MizSxAU8Z4tSLKY8Yq7Z/XlKqWXiQ+2SaWPVgAss=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9lbRXaeO+4fio3ftdBMViicGqyugpYCmcU2KhCyD2mMrDLl4F NE+GvaCdEbcwoqxCv56byNau5+O5Ya34Ci4Ia0d6DcTkRZvaLrnPl8JR X-Gm-Gg: AR+sD11eI9PMYW2a+PXVaynRB7/fAehJX1xu//TDSLWrh1SYGb642YNYjTzWBC4bdyU zaJrJOnpm5pbpR6znLjUBaXMkhyyHvXM5baZfSeIHes9khwvKiluTLhkDQfF6QIydvlYQBpuq4F 3HValgHUIt55UYWUjdPD44O6b/31qbSEmb4J0Tg+V9MvuuLtIWxW5jZPhats3HZACLcvkGVJfdH 0eXV6qBO5FacT/0kKpMJfvdY1czDQpkbhpciq1L0A8K0YsnlBto3I+GyncjnIJ3F9ObU1lETx5t 3x5HgPrlPlln3VNAD6oe9vGQlD8Yw/Y4J4P7q5dsIs/j4uBxMN9O6gEAs6tsHHvX/7w70wn5BDk 7TSgojRTNVYfWrwFQIJZb/Hf55DY3f7QuCMZDJvwOBR2TEIAXdVLbeF2nIB4koybbrHNHFjEX5B hHRq4jb/Fizq7aMvMOD4XjwTwcBMQE4CJ9nythHabtuLknlgtvfqn5Kpk70PC6jp0FGIlc5wsAw Tv0HqT2xGswv4hPncbB X-Received: by 2002:a17:903:1211:b0:2ca:5970:732d with SMTP id d9443c01a7336-2d046ebb185mr10052965ad.41.1785481592613; Fri, 31 Jul 2026 00:06:32 -0700 (PDT) Received: from localhost.localdomain ([76.86.179.124]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c96asm2589587eec.7.2026.07.31.00.06.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 00:06:32 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: error27@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 3/3] staging: rtl8723bs: convert dump mgnt path to errno Date: Fri, 31 Jul 2026 07:05:46 +0000 Message-ID: <20260731070546.20959-4-dennylin0707@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731070546.20959-1-dennylin0707@gmail.com> References: <20260731070546.20959-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert dump_mgntframe_and_wait() to return errno-style values and update its declaration in rtw_mlme_ext.h. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 13 ++++--------- drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index 0027f9333738..da74184fd07e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1971,9 +1971,9 @@ void dump_mgntframe(struct adapter *padapter, struct xmit_frame *pmgntframe) rtw_hal_mgnt_xmit(padapter, pmgntframe); } -s32 dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *pmgntframe, int timeout_ms) +int dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *pmgntframe, int timeout_ms) { - s32 ret = _FAIL; + int ret; unsigned long irqL; struct xmit_priv *pxmitpriv = &padapter->xmitpriv; struct xmit_buf *pxmitbuf = pmgntframe->pxmitbuf; @@ -1983,19 +1983,14 @@ s32 dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *pmgntfr padapter->bDriverStopped) { rtw_free_xmitbuf(&padapter->xmitpriv, pmgntframe->pxmitbuf); rtw_free_xmitframe(&padapter->xmitpriv, pmgntframe); - return ret; + return -ENODEV; } rtw_sctx_init(&sctx, timeout_ms); pxmitbuf->sctx = &sctx; ret = rtw_hal_mgnt_xmit(padapter, pmgntframe); - if (ret) - ret = _FAIL; - else - ret = _SUCCESS; - - if (ret == _SUCCESS) + if (!ret) ret = rtw_sctx_wait(&sctx); spin_lock_irqsave(&pxmitpriv->lock_sctx, irqL); diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h index 0c2bd51b6bc2..c2993e442d80 100644 --- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h +++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h @@ -533,7 +533,7 @@ void update_mgnt_tx_rate(struct adapter *padapter, u8 rate); void update_mgntframe_attrib(struct adapter *padapter, struct pkt_attrib *pattrib); void update_mgntframe_attrib_addr(struct adapter *padapter, struct xmit_frame *pmgntframe); void dump_mgntframe(struct adapter *padapter, struct xmit_frame *pmgntframe); -s32 dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *pmgntframe, int timeout_ms); +int dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *pmgntframe, int timeout_ms); s32 dump_mgntframe_and_wait_ack(struct adapter *padapter, struct xmit_frame *pmgntframe); void issue_beacon(struct adapter *padapter, int timeout_ms); -- 2.43.0