From: Andrew Morton <akpm@linux-foundation.org>
To: Joseph Qi <joseph.qi@linux.alibaba.com>
Cc: Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
Heming Zhao <heming.zhao@suse.com>,
ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ocfs2: fix circular locking dependency in reflink
Date: Fri, 31 Jul 2026 11:21:36 -0700 [thread overview]
Message-ID: <20260731112136.803da03ad3dd3ed119e88262@linux-foundation.org> (raw)
In-Reply-To: <20260731113425.4130293-1-joseph.qi@linux.alibaba.com>
On Fri, 31 Jul 2026 19:34:25 +0800 Joseph Qi <joseph.qi@linux.alibaba.com> wrote:
> Lockdep reports a possible deadlock involving ip_alloc_sem,
> j_trans_barrier, and ip_xattr_sem:
>
Cool.
Sashiko said a couple of things:
https://sashiko.dev/#/patchset/20260731113425.4130293-1-joseph.qi@linux.alibaba.com
> Fix by swapping the lock order in both functions to acquire
> ip_alloc_sem before ip_xattr_sem, consistent with the rest of the
> codebase.
>
> Fixes: 09bf27a00020 ("ocfs2: Implement ocfs2_reflink.")
> Fixes: 8b2c0dba5159 ("ocfs2: Call refcount tree remove process properly.")
Should we backport this into -stable kernels?
next prev parent reply other threads:[~2026-07-31 18:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 11:34 Joseph Qi
2026-07-31 18:21 ` Andrew Morton [this message]
2026-08-02 13:02 ` Joseph Qi
2026-08-04 6:46 ` Joseph Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260731112136.803da03ad3dd3ed119e88262@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=heming.zhao@suse.com \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®