From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 100473FAE11 for ; Fri, 31 Jul 2026 11:37:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785497829; cv=none; b=DoxFQBEHHrsGQzCPgn2uIA1Mncz9P0iKLpgJABhx7Fi9qj7AURdcsEgKyR4xtU0L0PAVBxXPmhRg4GLFxPdG6chTKjzJoY5Urm4xnVUPeowoAq/NenWWKQHl4TZPhW40hHklCFlsYCWnS/PWZ7OeAP5cBNWnI/Ai3hvi2pRGebA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785497829; c=relaxed/simple; bh=utgrkcrPEexnwKubYxzeT83rM8IkZKoDxi9jYmOHcaA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BtqKmNdSVPf7ExO04iPvpRSh4HU2fmp/ofZJKDAED1EKlF/TIvchE5ybI85Ble+FR4UfXZOC4J5H93Bm1q4+3QuUDKy9pusXgl1MDbFrZvOn2Pe9HeR/Jz9laLttrruorSko8bYHo+iPsxu0v9w3Hg+WgUeF6lGd8WG3kVq1D94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bVsyJL0i; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bVsyJL0i" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-47f92e3c14bso175965f8f.0 for ; Fri, 31 Jul 2026 04:37:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785497822; x=1786102622; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NbqFKXAPXCgqFlzsfbnx5DNlo8ULOW4jbUhFKit/7gU=; b=bVsyJL0iA1ILDrQepRgEpqQNOPuwkNzhvXYcEx5ESXDi44zEYYSGlwME8ecqFNVOn+ LMoHcPanl7RD/WZOh+zci0B7M+w7KuS4UDhiAj/Nx33nM9TWb6gizZneGDH1mWs6UL0g FGuy5AuoWbUdLAMpaITzdx/obza62VLz7reFi/BRy98xqZ558/n7c3euCCqjbhHlCV/3 VBSf1lUJSXxP1aC9U8Nt//L2WPoBq1KaYlWzpTho8Mi9j8XT4GJ1c361IpzoCgSylCzi EcIwsi6JEKKW/MoJzc9V+isAXWy7meSh+qSCLfEHIXbP+eD1TFIfRPH2EzB8vA5b/4iu oFhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785497822; x=1786102622; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=NbqFKXAPXCgqFlzsfbnx5DNlo8ULOW4jbUhFKit/7gU=; b=Wj+635C1jILAIUdWokjVucm5heJzTo/LobZpUEla3cHeOj5SgYEYDsIi9qMfsPCWXv QqEj7j0+pVOr1jVEztrudJvhAC8Y2b8QQfd6kkuYnNjxa4nGDiRsDc3dyqCTwyQ0UrVW AJNx6k12p6kVB9x+X2B8RT6dtMzWYRTm0Y08XaJOsy8b11abXfWY/SVb5yJemYD8AAj4 Ph6vwXmJEhsx2RGALlkpj4RhoIm2oIKHYED702pKYy077s25USEa2V3cD0qnn/0iS9gL a7UclSmb3yQhdMelRxHQtSrxoC73u3GCmz3eJaCzLFRxI9h7QjQMVHUGfziYFjxmTmXy dqyg== X-Forwarded-Encrypted: i=1; AHgh+RrVGkxEFBUKVadmymSo0v0d93A6je7qMhlsuPXWYtitNiDLfgDXwmQpeMhPIBiYSgD5pCE48518yt7hQUA=@vger.kernel.org X-Gm-Message-State: AOJu0Ywh4Xd95sJC+gX5ixbY/2WeNnw17sLSnEPNrU6e2V5xbs+I3gZ0 Ady8aSms5J0+M/XBXGHQR2Ek8HAyY+Qq0cd+UuKED6QeiTtobhhd1NpayGeTBQ== X-Gm-Gg: AR+sD110syUEnaiS3I46LNz/As+BIrBBFSay/d4U/b5rXWjpy2vaKiuJcOd99rXIMFu SYM1GxW5V7cOMTjMM1jaAua6DP/U1pm6bWcX1t7bC/fxAv5pDKvN6wIYU5hHqaV9MheM/3eFqFJ O+XDWkjlx6gPfHCWdP86pIdysKPY+7P2HtLpXkky+mci1rgVD7h7BGlFr1ADKFo/uENdDO/gW5s CkvbKvnrEkfptZj1Pipy79dJ20Fwwjdbkr2j734+VaNz0zVmp712CxZ3GRtbxBb+dkpzra5oqea /rkW8X4UDNYMVcJOm/lVPgnfX/gK4DjOWkqlVClRXGx2SOhynXt+ily7uWkCj+D/xMmveedcVgL TER57XXKVJCvgc0kyYO+zp+KE1oS78r39GUsvDaECXX09eyt9BO43aRcDHqmVD/b1H6KGpXuosI 5uJ6uZ3u2cE4dDOFuElU5AgswcT7B6+edHqIwx3cBJyliYMwWGFqVNkYIPHoo/PiuCklfHiXqeM Ttf8L6LCg== X-Received: by 2002:a05:6000:2997:20b0:47f:9661:6766 with SMTP id ffacd0b85a97d-47fd2b9824emr2824366f8f.61.1785497822299; Fri, 31 Jul 2026 04:37:02 -0700 (PDT) Received: from xeon ([188.163.112.51]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd45a0c8bsm3670646f8f.34.2026.07.31.04.37.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 04:37:01 -0700 (PDT) From: Svyatoslav Ryhel To: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Helge Deller , Svyatoslav Ryhel Cc: Johan Hovold , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, mfd@lists.linux.dev, linux-fbdev@vger.kernel.org Subject: [PATCH v6 06/14] mfd: lm3533-core: Remove redundant pdata helpers Date: Fri, 31 Jul 2026 14:36:24 +0300 Message-ID: <20260731113632.158440-7-clamor95@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260731113632.158440-1-clamor95@gmail.com> References: <20260731113632.158440-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The lm3533_set_boost_freq() and lm3533_set_boost_ovp() functions are used only in lm3533_device_setup(), which in turn is only called by lm3533_device_init(). Incorporate their code directly into lm3533_device_init() to simplify driver readability. Signed-off-by: Svyatoslav Ryhel --- drivers/mfd/lm3533-core.c | 61 ++++++++++----------------------------- 1 file changed, 15 insertions(+), 46 deletions(-) diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c index f9bdc0a1d9bec..5baf934fac825 100644 --- a/drivers/mfd/lm3533-core.c +++ b/drivers/mfd/lm3533-core.c @@ -7,6 +7,7 @@ * Author: Johan Hovold */ +#include #include #include #include @@ -23,10 +24,7 @@ #define LM3533_BOOST_OVP_MASK 0x06 -#define LM3533_BOOST_OVP_SHIFT 1 - #define LM3533_BOOST_FREQ_MASK 0x01 -#define LM3533_BOOST_FREQ_SHIFT 0 #define LM3533_BL_ID_MASK 1 #define LM3533_LED_ID_MASK 3 @@ -80,35 +78,6 @@ static struct mfd_cell lm3533_led_devs[] = { }, }; -static int lm3533_set_boost_freq(struct lm3533 *lm3533, - enum lm3533_boost_freq freq) -{ - int ret; - - ret = regmap_update_bits(lm3533->regmap, LM3533_REG_BOOST_PWM, - LM3533_BOOST_FREQ_MASK, - freq << LM3533_BOOST_FREQ_SHIFT); - if (ret) - dev_err(lm3533->dev, "failed to set boost frequency\n"); - - return ret; -} - - -static int lm3533_set_boost_ovp(struct lm3533 *lm3533, - enum lm3533_boost_ovp ovp) -{ - int ret; - - ret = regmap_update_bits(lm3533->regmap, LM3533_REG_BOOST_PWM, - LM3533_BOOST_OVP_MASK, - ovp << LM3533_BOOST_OVP_SHIFT); - if (ret) - dev_err(lm3533->dev, "failed to set boost ovp\n"); - - return ret; -} - /* * HVLED output config -- output hvled controlled by backlight bl */ @@ -406,18 +375,6 @@ static int lm3533_device_led_init(struct lm3533 *lm3533) return 0; } -static int lm3533_device_setup(struct lm3533 *lm3533, - struct lm3533_platform_data *pdata) -{ - int ret; - - ret = lm3533_set_boost_freq(lm3533, pdata->boost_freq); - if (ret) - return ret; - - return lm3533_set_boost_ovp(lm3533, pdata->boost_ovp); -} - static int lm3533_device_init(struct lm3533 *lm3533) { struct lm3533_platform_data *pdata = dev_get_platdata(lm3533->dev); @@ -437,9 +394,21 @@ static int lm3533_device_init(struct lm3533 *lm3533) lm3533_enable(lm3533); - ret = lm3533_device_setup(lm3533, pdata); - if (ret) + ret = regmap_update_bits(lm3533->regmap, LM3533_REG_BOOST_PWM, + LM3533_BOOST_FREQ_MASK, + FIELD_PREP(LM3533_BOOST_FREQ_MASK, pdata->boost_freq)); + if (ret) { + dev_err(lm3533->dev, "failed to set boost frequency\n"); goto err_disable; + } + + ret = regmap_update_bits(lm3533->regmap, LM3533_REG_BOOST_PWM, + LM3533_BOOST_OVP_MASK, + FIELD_PREP(LM3533_BOOST_OVP_MASK, pdata->boost_ovp)); + if (ret) { + dev_err(lm3533->dev, "failed to set boost ovp\n"); + goto err_disable; + } lm3533_device_als_init(lm3533); lm3533_device_bl_init(lm3533); -- 2.53.0