mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Leandro Ribeiro <leandro.ribeiro@collabora.com>
To: dri-devel@lists.freedesktop.org
Cc: airlied@gmail.com, broonie@kernel.org, daniels@collabora.com,
	jani.nikula@linux.intel.com, maarten.lankhorst@linux.intel.com,
	miguel.ojeda.sandonis@gmail.com, mripard@kernel.org,
	pekka.paalanen@collabora.com, simona@ffwll.ch,
	penguin-kernel@I-love.SAKURA.ne.jp, tytso@mit.edu,
	tzimmermann@suse.de, ville.syrjala@linux.intel.com,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/1] drm: use drm_warn() in validate_blend_mode_for_alpha_formats()
Date: Fri, 31 Jul 2026 12:42:32 -0300	[thread overview]
Message-ID: <20260731154232.37020-2-leandro.ribeiro@collabora.com> (raw)
In-Reply-To: <20260731154232.37020-1-leandro.ribeiro@collabora.com>

Commit 860e748bddcc ("drm: ensure blend mode supported if pixel format
with alpha exposed") introduced a WARN() to let driver developers know
that a previously valid behavior should now be changed.

But WARN() should not be used for that, as it's a kernel warning report
mechanism for conditions that are not expected to happen. It also
produces a stack trace. Instead, a simple warning-level log message
should have been used, as drivers were expected to trigger the
condition.

This is causing problems for fuzzers, as they may stop when encountering
a "BUG:" or "WARNING:" in the logs.

Replace WARN() with drm_warn() in this function, avoiding these issues.

Fixes: 860e748bddcc ("drm: ensure blend mode supported if pixel format with alpha exposed")
Signed-off-by: Leandro Ribeiro <leandro.ribeiro@collabora.com>
---
 drivers/gpu/drm/drm_mode_config.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c
index 3bcc7bf0900c..cff347c723ef 100644
--- a/drivers/gpu/drm/drm_mode_config.c
+++ b/drivers/gpu/drm/drm_mode_config.c
@@ -869,8 +869,9 @@ static void validate_blend_mode_for_alpha_formats(struct drm_plane *plane)
 	for (i = 0; i < plane->format_count; i++) {
 		fmt = drm_format_info(plane->format_types[i]);
 		if (fmt->has_alpha) {
-			WARN(1, "[PLANE:%d:%s] pixel format with alpha exposed but blend mode not setup",
-			     plane->base.id, plane->name);
+			drm_warn(plane->dev,
+				 "[PLANE:%d:%s] pixel format with alpha exposed but blend mode not setup. Please fix.",
+				 plane->base.id, plane->name);
 			break;
 		}
 	}
-- 
2.55.0


  reply	other threads:[~2026-07-31 15:43 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-31 15:42 [PATCH v2 0/1] " Leandro Ribeiro
2026-07-31 15:42 ` Leandro Ribeiro [this message]
2026-08-06 13:14   ` [PATCH v2 1/1] " Tetsuo Handa
2026-08-13 14:46     ` Tetsuo Handa
2026-08-14 13:44       ` Daniel Stone
2026-08-14 13:42   ` Daniel Stone
2026-08-27 11:25     ` Viktor Jägersküpper
2026-08-27 12:30       ` Maxime Ripard
2026-08-27 13:28         ` [PATCH 00/11] mm/cma: charge cma allocation to memcg using per area counters Maxime Ripard
2026-08-21 18:56 Eric Chanudet
2026-08-21 18:56 ` [PATCH 01/11] mm/cma: drop const for struct page on release API Eric Chanudet
2026-08-21 18:56 ` [PATCH 02/11] mm/cma: include linux/cma.h in cma.h Eric Chanudet
2026-08-21 18:56 ` [PATCH 03/11] cgroup: add memory_cma_accounting mount option Eric Chanudet
2026-08-24  7:02   ` Maxime Ripard
2026-08-24 22:03     ` Eric Chanudet
2026-08-21 18:56 ` [PATCH 04/11] memcg: add cma charge/uncharge functions for area counters Eric Chanudet
2026-08-21 18:56 ` [PATCH 05/11] mm/cma: charge cma allocation to memcg per " Eric Chanudet
2026-08-21 18:56 ` [PATCH 06/11] memcg: register per-area usage counters in cgroupfs Eric Chanudet
2026-08-21 18:56 ` [PATCH 07/11] selftests: cgroup: add cma configs for cgroup selftest suite Eric Chanudet
2026-08-21 18:57 ` [PATCH 08/11] selftests: cgroup: add memcg cma tests Eric Chanudet
2026-08-21 18:57 ` [PATCH 09/11] selftests: cgroup: add a vmtest script for memcg Eric Chanudet
2026-08-21 18:57 ` [PATCH 10/11] selftests: cgroup: add memcg hugetlb_cma tests Eric Chanudet
2026-08-21 18:57 ` [PATCH 11/11] selftests: cgroup: amend vmtest-memcg to run the hugetlb cma tests Eric Chanudet
2026-08-23  7:02 ` [PATCH 00/11] mm/cma: charge cma allocation to memcg using per area counters Mike Rapoport
2026-08-24 21:58   ` Eric Chanudet
2026-08-25  7:40     ` Michal Hocko
2026-08-24  8:58 ` Michal Hocko
2026-08-25 14:47   ` Eric Chanudet
2026-08-25 14:59     ` Michal Hocko
2026-08-25 18:33       ` Eric Chanudet
2026-08-25 19:19         ` Michal Hocko
2026-08-25 20:58           ` Eric Chanudet
2026-08-26  8:04             ` Michal Hocko
2026-08-26 20:31               ` Eric Chanudet
2026-08-27 14:03                 ` Michal Hocko
2026-08-25 15:45     ` David Hildenbrand (Arm)
2026-08-25 16:26       ` Michal Hocko
2026-08-25 18:50         ` Eric Chanudet
2026-08-26  8:02           ` David Hildenbrand (Arm)
2026-08-26 20:15             ` Eric Chanudet
2026-08-24 13:18 ` Michal Koutný
2026-08-25 14:54   ` Eric Chanudet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260731154232.37020-2-leandro.ribeiro@collabora.com \
    --to=leandro.ribeiro@collabora.com \
    --cc=airlied@gmail.com \
    --cc=broonie@kernel.org \
    --cc=daniels@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=mripard@kernel.org \
    --cc=pekka.paalanen@collabora.com \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=simona@ffwll.ch \
    --cc=tytso@mit.edu \
    --cc=tzimmermann@suse.de \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®