From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f1.google.com (mail-pj2-f1.google.com [74.125.227.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D633D42E8EA for ; Fri, 31 Jul 2026 15:52:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.129 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785513173; cv=none; b=czE9W1JeONyHauPfxP9Cl80OTv1EMcc/aFnVXz0x5uEitxXaqltKeCLFtfzYtFM2M9xh3XVJAcyvUs2sLM0nBNJJ9APdPEDPizcW/np9r+ot6TlXqR+yfYEt9L165AwylsRb+PSxyY2OqoexAYMS2+0LKc8/l/BrdM2MSGXmf70= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785513173; c=relaxed/simple; bh=a0+Z9k6sMPSnzJ+y4Vd/U9aGI8y7mXfbpjtyaBPpXhM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=A8OD9NVhMZ36qN7B1//J/7df9FVyCerDlgCabjlBKvW+YIXVveJNTcM3U+CPaQBxwK3uCxdBjdMbxVNFss+0Wm7DkXjePHY1kOojh3eX02OaTL8xeRh2mq4luJkBOzNUn84FyksRXjLiQkgEmdRxZYSz1xUdm6nYtHPTpvRLzwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aQ/pFXQ5; arc=none smtp.client-ip=74.125.227.129 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aQ/pFXQ5" Received: by mail-pj2-f1.google.com with SMTP id 98e67ed59e1d1-381072761d4so720385a91.0 for ; Fri, 31 Jul 2026 08:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785513170; x=1786117970; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=k6xscdSdqtSuRhxAG9/cpxfE7oRD8F29mqyv1hfzFk0=; b=aQ/pFXQ5XkNIh5NfbcvI0+tcRBUYzkBN3I3ChoztNcuDOfd687J6sNraw3235OUTDS K2WDE1QrjQIBZoC2ubmJkzdsLfVQN6t6gCYuve4NZIWouvQPR9SADKXdgzSIIj4DyF0o ODm8DZ1P1KJFMaCTXcHFcQs5aGJ5nzw1IXNqXw4IDu2PLAiWIuX7GiJsAyNDsWQclAsQ KSamRv8pkK1ZSM9X56WckPzNfw0O7uBQe7VyHqSGCupVXU8PCfw4I9HdCOJxf+GaxT/p E20k734jOAMd0Np43xlHwWUWXUFOjQG7Lpw18iGNvS8TjFszE7L5UrWmcGdMZKX7ef68 cOBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785513170; x=1786117970; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=k6xscdSdqtSuRhxAG9/cpxfE7oRD8F29mqyv1hfzFk0=; b=rI2H/Eyk7UCD9hMbX8KkXk1NW2PhYJE+dB3h929SvTiprSmjj0WAZkiJlc0cxYtnTP whhse+IdYz35JGBJ75Rwu3R+TPD9qwzhPn4tmRUjVxacIwTwaRE2it9kvTXkS5G7MQnd HTea0FnqNZ+25JP/BfHP/fwM0klu9DzZVj2bQ5UOP9mtikO67r87WFJW6gkCTP+s8Jn1 adoZbOGwmz678+8ToAupgWkZHoAb2+AW0qy2URlTpf21gcT+WlwVcggAtaMi3JdTGUPP D7ZYZTnwfAfD4O7l4g+NSqe3vgFyHKnnC3ax0LgeJGNHJVSIwnhO7CiK5/3MOR25Bwxz KW/A== X-Forwarded-Encrypted: i=1; AHgh+RoO8t3zNtQQGyyBpuz9O8TV486sBwEhqwKImUWdrOU/b2Ift53zQ7MVPglJo1De8OHU3hlETbuuTrhigIg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5t79lfxgce7aIP7ICyueA2W13Cz1O2F3D2XeiJ4US6gApN6cG uJ3eCb+XWLyWxywXrPzCEZUHW9VH4+cFBuIPlR6WKNcye0LyyXJlrpjV X-Gm-Gg: AR+sD10EiKQXSgP/BwXQngRNjNrXvNM3XYKpB0MQTLA2NsKGhdqkDZQ/1Icf21CbVea cZCqICAjwEe1mkYwFgx6Y9Dr5+DYF/FSIeVjNVPLM3M39o3x6ZDn+fEPS422OdfDCmIdSqYV+fZ qrFPug+/Q+2xbYzwmbRQhtpKJXSjl9JpwltwkZ/0ZNfb9+9Y+JZnPRAiRcU1EAsdko5qGoZFA9G wRol8g1M8YBPnlb/mB5gSdlOBaw9+AljMN+kACzuL/pB0HSEFDxuau7uPJ8iDPptBwFQF0kCzdY rsAjzaT4CKCCwRpnq8P6J7ihX71qwnjDF5pn3dIXxvD5xCKSd1+2Q2On92JvNGvo79VakHsiCKL rgs1jnycfexTYCB8pATF7MpZPQrdcSZJQnBmIzEExQefqSma6qj9J9SlbOoCUyH5n6BP3ZQoDX+ 9skLXkTrZ5oJETxfcowtTH17Tv06mfpvjRNuNMH+03FE1dgaNdTx6Dew2teF/FMQPG+Kyvwy+wO oCRTGZ/m0wb7TSX6bgg X-Received: by 2002:a17:90b:5102:b0:38e:4b71:8b0 with SMTP id 98e67ed59e1d1-38fbc4ff425mr387767a91.25.1785513170338; Fri, 31 Jul 2026 08:52:50 -0700 (PDT) Received: from localhost.localdomain ([76.86.179.124]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c96asm7669604eec.7.2026.07.31.08.52.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 08:52:50 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, error27@gmail.com, Hungyu Lin Subject: [PATCH v2 1/3] staging: rtl8723bs: convert mgmt xmit coalesce to errno Date: Fri, 31 Jul 2026 15:52:26 +0000 Message-ID: <20260731155228.22526-2-dennylin0707@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731155228.22526-1-dennylin0707@gmail.com> References: <20260731155228.22526-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Change rtw_mgmt_xmitframe_coalesce() to use kernel-style return values. Return 0 on success and negative errno on failure. The only caller currently doesn't check for errors, so this change does not affect runtime behavior. Later patches in this series will propagate error handling to the caller. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 8 ++++---- drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 16e6c9567224..01512f438295 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1187,7 +1187,7 @@ int rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, struct } /* broadcast or multicast management pkt use BIP, unicast management pkt use CCMP encryption */ -s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, struct xmit_frame *pxmitframe) +int rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, struct xmit_frame *pxmitframe) { u8 *pframe, *mem_start = NULL, *tmp_buf = NULL; u8 subtype; @@ -1210,7 +1210,7 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, s BIP_AAD = kzalloc(ori_len, GFP_ATOMIC); if (!BIP_AAD) - return _FAIL; + return -ENOMEM; tmp_buf = BIP_AAD; subtype = GetFrameSubType(pframe); /* bit(7)~bit(2) */ @@ -1341,12 +1341,12 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, s xmitframe_coalesce_success: spin_unlock_bh(&padapter->security_key_mutex); kfree(BIP_AAD); - return _SUCCESS; + return 0; xmitframe_coalesce_fail: spin_unlock_bh(&padapter->security_key_mutex); kfree(BIP_AAD); - return _FAIL; + return -EINVAL; } /* Logical Link Control(LLC) SubNetwork Attachment Point(SNAP) header diff --git a/drivers/staging/rtl8723bs/include/rtw_xmit.h b/drivers/staging/rtl8723bs/include/rtw_xmit.h index 917e846e9ce2..31decc210e73 100644 --- a/drivers/staging/rtl8723bs/include/rtw_xmit.h +++ b/drivers/staging/rtl8723bs/include/rtw_xmit.h @@ -424,7 +424,7 @@ int rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxmitfram extern u32 rtw_calculate_wlan_pkt_size_by_attribue(struct pkt_attrib *pattrib); #define rtw_wlan_pkt_size(f) rtw_calculate_wlan_pkt_size_by_attribue(&f->attrib) extern int rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, struct xmit_frame *pxmitframe); -extern s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, struct xmit_frame *pxmitframe); +extern int rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, struct xmit_frame *pxmitframe); s32 _rtw_init_hw_txqueue(struct hw_txqueue *phw_txqueue, u8 ac_tag); void _rtw_init_sta_xmit_priv(struct sta_xmit_priv *psta_xmitpriv); -- 2.43.0