From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f1.google.com (mail-pz2-f1.google.com [74.125.228.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 922624457D4 for ; Fri, 31 Jul 2026 15:52:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785513175; cv=none; b=Cs8bMn9WtsfcK1z1Z/IXu/5hqbP/f3oaaVOeF/voLqQ8p5ZTG1EpPhR2a4S9sg9b5bwIw3pJTctRnWUbGLdtdvu5rB4STbrQtPn/Zw/AgRUA+EyJX+fvI/tZNlVdW9Nqj0tkQDclPIyd8aq9KqgGqkpDG72hPo48Ouqn9lfOrb0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785513175; c=relaxed/simple; bh=dl/mkrgMeB9TSEWmDgogvhLnGMjB3saQNaK8XEddEdw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TVZ9aqp6q3qVjF93zYNUWCYn9XJuTNZmFFNniPBNprvpPd/Q3ja24qOxR8Ej/dZFUgR0bBFCgiMNNxTWNoQc9dyia4wzwVkbuFs9Qv9/BKA3EFKH/UG9+lPq+5NxijaYzgk9kLvmRGMANwHOLOkDPa70TmR1hPyonYPh1pojL4A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SeeML4V0; arc=none smtp.client-ip=74.125.228.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SeeML4V0" Received: by mail-pz2-f1.google.com with SMTP id 41be03b00d2f7-ca696c4b152so346537a12.1 for ; Fri, 31 Jul 2026 08:52:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785513172; x=1786117972; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SgxSm8O2Ph/vh7farPcof8o4aTta2ebVjrMlcZ8XUVI=; b=SeeML4V0382/yPLdjiyE407VioQMn3jwwoLW9G9Z2r3tIuXdXPSSBOD9E/Cyb2NQn0 vl8GzEmr+bXCtr+E6/M3HWlOO9kUMY4cqUqriXFa0YwJRQi5Z/3umT2E5k6zjks7K2jC 6/2PbJ0ZUo9eIQCk8PxSw45qaIEqHFPRXxkjfKg81yNaa/icZxyqtS3BBMFtPzhP9Wj4 fB9CLFM7PikJDu1apU9POOuu9DWCcPogZBWu9gNSDsoU4BlF4+HdRyPMMZjoPZW4JjU5 +KSlm5O/R6htYLkTG3Gngi+FDPGTXnx8j65ScjkOetvZ6q31ILnWtbXkP5lXtPjYIv2w 3siw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785513172; x=1786117972; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=SgxSm8O2Ph/vh7farPcof8o4aTta2ebVjrMlcZ8XUVI=; b=tDucVzC4CdvcnuYz/Q6bk+1xq4wrpVnxM4FQ1uby9x6EK2BQgDcRs+01Vk6XfXhlNa GJ60/TpvJyUh+SRfUq93AgGOKHLcVM4551MEfkAHXOuJgyR3raqDtF66F0sv9aFFTdBi BFrFaMg7RtLDKUXcoPicB+a9h6Q8eXPmzZWykRR6BwD3pQyWwcJelXRWv7j2pHguQd7X D3WsH+xasJJG4dr/r7eXxq0WGzWn9ZC8qCg2V/hzW2TlekRxLDv/bS+kxaTWTjfZwfZP C37ZBGcwElyLglQg/vLKjkxwDVuG8eJP5CcurrTV+laVKJPfW/OA6rGj2wK1ThxIENwH PC/g== X-Forwarded-Encrypted: i=1; AHgh+Ro07c4cdX4vSuPZQWInTH5ReM8v7cKnjs7M6oncCpd5Jt8AGv5Mb+1c9HQ8RSXusgYqpjta9Oc+IyoSLOw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywj7Z2CBphswx5Z71MAdKvz0og5paoxadjuS0rW/jwcPfU1a2cC dYQl66SzishfmOjr6tkq+CQ055osshQ/EUxfcX9bbALQz/4Y1X63VlOC X-Gm-Gg: AR+sD12clmc3ose1JoJPOYub0NIWXYYAA5SsePXOM1+80zmHK62nIaFP7J9A8WLJXRg V6gByUhCm7QIIefMryH9kKdCnIgEK5l3GDbC1npOIr0fUby+oIRbrZzvyQ8CJZcwBVPBw06MIry UsmIFOjmpmju86yQr4HQM1r1+I3DrayFNuZ79NU5t1ZFqhI5sunswGMnI8LrWGMMjSxc373CMrF wyGxJWq1T+XE452hcJLCkG+xW5AIQ1+gZrrXGkEbEULSGmRgT4wk6piL8vApOAzxcK8Qqke+3Of i2I2j3JXJUZ/Wb9R+W048msfJCb6/PV3ENkGNWa0vFXCKdepnQeXbZm99a74bdyJApVVCgq3wxO WRWvUDLIMcSTNXaAhlKL4Uv5z3xHrQGs9FQ8VUqpoPuJikz+Nq8HeRFWOADi9Nf9r9JJnNvVvrl umZN80Bg3KH/C0d0VZxRU15NA/GG/iaZieL7NAdmsFayYJpjDCWUe1b3q2NmFEUB24Bt8O925Fq p4Yd/A1U1loygMY1BBO X-Received: by 2002:a05:6a20:728e:b0:3c0:adec:b3bd with SMTP id adf61e73a8af0-3c92a8a8fb7mr290227637.49.1785513171551; Fri, 31 Jul 2026 08:52:51 -0700 (PDT) Received: from localhost.localdomain ([76.86.179.124]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c96asm7669604eec.7.2026.07.31.08.52.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 08:52:51 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, error27@gmail.com, Hungyu Lin Subject: [PATCH v2 2/3] staging: rtl8723bs: propagate errno handling for mgmt xmit Date: Fri, 31 Jul 2026 15:52:27 +0000 Message-ID: <20260731155228.22526-3-dennylin0707@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731155228.22526-1-dennylin0707@gmail.com> References: <20260731155228.22526-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert rtw_hal_mgnt_xmit() to return errno-style values and update the prototype in hal_intf.h. After this change, dump_mgntframe_and_wait() still uses the return value of rtw_hal_mgnt_xmit() to determine whether it should wait for completion. A follow-on patch will make dump_mgntframe_and_wait() return void since its return value is unused by all current callers. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++++ drivers/staging/rtl8723bs/hal/hal_intf.c | 9 +++++++-- drivers/staging/rtl8723bs/include/hal_intf.h | 2 +- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index f5ab94a2d0a0..0027f9333738 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1990,6 +1990,10 @@ s32 dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *pmgntfr pxmitbuf->sctx = &sctx; ret = rtw_hal_mgnt_xmit(padapter, pmgntframe); + if (ret) + ret = _FAIL; + else + ret = _SUCCESS; if (ret == _SUCCESS) ret = rtw_sctx_wait(&sctx); diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c index 2caade1a8bdd..1443875d1369 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -115,8 +115,10 @@ s32 rtw_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe) /* * [IMPORTANT] This function would be run in interrupt context. */ -s32 rtw_hal_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntframe) +int rtw_hal_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntframe) { + int ret; + update_mgntframe_attrib_addr(padapter, pmgntframe); /* pframe = (u8 *)(pmgntframe->buf_addr) + TXDESC_OFFSET; */ /* pwlanhdr = (struct rtw_ieee80211_hdr *)pframe; */ @@ -130,7 +132,10 @@ s32 rtw_hal_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntframe) pmgntframe->attrib.encrypt = _AES_; pmgntframe->attrib.bswenc = true; } - rtw_mgmt_xmitframe_coalesce(padapter, pmgntframe->pkt, pmgntframe); + ret = rtw_mgmt_xmitframe_coalesce(padapter, pmgntframe->pkt, pmgntframe); + + if (ret) + return ret; } return rtl8723bs_mgnt_xmit(padapter, pmgntframe); diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging/rtl8723bs/include/hal_intf.h index 8a85e8419e47..1b6b348435cb 100644 --- a/drivers/staging/rtl8723bs/include/hal_intf.h +++ b/drivers/staging/rtl8723bs/include/hal_intf.h @@ -197,7 +197,7 @@ u8 rtw_hal_check_ips_status(struct adapter *padapter); int rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxmitframe); s32 rtw_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe); -s32 rtw_hal_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntframe); +int rtw_hal_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntframe); s32 rtw_hal_init_xmit_priv(struct adapter *padapter); void rtw_hal_free_xmit_priv(struct adapter *padapter); -- 2.43.0