From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f2.google.com (mail-pj2-f2.google.com [74.125.227.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A97A044212E for ; Fri, 31 Jul 2026 15:52:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785513177; cv=none; b=JazEOpW7Ub6t1zJFQ//DroVcufr4a1InBFS9KVGQdXPB7ug6Orlg0+G5M57eUmaC2QT1WaT3pQ9wpzXKhBQiGK/+abyFIQsG8TumCpNf46cvYaMb/66k2NgZpYmpZeA8n2V5ByRaxEGGWdCToricbzhDs9/DNKBTnWJo0bWHaDY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785513177; c=relaxed/simple; bh=7fYmSEJo0qt1KsiBzseFp7MKWs4c6z76dKmxrU1GCBk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B5iqSlLI1mLPOMuYyGwecQItNdOhiWcjwx20iitEEt1QAlLgVpCST0qcOYlT1xaOnV5o/r3Sh/t9wxTkjv0Ye9lz8T08eNn4dU4Aq+OJdQ80BP3rL7s1XbK34RsX1/LqimVTDscwQckHtF8WKdMK3hCf3ShYsL+YW9tmpvz4dFg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ockb56CZ; arc=none smtp.client-ip=74.125.227.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ockb56CZ" Received: by mail-pj2-f2.google.com with SMTP id d9443c01a7336-2ccc2e84048so6226425ad.1 for ; Fri, 31 Jul 2026 08:52:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785513172; x=1786117972; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/U/K3yrZZAsmjUNPPmafsMwvP5MWR/doyv5T2RcThE4=; b=ockb56CZchmA/nSZyXBw55O8ji1NcSzH6ZJI9R0mRswT9O2A+22fvgolSrj6pbOPFN yEuOXlxLZVd49w/8uLe74p+q+XTXcqvN/XfQh2/en//daNfjsyu6qsAt/i0Gq59wNr23 bJnkZTpQeEzqvnyMr/p/J+5T8lADEeuzhf+iJTqMql8w+xOEKOSHkkuNUBoF8Dghi2J3 lsEiaMsOXd9qTtXS9p+yKV7fL2+tapyKMkSrSrKTxuhkr9sJU548hN13FyiptBsHy9s1 lH3LaLG7UYY5aaRkXJ1pgVL5uyCf8FQ09tAYvHbD/GedVda01c2N8jLBijtHjc0Sq0Os Ntmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785513172; x=1786117972; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/U/K3yrZZAsmjUNPPmafsMwvP5MWR/doyv5T2RcThE4=; b=d5g/LxOasYt+jPomjV7lWKn1QjUx77Ikn6AevgvepXTgFdAJGOKkOeEPpgwE9AGy4y w8AGHpzfapSFjuFKEzzYmsvjXUcTXjr9Hm+BCpAA2LPbtwT5qU47ZW+dDEESBf3PuKBZ V+W1rRcNdSNpPCAxeOOzbYtWz6VH9jX1YRfdNCi2rRCEFJm0alJfIkHzs8R/jfdJhI7H iY8IzxKGzbrnslX8FKI35uAKQUGHVv+lqCurHdtu7gYpuof1UFhkYIHObaJmXQmxr0ER 5r/ccQCzxMJTdkKyzzSWn1nJfM15pw1HtHVJu9OaHxWgiAjnXE+zXmW1/mXTl/ptgaXD pzEQ== X-Forwarded-Encrypted: i=1; AHgh+Rqqd7dFb/f5PoNvTXyZu6q4Qg5CMedii3VPRlTID33IarDfmlGtsFcw6K7pm28zLrz9T8i48ptjw/+XMsU=@vger.kernel.org X-Gm-Message-State: AOJu0Yyu8LcKVDREj0oa3JtKxwZFFlCm8oxAKL4uCjyBumUVL5FigpiR L9YAcn0ZEv/d/lEUg39sD7wEb7VY46r3ZpdIgBHde9cxORFiq8k46aSSVxerETjM X-Gm-Gg: AR+sD13wGWHKTfPK8Z/aT6uQk4TfGavMS7Sb9qfRvLFy7VYYPxv76YGmSkEzyMkOAeI bV7ePpNft9WuXM8c/nxViwbENwP4k8qWD6TX/VJdO3fUI7c5iCVLqFw15phhV2ge5uXVadB5Ugj IXQTVUcacTkDW102OVPftMfBd0M3SxgeEOJEn1mTm47H7zNP34pqF5SRjPZFywnJ22TSNAyoh/n KLqb3YZikOdyGpuorxLlOWjhb9Ym8tuoxlHs2Wu6Dv64+k7uZ0jnehb9v3wCV3ZAerJXNIi6jCL Quo/IrbPhMKEsiQxb/UGz8ScDnGS0IWeMM/jCYg2mgEFLcerS8VdbLTI0N6/B9TolJUONQqWdHn SMxMylDPZiTuknyx7f/lp+jb5KS4NZto92g+enkTu5kdeIDM6PlSyaNCcTKfNqwGwD1AXfJniQZ uelgFvCutHie5WUi+0Hy7B3U3l8ojBq9c1VlnzXd+noaE6+xJQxRraxYNtSM/fNqdgLj99h+1V0 skN14evMVZYw3dIW5xfIN+nRTys6aI= X-Received: by 2002:a05:6a20:3ca2:b0:3c3:9aff:7a46 with SMTP id adf61e73a8af0-3c92a5d35b9mr351193637.32.1785513172303; Fri, 31 Jul 2026 08:52:52 -0700 (PDT) Received: from localhost.localdomain ([76.86.179.124]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c96asm7669604eec.7.2026.07.31.08.52.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 08:52:52 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, error27@gmail.com, Hungyu Lin Subject: [PATCH v2 3/3] staging: rtl8723bs: make dump_mgntframe_and_wait() return void Date: Fri, 31 Jul 2026 15:52:28 +0000 Message-ID: <20260731155228.22526-4-dennylin0707@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731155228.22526-1-dennylin0707@gmail.com> References: <20260731155228.22526-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The return value of dump_mgntframe_and_wait() is ignored by all current callers. Keep using the return value of rtw_hal_mgnt_xmit() to determine whether to wait for completion. Make dump_mgntframe_and_wait() return void because no caller uses its return value. Suggested-by: Dan Carpenter Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 17 ++++------------- .../staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +- 2 files changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index 0027f9333738..ae760e9c655a 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1971,9 +1971,8 @@ void dump_mgntframe(struct adapter *padapter, struct xmit_frame *pmgntframe) rtw_hal_mgnt_xmit(padapter, pmgntframe); } -s32 dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *pmgntframe, int timeout_ms) +void dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *pmgntframe, int timeout_ms) { - s32 ret = _FAIL; unsigned long irqL; struct xmit_priv *pxmitpriv = &padapter->xmitpriv; struct xmit_buf *pxmitbuf = pmgntframe->pxmitbuf; @@ -1983,26 +1982,18 @@ s32 dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *pmgntfr padapter->bDriverStopped) { rtw_free_xmitbuf(&padapter->xmitpriv, pmgntframe->pxmitbuf); rtw_free_xmitframe(&padapter->xmitpriv, pmgntframe); - return ret; + return; } rtw_sctx_init(&sctx, timeout_ms); pxmitbuf->sctx = &sctx; - ret = rtw_hal_mgnt_xmit(padapter, pmgntframe); - if (ret) - ret = _FAIL; - else - ret = _SUCCESS; - - if (ret == _SUCCESS) - ret = rtw_sctx_wait(&sctx); + if (!rtw_hal_mgnt_xmit(padapter, pmgntframe)) + rtw_sctx_wait(&sctx); spin_lock_irqsave(&pxmitpriv->lock_sctx, irqL); pxmitbuf->sctx = NULL; spin_unlock_irqrestore(&pxmitpriv->lock_sctx, irqL); - - return ret; } s32 dump_mgntframe_and_wait_ack(struct adapter *padapter, struct xmit_frame *pmgntframe) diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h index 0c2bd51b6bc2..73b89832d27a 100644 --- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h +++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h @@ -533,7 +533,7 @@ void update_mgnt_tx_rate(struct adapter *padapter, u8 rate); void update_mgntframe_attrib(struct adapter *padapter, struct pkt_attrib *pattrib); void update_mgntframe_attrib_addr(struct adapter *padapter, struct xmit_frame *pmgntframe); void dump_mgntframe(struct adapter *padapter, struct xmit_frame *pmgntframe); -s32 dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *pmgntframe, int timeout_ms); +void dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *pmgntframe, int timeout_ms); s32 dump_mgntframe_and_wait_ack(struct adapter *padapter, struct xmit_frame *pmgntframe); void issue_beacon(struct adapter *padapter, int timeout_ms); -- 2.43.0