From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 723222E0B5C for ; Fri, 31 Jul 2026 16:17:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785514680; cv=none; b=fHprr3rDd80ubpDi4I3wQ3C5nBi9qPc4FmxMCLwx044bGVB/l8KWI/T4ntyXoK7EjR8690cmUPT6YW4sshSXkFsTx9bqLvBMdn/p42hYE9+/dGCy2zRiBqPusEpYff6uLo1LTHxRbZ9ds5tVWeJazqnfAwI8UxgTrzB3jgDaDVM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785514680; c=relaxed/simple; bh=XiHTps66n/ucoodnksehaJ774Zj8/m6/5WilQKWcYtA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=onJXAUT8NdHWxZvFV3d3O00fPt/0YDrpvj8XGP/V/1dW8xEdFjQXmo4PNOGz1AOSYjh3vxfbBxcOTdG+gWJsRf6YcL1iYKvRrRycQ1XXJViTGDiWqPKfU78t5cobNp3x22zBBoMAzsK8DJNx/qnWtJndkBZ2a5yQk8xJbFInR4w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Oo5UZn3+; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Oo5UZn3+" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38e071ed6aeso1002533a91.0 for ; Fri, 31 Jul 2026 09:17:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785514676; x=1786119476; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=3fpbCGUKoDP5+AiSkirbnxfIufZXR99E39vUIbtAqi4=; b=Oo5UZn3+s/Clcl35L0i27lCyCVRQs4rNgvsX4jWn9B63BU4Cfiev6E38xXtaotn24V klPvlLCVASNsz/qWHRKdPaqj0WfSfn2xjfRsxY/FFpRdcLa+5ukWSVAazMZaw3DxyuB7 lKAkF65rucM2QX3nEbKQm4WcVZ/ZYmWxRwrYy7HWM6hhJv/VFMAEyvjz8EMU6jRYBtW0 W1gwnQMgu70yTMMXnAnKnIYBapLvWDM1hPcEA9Y7dbe2nVR9WD+M1qDIP7XH1bKz6YP+ fNPnEfSm4y/nV5ytL9oXlALzUHKnTLO58RnV/1iLFx+1quqwKbXCUZkrswXfELG/af9S fhHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785514676; x=1786119476; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3fpbCGUKoDP5+AiSkirbnxfIufZXR99E39vUIbtAqi4=; b=Wis4wIlKLfbpdCwGIWThSY45NEU5lNYZOJJ7qQujYbLd5iu5Prpmlxry2Kuxn6Fzyu iq+BY1DN6cjUIo0aDVPa6O6GKP1Yr+fSli80xpq9QDYbANhfqP+voQzMR9w6gYWfrs2y jbM8qYr17rqS49ZlgI16PICpq9obVaZjfETeEB5QsiJvVUouAJFqEnTBCIHF+dO+BM4P 7+qWzl+qKsmeu61winVvQMTntHqruJ4vqtS/nGT9BKU+cLpV00oiwkKJOR9NfupUYcFA 1VPnpIRBIrmHiCXAUAMoaU37xT+cgbjX5iLo2NSYxbJWCOiyT5WA9cEydIlMNL5BQxd4 a52w== X-Forwarded-Encrypted: i=1; AHgh+RpCvlSbtuo47feNb1XjiMOuzTliGvS5YaZXF9l678uBFhuu4fjVAFE70WGjJO/qHInnXA1a8YbMO61GpPY=@vger.kernel.org X-Gm-Message-State: AOJu0Yztw1iCrZfiHaBvQomezMxrYrY57HCM3m2jyTn17x0+IZGqwSsa WBy+CvK9K6pFokQDhwFe8f687doJsp1bKhrEWiet43ZrSpZcTpxdlxg= X-Gm-Gg: AR+sD10e314LsSJy0ZiWAEteLpa7Aadeo07acchozAZT1U1bR1Y1kM14dDO4xstHgaV LyDhC799Ve6EpNvDdt0UxoF4bqSNyfSNckUHOSsUpraGP29dgUjiaFNyroTt/20ou+OhY/sCP0D sS3INoDcnpJsqY+CtDCa8DDurgvcWAoGUzXwerhJwcqY2XAXht+Y/Y7jdwgSvg6ZXEK1juMLu5J ylPDhBKXnVChPDIniRdF1mOE3yee/xnCQ0NY2njZDKZGUahJ/MCPrp+dB9opDzltKagord727Na PNJiGOR+DGBZm41Pq/N2h/HKL41FewKPXN0eoBh1XkRP+yUU/L+Osw7CxVJFtoe0TgDcWPukd+1 758HpGL6/ug39R4ly+loZynrweFiKgJYMf02tonuHLgDeQzFLtbCMGu0vXdN/pryGfPMhJJho0a 8Bcl4/+hMzrXiPx2AcZ0ozSOO5cmgUR/zGlLF0JcigGYPKVgQISjEFH96OvVuPHyDNEqxMyzUmx i62UTe2dkHVmmlLyk5gTJRvhSVKN5//68MxTvELh8ZdXxE2MB1gQPzgkXnCjx2XaoOF9mgSw6Hu Ol/GTNw94hLf99muRDgFT9U= X-Received: by 2002:a17:90b:5824:b0:381:9028:5945 with SMTP id 98e67ed59e1d1-38fbc43a847mr445709a91.14.1785514676249; Fri, 31 Jul 2026 09:17:56 -0700 (PDT) Received: from localhost.localdomain ([1.226.165.54]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38fb2ce1778sm923096a91.15.2026.07.31.09.17.53 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 31 Jul 2026 09:17:55 -0700 (PDT) From: Myeonghun Pak To: Dominik Brodowski Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Myeonghun Pak , Ijae Kim Subject: [PATCH] net: 8390: pcnet_cs: release PCMCIA window on setup_shmem_window() error Date: Sat, 1 Aug 2026 01:17:40 +0900 Message-ID: <20260731161740.44955-1-mhun512@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit setup_shmem_window() acquires a PCMCIA memory window with pcmcia_request_window() and only releases it on the buffer-verification failure path. If pcmcia_map_mem_page() or the subsequent ioremap() fails, the function jumps straight to the "failed" label, which returns without calling pcmcia_release_window(). The requested window is leaked. This is reachable in practice: pcnet_config() treats a setup_shmem_window() failure as non-fatal and falls back to setup_dma_config(), so probe can continue and even succeed while the requested shared-memory window is left allocated. Route the post-request error paths through a new "release" label that calls pcmcia_release_window() before returning, and fold the existing buffer-verification cleanup into it. iounmap() is still performed before the release where an ioremap() mapping exists, preserving the original teardown order. The pcmcia_request_window() failure path still returns directly, as no window is held there. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/net/ethernet/8390/pcnet_cs.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/8390/pcnet_cs.c b/drivers/net/ethernet/8390/pcnet_cs.c index 19f9c5db3f3b..e2081d493749 100644 --- a/drivers/net/ethernet/8390/pcnet_cs.c +++ b/drivers/net/ethernet/8390/pcnet_cs.c @@ -1434,14 +1434,14 @@ static int setup_shmem_window(struct pcmcia_device *link, int start_pg, offset -= offset % window_size; ret = pcmcia_map_mem_page(link, link->resource[3], offset); if (ret) - goto failed; + goto release; /* Try scribbling on the buffer */ info->base = ioremap(link->resource[3]->start, resource_size(link->resource[3])); if (unlikely(!info->base)) { ret = -ENOMEM; - goto failed; + goto release; } for (i = 0; i < (TX_PAGES<<8); i += 2) @@ -1452,9 +1452,8 @@ static int setup_shmem_window(struct pcmcia_device *link, int start_pg, pcnet_reset_8390(dev); if (i != (TX_PAGES<<8)) { iounmap(info->base); - pcmcia_release_window(link, link->resource[3]); info->base = NULL; - goto failed; + goto release; } ei_status.mem = info->base + offset; @@ -1475,6 +1474,8 @@ static int setup_shmem_window(struct pcmcia_device *link, int start_pg, info->flags |= USE_SHMEM; return 0; +release: + pcmcia_release_window(link, link->resource[3]); failed: return 1; } -- 2.47.1