From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B4403B14B8 for ; Fri, 31 Jul 2026 18:02:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785520967; cv=none; b=oGBklvbrScSEm3r6WZPEeyTd5QyzaC0+njiI/xHHYhblKf9pVCLv4K9pOg725vM5ThmVyW0gKAZHL3VvmwtAKBDb5qNyNbtnLBnJopeBFjGlEGbemMkBl8txx9tsSOFy6EZpmxn7jLLz0hQNaY97mciLDEl+TyJsfsxhEZAV9HE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785520967; c=relaxed/simple; bh=YtO2rXXx25ZXQwVLHvxKmGnymhUwgV1qf2abvqYWAyM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VjwRHpabFV/7zIWvRpqq/785dTx8ZSelFsC2/CtWlS9EjGdJGi3SGAxFK+JhpLfgizMU26hAmr5xRgKWSP92hCrGrj12VF9uGqxtjW6dr5G7IIbGEGK89jLXB/QQUMJEO4oa3XCOdY3D7BoGww1oCo6JH4M1uD+zrCH4DMqM3+Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BKeg+Mp6; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BKeg+Mp6" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2caea3f742bso14648095ad.0 for ; Fri, 31 Jul 2026 11:02:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785520964; x=1786125764; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=sYE3C+scMrFEL+N4FLfI74aRM/iIqNWzUAE4xs2TzsY=; b=BKeg+Mp69BXCUELJgTDONsK89a/0dJD5toFTRPndQbZTNx43VPpY3jaRd6XaMd22G3 kFHQtKBHgth836mNlFHc8haTkcWiIVO/MBOmWKdhM2WPTpEEF6qQdw5Yh/8YqbncCBZs OZ3k4YoKDQ4zRQyHUCviXzcjAZ41CzuyGJ9QWGbnjHKpKjkfRuZGvEFaVxRlUuLVdcmL XjCsAICplzaN8cDlXn1Klwr7wgM5A4Xuen9kus81XQOQCTGtWhu1qLKe8CSDYnhPRWGo o7XVuTfm4DrhlR4YRmCAKHyOcOOrfndSkmcZ+1/WrvPQFDGzpmfD4pXUBdybFpNN9Nx0 oykQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785520964; x=1786125764; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=sYE3C+scMrFEL+N4FLfI74aRM/iIqNWzUAE4xs2TzsY=; b=q54bREQ+yrgbrBRBFA/iHNBjZ7rZcFW/m97VaKFohYquWhaKOWwXPGuc46DlCrxWFF xxfadt2ACtyXrtVFl23hETPQTzVMIlTMU0+ioOIxdRPXp3ay/LYDIZPGo44E9bvL17Ll X6sAmcMi2W5dzIdGuLLfJcUC26Z6bA33vXCHFJKWtAKhXnBPSy8b8K19BIsKNlfcEYxR QyzK0qYBkTOJLNDPSn3wYYn6ABl6QoEexgCXfaRcnb0A6J724DhPmMBt4TfOC7t0Kak/ zAHONPjefGAD0Mt/QBL3Else84ozUsUE6A5sSOwovlmQb2rGt+9ro+Fir7bGih7gj57i R5Ug== X-Gm-Message-State: AOJu0Yz1sn+H/MxjvdPCS7zDab9wKH0nVJYOdOjTADeYqATXvUaoUAQV 3X8gbtx3sZMhr45R9jMPUaj9twJkYCKN0WhR41Ul8fLdK2G2eH65HQyj X-Gm-Gg: AR+sD12BD6XcbEwThH2o/jzE0W2NbC7OwdGHwkCnkBig/j0k/FeQD+Ulmc3Pvv508Pt ledM+xV5iVLJeStTpIENcfBTlg3qiGZ6TWVWlTt5PdjRjZ1AvgPt+FnheDj0wXTROQZZojnmYFq EhGzfqESTz/OuAMBeV7Vqnlhdf+sjxq9k11ap9Z7CsP1hk8ZQh/NnJe564D62F7f9FxlLRSy/Ts UYvkyxrCMwLMyNwHTfX3gewLVxt/wvpBPQhASudFxMcgotMWRA8XQDBWb8pcqXRaRfST3Eazp3v entYLj+ovXkmSP3MivLbZvbTrOWcSLUrsFrB8HwWq6iBLZWiu0HpBxe2EZPy+eu0nbvbCAO8BNk etVdL9X5eF4SU/IxiUzHk1nsWNCtZ9WSWTFckigvpLjAi7RPKxWYzhSNedXccpbe8f8kb85Mu1R Tu+pO6vW48mzIfJQcnvZI1JjtUxVtwJgdft8Uw7UwXeyv5RpyNrGJqWAsh8W/jfCVhGqqBa2qRe 2ba8rDHqw1aqCemHc6UBqEIf7DuvFsjlbXbXMwt3Cr2o/lRgHft1iDNILEO X-Received: by 2002:a17:902:dac9:b0:2ca:c411:78a with SMTP id d9443c01a7336-2d0521cc68amr9898765ad.3.1785520963885; Fri, 31 Jul 2026 11:02:43 -0700 (PDT) Received: from bloom.localdomain ([2604:3d09:178e:e100::6868]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d04ae5ea02sm8847175ad.28.2026.07.31.11.02.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 11:02:43 -0700 (PDT) From: Ivy Lopez To: kees@kernel.org Cc: linux-kernel@vger.kernel.org, Ivy Lopez Subject: [PATCH] bus: arm-cci: fix device_node reference leak in cci_probe_ports() Date: Fri, 31 Jul 2026 12:02:27 -0600 Message-ID: <20260731180227.234386-1-skunkolee@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit for_each_available_child_of_node() takes a reference on each child node in turn. When the number of matching CCI interface nodes in the DT exceeds nb_cci_ports, the loop exits via break without dropping the reference held on the current node, leaking it. Add the missing of_node_put() before the break. Signed-off-by: Ivy Lopez --- drivers/bus/arm-cci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c index 7f2baf057128..5ab3d74c9ae2 100644 --- a/drivers/bus/arm-cci.c +++ b/drivers/bus/arm-cci.c @@ -461,8 +461,10 @@ static int cci_probe_ports(struct device_node *np) i = nb_ace + nb_ace_lite; - if (i >= nb_cci_ports) + if (i >= nb_cci_ports) { + of_node_put(cp); break; + } if (of_property_read_string(cp, "interface-type", &match_str)) { -- 2.55.0