From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71DE635B636 for ; Fri, 31 Jul 2026 18:18:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785521932; cv=none; b=BmQrzYMsrm0Zcy9F12abpd5NJy8wG9JX5b5q1S0mnxc362gjdjFPTTjwOVLmnOB4n3yGelaht0fvTdtMhxoLXXFmbMrfMr4B4h/24bGLEZaSeyz49HhMNXQ2R5nUdJ4Ea39CkrPXw3ZR/fn1ajceLxMUp/bUWi2Y5ffpQK6t8Sc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785521932; c=relaxed/simple; bh=tA36+oaDcrqq1ErWQWvZt75nn5c0v28h/EegCzrkJ8Q=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=p7wzLt068v2Km9Rxqp9E+DpGGABoJvR6H59MLCZ2gnKJ9GxwFfUEBib9pXQGqheMuqgR3EWoQlh4lfwNBJPYqbBsR0E6wELEtTWUDjOjluRHgfO+8MUYtQcq65voyfNy+I7u8VacnFGgqAtZ1F01rkZmX2ewAPwr+M+2NRX737U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SC0U5SkD; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SC0U5SkD" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-47f81a3ccf9so1235621f8f.0 for ; Fri, 31 Jul 2026 11:18:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785521930; x=1786126730; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=zBCM5Nh2Z+pyL6wOrSHgIaBsinADA485LhOFyzTIsjs=; b=SC0U5SkDyiP7crz5Zm2tDRfRGf1+c0pyUW4oWDKc2eAr25PxCH/A6qxhvnFro26Vam aOk0Cscpe+CYg3qgq8Y+ZQGNLOhQKN06jVXnbPvXadto3DEB4gKczN3RafLeRPy3VPzQ grmQq45814xv1pXJjwNlXr0RHEgaq8jiEyT4uE+Fi7HZULoPfUZlHVnzwUAkKN43VGBU 73UH59rYpUIwUq0JSr22pkuLs85VrcR44k6lmaY9Ikv5L0FbiqKmx0no4WWQT1tPlbCD WjaXwtoc1ZvmPSm0o/fH/fe+KlZWy3Q/5GeUkAsR9DUq6ckolC703G+IToOF8w36kmcA ptnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785521930; x=1786126730; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zBCM5Nh2Z+pyL6wOrSHgIaBsinADA485LhOFyzTIsjs=; b=Jh6QLKcPgXEeaNg0jDNku2laz043Trl7oqsL3yHBmPB4o2bD1oMvubUq0beaUg8Soz tr9+RtKPlCDVwNf70ClghRhYWzXaxKz92CoDsceV5iMgAOnTMdtNlRRcIgCRQpweXrrZ 6jWrtSUztM2ptluTwFUC3ACwRHZWqrcvfowYZrGE9+KfWTMolgKp1IgsypeGkXoFu2Nn 54eHzk9ypjb217LHBrTx8s4jEmUODSwYA6jqzOHGVMCGZHOzPmRhFUZzHUVTvgD16tyM U8gkhiY1ElpbWjrT0P+KWSMJl2pU8RUwTHFvVbIGL8Fdd+auUzxmv/QJXYwGBnSDQJhi hVeg== X-Forwarded-Encrypted: i=1; AHgh+RpkHP7snendWXuL+rzrindW2vAYYUTRr9ddTEgWODauwTDhawoTnlWkzZume0OjaRp7G+QhFphJC8drxjk=@vger.kernel.org X-Gm-Message-State: AOJu0YwLaRF21gA5S7hAc6fiE7wJbfo1xw0aEcYWWc4kvSzy/OruCj9F mA+y6mXZ5GU5SNxCV6quX3tjYVEPZfEnEy7Sl8p4svPV0TXuVgMs/WXq X-Gm-Gg: AR+sD11KzBdtOFGOr8VdiAG9PbNKLkFGSr188znGgIdHCG227ON+E1ThfUca5dNgSa1 W1vbet3JCvCt6GaLDFVa5sJWLfMKqWoiVUyCAfdW5+pqIP5ISD+jDdCXqr9ekOyFluVZ4WFqIE0 VPo2uaNJx2Z8xfLdgKbxeeDKUE+Ksasrem9ydUWCCEoxj2oaBp+ae8qKsMeOPMhzYiNazI1nLG5 62MOVCZJhemgvloG/rz/tkHrXn+Dmzj7MasrFBZpDTahEXIdb175eJyzUcAPWE+1reFgXNcQEBC x5f1s4t4zROpAdTqicM4VPKeoD9jiOPUjVWwvE118B7YLrkwH3ph8boKWEd57NNdDo6AfhTMt/R hSvqutAcDZ8k4b/osx98obXzasErSI9WrRFVYJxqav4bN0dKhlEWAWdjOcRqjon3+kK0MJ/5Wwr DdPsd/RxoZjjaiXOvzr+gYmINZH5F5S4P4Ea78YBq0TgdSBr/YHYYAc6NflDYmNU1jflSRY+a0e Lsy7We//2LNGNPqLaNZNjguJKSeO4d7MU2Kl1bohoQ9LB6+M2smcN37P/bMT9UY45/EQbPyynGK agxev375RQUTANe9SEyz1oxA83s1vr4yWFyP3qZqPwhZlfgNiO/AdkFMDrdJJgtAHV75 X-Received: by 2002:a05:6000:c90:b0:47f:d0fb:ea40 with SMTP id ffacd0b85a97d-47fd72db353mr1079198f8f.21.1785521929339; Fri, 31 Jul 2026 11:18:49 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a02-3100-a8d0-bc01-6d31-3d12-3a11-d2d0.310.pool.telefonica.de. [2a02:3100:a8d0:bc01:6d31:3d12:3a11:d2d0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd41d1756sm7293694f8f.4.2026.07.31.11.18.47 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 31 Jul 2026 11:18:48 -0700 (PDT) From: Karl Mehltretter To: Greg Kroah-Hartman , Jiri Slaby Cc: Karl Mehltretter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 0/5] serial: fix console lifetime bugs on failed bind and removal Date: Fri, 31 Jul 2026 20:18:39 +0200 Message-Id: <20260731181844.11330-1-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series fixes four serial/tty error-path bugs and an i.MX console port-table lifetime bug. The fixes were found with failslab fail-nth sweeps and sysfs bind/unbind sequences under KASAN on QEMU's raspi1ap and mcimx6ul-evk machines. Patches 1-4 fix shared serial/tty core code. They move fallible allocations before console registration, clear pointers after uart_driver registration fails, and make a non-NULL tty cdev slot mean that the cdev is live. Patch 5 clears i.MX's devm-allocated port-table entry after failed probe and removal. It keeps the entry valid through console unregistration, rejects duplicate lines and serializes table updates against other port probes. Validation includes fail-nth sweeps on both boards. The i.MX tests also cover the sibling-probe race, sequential unbind/rebind and CONFIG_PROVE_LOCKING=y. Changes in v4: - No code changes. v3 was accidentally sent as individual mails. Resending as a single thread. Changes in v3: - Drop Cc: stable from patches 1-4. - Patch 1: remove redundant uport->name clearing and credit Sashiko's report with Reported-by and Closes trailers. - Split v2 patch 3 into two patches with corresponding Fixes tags. - Shorten the changelogs. - Patch 5: use scoped guards, reject occupied slots, remove the unnecessary line variable, document the console-callback locking constraint and add a backport note. Changes in v2: - Patch 4: serialize port registration and removal with imx_uart_ports[] updates to close the reported sibling-probe race. - Patches 1-3 are unchanged. v3: https://lore.kernel.org/r/20260731180343.10818-1-kmehltretter@gmail.com v2: https://lore.kernel.org/r/20260719221014.44354-1-kmehltretter@gmail.com v1: https://lore.kernel.org/r/20260719160812.35407-1-kmehltretter@gmail.com Karl Mehltretter (5): serial: core: do fallible allocations before the console can be registered serial: core: clear freed pointers on uart_register_driver() failure tty: skip cdev_del() when no cdev is registered tty: clear cdev pointer after cdev_add() failure serial: imx: serialize imx_uart_ports[] lifetime drivers/tty/serial/imx.c | 20 +++++++++++++++++--- drivers/tty/serial/serial_core.c | 32 ++++++++++++++++++-------------- drivers/tty/tty_io.c | 6 ++++-- 3 files changed, 39 insertions(+), 19 deletions(-) -- 2.53.0